aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/serial
diff options
context:
space:
mode:
authorJeff Dike <jdike@addtoit.com>2006-10-02 05:17:18 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-10-02 10:57:14 -0400
commitb68e31d0ebbcc909d1941f9f230c9d062a3a13d3 (patch)
treeb32902e5de02081cbb9eca49d7bb0b444e2b4f23 /drivers/serial
parented97bd37efd8ff7398d3a7eedf4bcbf245f5dad3 (diff)
[PATCH] const struct tty_operations
As part of an SMP cleanliness pass over UML, I consted a bunch of structures in order to not have to document their locking. One of these structures was a struct tty_operations. In order to const it in UML without introducing compiler complaints, the declaration of tty_set_operations needs to be changed, and then all of its callers need to be fixed. This patch declares all struct tty_operations in the tree as const. In all cases, they are static and used only as input to tty_set_operations. As an extra check, I ran an i386 allyesconfig build which produced no extra warnings. 53 drivers are affected. I checked the history of a bunch of them, and in most cases, there have been only a handful of maintenance changes in the last six months. serial_core.c was the busiest one that I looked at. Signed-off-by: Jeff Dike <jdike@addtoit.com> Acked-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/serial')
-rw-r--r--drivers/serial/68328serial.c2
-rw-r--r--drivers/serial/68360serial.c2
-rw-r--r--drivers/serial/crisv10.c2
-rw-r--r--drivers/serial/mcfserial.c2
-rw-r--r--drivers/serial/serial_core.c2
5 files changed, 5 insertions, 5 deletions
diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
index 993a702422ec..bac853c5abb5 100644
--- a/drivers/serial/68328serial.c
+++ b/drivers/serial/68328serial.c
@@ -1378,7 +1378,7 @@ void startup_console(void)
1378#endif /* CONFIG_PM_LEGACY */ 1378#endif /* CONFIG_PM_LEGACY */
1379 1379
1380 1380
1381static struct tty_operations rs_ops = { 1381static const struct tty_operations rs_ops = {
1382 .open = rs_open, 1382 .open = rs_open,
1383 .close = rs_close, 1383 .close = rs_close,
1384 .write = rs_write, 1384 .write = rs_write,
diff --git a/drivers/serial/68360serial.c b/drivers/serial/68360serial.c
index e80e70e9b126..1b299e8c57cd 100644
--- a/drivers/serial/68360serial.c
+++ b/drivers/serial/68360serial.c
@@ -2424,7 +2424,7 @@ long console_360_init(long kmem_start, long kmem_end)
2424*/ 2424*/
2425static int baud_idx; 2425static int baud_idx;
2426 2426
2427static struct tty_operations rs_360_ops = { 2427static const struct tty_operations rs_360_ops = {
2428 .owner = THIS_MODULE, 2428 .owner = THIS_MODULE,
2429 .open = rs_360_open, 2429 .open = rs_360_open,
2430 .close = rs_360_close, 2430 .close = rs_360_close,
diff --git a/drivers/serial/crisv10.c b/drivers/serial/crisv10.c
index cabd048c8636..9851d9eff022 100644
--- a/drivers/serial/crisv10.c
+++ b/drivers/serial/crisv10.c
@@ -4825,7 +4825,7 @@ show_serial_version(void)
4825 4825
4826/* rs_init inits the driver at boot (using the module_init chain) */ 4826/* rs_init inits the driver at boot (using the module_init chain) */
4827 4827
4828static struct tty_operations rs_ops = { 4828static const struct tty_operations rs_ops = {
4829 .open = rs_open, 4829 .open = rs_open,
4830 .close = rs_close, 4830 .close = rs_close,
4831 .write = rs_write, 4831 .write = rs_write,
diff --git a/drivers/serial/mcfserial.c b/drivers/serial/mcfserial.c
index 832abd3c4706..00d7859c167e 100644
--- a/drivers/serial/mcfserial.c
+++ b/drivers/serial/mcfserial.c
@@ -1666,7 +1666,7 @@ static void show_serial_version(void)
1666 printk(mcfrs_drivername); 1666 printk(mcfrs_drivername);
1667} 1667}
1668 1668
1669static struct tty_operations mcfrs_ops = { 1669static const struct tty_operations mcfrs_ops = {
1670 .open = mcfrs_open, 1670 .open = mcfrs_open,
1671 .close = mcfrs_close, 1671 .close = mcfrs_close,
1672 .write = mcfrs_write, 1672 .write = mcfrs_write,
diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 5f7ba1adb309..de5e8930a6fd 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -2111,7 +2111,7 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
2111 } 2111 }
2112} 2112}
2113 2113
2114static struct tty_operations uart_ops = { 2114static const struct tty_operations uart_ops = {
2115 .open = uart_open, 2115 .open = uart_open,
2116 .close = uart_close, 2116 .close = uart_close,
2117 .write = uart_write, 2117 .write = uart_write,