aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/serial
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2010-06-01 16:53:10 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-08-10 16:47:44 -0400
commite142a31da34b42458e10026b554e66127739cf23 (patch)
tree1f65a42cd559116223e1fa1db7631cd449c73968 /drivers/serial
parentb07471fa51358ce64cc25e1501544502362e4404 (diff)
tty: release BTM while sleeping in block_til_ready
Most tty drivers may block while opening a device. Since this possibly depends on another thread closing it first and both threads may need the BTM, we need to release it here. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/serial')
-rw-r--r--drivers/serial/68328serial.c2
-rw-r--r--drivers/serial/68360serial.c2
-rw-r--r--drivers/serial/crisv10.c2
3 files changed, 6 insertions, 0 deletions
diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
index 9330edb323e2..d8204f4ebbb4 100644
--- a/drivers/serial/68328serial.c
+++ b/drivers/serial/68328serial.c
@@ -1235,7 +1235,9 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
1235 retval = -ERESTARTSYS; 1235 retval = -ERESTARTSYS;
1236 break; 1236 break;
1237 } 1237 }
1238 tty_unlock();
1238 schedule(); 1239 schedule();
1240 tty_lock();
1239 } 1241 }
1240 current->state = TASK_RUNNING; 1242 current->state = TASK_RUNNING;
1241 remove_wait_queue(&info->open_wait, &wait); 1243 remove_wait_queue(&info->open_wait, &wait);
diff --git a/drivers/serial/68360serial.c b/drivers/serial/68360serial.c
index edcf1cc089d1..0dff3bbddc8b 100644
--- a/drivers/serial/68360serial.c
+++ b/drivers/serial/68360serial.c
@@ -1860,7 +1860,9 @@ static int block_til_ready(struct tty_struct *tty, struct file * filp,
1860 printk("block_til_ready blocking: ttys%d, count = %d\n", 1860 printk("block_til_ready blocking: ttys%d, count = %d\n",
1861 info->line, state->count); 1861 info->line, state->count);
1862#endif 1862#endif
1863 tty_unlock();
1863 schedule(); 1864 schedule();
1865 tty_lock();
1864 } 1866 }
1865 current->state = TASK_RUNNING; 1867 current->state = TASK_RUNNING;
1866 remove_wait_queue(&info->open_wait, &wait); 1868 remove_wait_queue(&info->open_wait, &wait);
diff --git a/drivers/serial/crisv10.c b/drivers/serial/crisv10.c
index 8e356c5eeae0..5696710b6f2d 100644
--- a/drivers/serial/crisv10.c
+++ b/drivers/serial/crisv10.c
@@ -4066,7 +4066,9 @@ block_til_ready(struct tty_struct *tty, struct file * filp,
4066 printk("block_til_ready blocking: ttyS%d, count = %d\n", 4066 printk("block_til_ready blocking: ttyS%d, count = %d\n",
4067 info->line, info->count); 4067 info->line, info->count);
4068#endif 4068#endif
4069 tty_unlock();
4069 schedule(); 4070 schedule();
4071 tty_lock();
4070 } 4072 }
4071 set_current_state(TASK_RUNNING); 4073 set_current_state(TASK_RUNNING);
4072 remove_wait_queue(&info->open_wait, &wait); 4074 remove_wait_queue(&info->open_wait, &wait);