Merge /spare/repo/linux-2.6/

18 files changed, 260 insertions, 304 deletions

diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
index db92a0ceda79..feb8e73fc1c9 100644
--- a/drivers/serial/68328serial.c
+++ b/drivers/serial/68328serial.c
@@ -992,18 +992,17 @@ static int get_lsr_info(struct m68k_serial * info, unsigned int *value)
 /*
  * This routine sends a break character out the serial port.
  */
-static void send_break( struct m68k_serial * info, int duration)
+static void send_break(struct m68k_serial * info, unsigned int duration)
 {
         m68328_uart *uart = &uart_addr[info->line];
         unsigned long flags;
         if (!info->port)
                 return;
-        set_current_state(TASK_INTERRUPTIBLE);
         save_flags(flags);
         cli();
 #ifdef USE_INTS 
         uart->utx.w |= UTX_SEND_BREAK;
-        schedule_timeout(duration);
+        msleep_interruptible(duration);
         uart->utx.w &= ~UTX_SEND_BREAK;
 #endif          
         restore_flags(flags);
@@ -1033,14 +1032,14 @@ static int rs_ioctl(struct tty_struct *tty, struct file * file,
                                 return retval;
                         tty_wait_until_sent(tty, 0);
                         if (!arg)
-                                send_break(info, HZ/4); /* 1/4 second */
+                                send_break(info, 250);  /* 1/4 second */
                         return 0;
                 case TCSBRKP:   /* support for POSIX tcsendbreak() */
                         retval = tty_check_change(tty);
                         if (retval)
                                 return retval;
                         tty_wait_until_sent(tty, 0);
-                        send_break(info, arg ? arg*(HZ/10) : HZ/4);
+                        send_break(info, arg ? arg*(100) : 250);
                         return 0;
                 case TIOCGSOFTCAR:
                         error = put_user(C_CLOCAL(tty) ? 1 : 0,
diff --git a/drivers/serial/68360serial.c b/drivers/serial/68360serial.c
index f148022b6b4e..b116122e569a 100644
--- a/drivers/serial/68360serial.c
+++ b/drivers/serial/68360serial.c
@@ -1394,14 +1394,13 @@ static void end_break(ser_info_t *info)
 /*
  * This routine sends a break character out the serial port.
  */
-static void send_break(ser_info_t *info, int duration)
+static void send_break(ser_info_t *info, unsigned int duration)
 {
-        set_current_state(TASK_INTERRUPTIBLE);
 #ifdef SERIAL_DEBUG_SEND_BREAK
         printk("rs_send_break(%d) jiff=%lu...", duration, jiffies);
 #endif
         begin_break(info);
-        schedule_timeout(duration);
+        msleep_interruptible(duration);
         end_break(info);
 #ifdef SERIAL_DEBUG_SEND_BREAK
         printk("done jiffies=%lu\n", jiffies);
@@ -1436,7 +1435,7 @@ static int rs_360_ioctl(struct tty_struct *tty, struct file * file,
                         if (signal_pending(current))
                                 return -EINTR;
                         if (!arg) {
-                                send_break(info, HZ/4); /* 1/4 second */
+                                send_break(info, 250);  /* 1/4 second */
                                 if (signal_pending(current))
                                         return -EINTR;
                         }
@@ -1448,7 +1447,7 @@ static int rs_360_ioctl(struct tty_struct *tty, struct file * file,
                         tty_wait_until_sent(tty, 0);
                         if (signal_pending(current))
                                 return -EINTR;
-                        send_break(info, arg ? arg*(HZ/10) : HZ/4);
+                        send_break(info, arg ? arg*100 : 250);
                         if (signal_pending(current))
                                 return -EINTR;
                         return 0;
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 30e8beb71430..d8b9d2b8c200 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -132,9 +132,9 @@ struct uart_8250_port {
         struct uart_port        port;
         struct timer_list       timer;          /* "no irq" timer */
         struct list_head        list;           /* ports on this IRQ */
-        unsigned int            capabilities;   /* port capabilities */
+        unsigned short          capabilities;   /* port capabilities */
+        unsigned short          bugs;           /* port bugs */
         unsigned int            tx_loadsz;      /* transmit fifo load size */
-        unsigned short          rev;
         unsigned char           acr;
         unsigned char           ier;
         unsigned char           lcr;
@@ -560,7 +560,14 @@ static void autoconfig_has_efr(struct uart_8250_port *up)
         if (id1 == 0x16 && id2 == 0xC9 &&
             (id3 == 0x50 || id3 == 0x52 || id3 == 0x54)) {
                 up->port.type = PORT_16C950;
-                up->rev = rev | (id3 << 8);
+
+                /*
+                 * Enable work around for the Oxford Semiconductor 952 rev B
+                 * chip which causes it to seriously miscalculate baud rates
+                 * when DLL is 0.
+                 */
+                if (id3 == 0x52 && rev == 0x01)
+                        up->bugs |= UART_BUG_QUOT;
                 return;
         }
         
@@ -577,8 +584,6 @@ static void autoconfig_has_efr(struct uart_8250_port *up)
 
         id2 = id1 >> 8;
         if (id2 == 0x10 || id2 == 0x12 || id2 == 0x14) {
-                if (id2 == 0x10)
-                        up->rev = id1 & 255;
                 up->port.type = PORT_16850;
                 return;
         }
@@ -809,6 +814,7 @@ static void autoconfig(struct uart_8250_port *up, unsigned int probeflags)
 //      save_flags(flags); cli();
 
         up->capabilities = 0;
+        up->bugs = 0;
 
         if (!(up->port.flags & UPF_BUGGY_UART)) {
                 /*
@@ -1021,6 +1027,8 @@ static void serial8250_stop_tx(struct uart_port *port, unsigned int tty_stop)
         }
 }
 
+static void transmit_chars(struct uart_8250_port *up);
+
 static void serial8250_start_tx(struct uart_port *port, unsigned int tty_start)
 {
         struct uart_8250_port *up = (struct uart_8250_port *)port;
@@ -1028,6 +1036,14 @@ static void serial8250_start_tx(struct uart_port *port, unsigned int tty_start)
         if (!(up->ier & UART_IER_THRI)) {
                 up->ier |= UART_IER_THRI;
                 serial_out(up, UART_IER, up->ier);
+
+                if (up->bugs & UART_BUG_TXEN) {
+                        unsigned char lsr, iir;
+                        lsr = serial_in(up, UART_LSR);
+                        iir = serial_in(up, UART_IIR);
+                        if (lsr & UART_LSR_TEMT && iir & UART_IIR_NO_INT)
+                                transmit_chars(up);
+                }
         }
         /*
          * We only do this from uart_start
@@ -1433,6 +1449,7 @@ static int serial8250_startup(struct uart_port *port)
 {
         struct uart_8250_port *up = (struct uart_8250_port *)port;
         unsigned long flags;
+        unsigned char lsr, iir;
         int retval;
 
         up->capabilities = uart_config[up->port.type].flags;
@@ -1536,6 +1553,26 @@ static int serial8250_startup(struct uart_port *port)
                         up->port.mctrl |= TIOCM_OUT2;
 
         serial8250_set_mctrl(&up->port, up->port.mctrl);
+
+        /*
+         * Do a quick test to see if we receive an
+         * interrupt when we enable the TX irq.
+         */
+        serial_outp(up, UART_IER, UART_IER_THRI);
+        lsr = serial_in(up, UART_LSR);
+        iir = serial_in(up, UART_IIR);
+        serial_outp(up, UART_IER, 0);
+
+        if (lsr & UART_LSR_TEMT && iir & UART_IIR_NO_INT) {
+                if (!(up->bugs & UART_BUG_TXEN)) {
+                        up->bugs |= UART_BUG_TXEN;
+                        pr_debug("ttyS%d - enabling bad tx status workarounds\n",
+                                 port->line);
+                }
+        } else {
+                up->bugs &= ~UART_BUG_TXEN;
+        }
+
         spin_unlock_irqrestore(&up->port.lock, flags);
 
         /*
@@ -1645,22 +1682,22 @@ serial8250_set_termios(struct uart_port *port, struct termios *termios,
 
         switch (termios->c_cflag & CSIZE) {
         case CS5:
-                cval = 0x00;
+                cval = UART_LCR_WLEN5;
                 break;
         case CS6:
-                cval = 0x01;
+                cval = UART_LCR_WLEN6;
                 break;
         case CS7:
-                cval = 0x02;
+                cval = UART_LCR_WLEN7;
                 break;
         default:
         case CS8:
-                cval = 0x03;
+                cval = UART_LCR_WLEN8;
                 break;
         }
 
         if (termios->c_cflag & CSTOPB)
-                cval |= 0x04;
+                cval |= UART_LCR_STOP;
         if (termios->c_cflag & PARENB)
                 cval |= UART_LCR_PARITY;
         if (!(termios->c_cflag & PARODD))
@@ -1677,12 +1714,9 @@ serial8250_set_termios(struct uart_port *port, struct termios *termios,
         quot = serial8250_get_divisor(port, baud);
 
         /*
-         * Work around a bug in the Oxford Semiconductor 952 rev B
-         * chip which causes it to seriously miscalculate baud rates
-         * when DLL is 0.
+         * Oxford Semi 952 rev B workaround
          */
-        if ((quot & 0xff) == 0 && up->port.type == PORT_16C950 &&
-            up->rev == 0x5201)
+        if (up->bugs & UART_BUG_QUOT && (quot & 0xff) == 0)
                 quot ++;
 
         if (up->capabilities & UART_CAP_FIFO && up->port.fifosize > 1) {
diff --git a/drivers/serial/8250.h b/drivers/serial/8250.h
index 4f3d62f222f4..9225c82faeb8 100644
--- a/drivers/serial/8250.h
+++ b/drivers/serial/8250.h
@@ -51,6 +51,9 @@ struct serial8250_config {
 #define UART_CAP_AFE    (1 << 11)       /* MCR-based hw flow control */
 #define UART_CAP_UUE    (1 << 12)       /* UART needs IER bit 6 set (Xscale) */
 
+#define UART_BUG_QUOT   (1 << 0)        /* UART has buggy quot LSB */
+#define UART_BUG_TXEN   (1 << 1)        /* UART has buggy TX IIR status */
+
 #if defined(__i386__) && (defined(CONFIG_M386) || defined(CONFIG_M486))
 #define _INLINE_ inline
 #else
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 6e44b46c9e9d..25fcef2c42de 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -753,7 +753,7 @@ config SERIAL_MPC52xx_CONSOLE_BAUD
 
 config SERIAL_ICOM
         tristate "IBM Multiport Serial Adapter"
-        depends on PPC_ISERIES || PPC_PSERIES
+        depends on PCI && (PPC_ISERIES || PPC_PSERIES)
         select SERIAL_CORE
         help
           This driver is for a family of multiport serial adapters
@@ -843,4 +843,13 @@ config SERIAL_JSM
           To compile this driver as a module, choose M here: the
           module will be called jsm.
 
+config SERIAL_SGI_IOC4
+        tristate "SGI IOC4 controller serial support"
+        depends on (IA64_GENERIC || IA64_SGI_SN2) && SGI_IOC4
+        select SERIAL_CORE
+        help
+                If you have an SGI Altix with an IOC4 based Base IO card
+                and wish to use the serial ports on this card, say Y.
+                Otherwise, say N.
+
 endmenu
diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
index 81b77d769b84..8f1cdde7dbed 100644
--- a/drivers/serial/Makefile
+++ b/drivers/serial/Makefile
@@ -51,4 +51,4 @@ obj-$(CONFIG_ETRAX_SERIAL) += crisv10.o
 obj-$(CONFIG_SERIAL_JSM) += jsm/
 obj-$(CONFIG_SERIAL_TXX9) += serial_txx9.o
 obj-$(CONFIG_SERIAL_VR41XX) += vr41xx_siu.o
-obj-$(CONFIG_BLK_DEV_SGIIOC4) += ioc4_serial.o
+obj-$(CONFIG_SERIAL_SGI_IOC4) += ioc4_serial.o
diff --git a/drivers/serial/au1x00_uart.c b/drivers/serial/au1x00_uart.c
index b6d3d5034940..5400dc2c087e 100644
--- a/drivers/serial/au1x00_uart.c
+++ b/drivers/serial/au1x00_uart.c
@@ -773,22 +773,22 @@ serial8250_set_termios(struct uart_port *port, struct termios *termios,
 
         switch (termios->c_cflag & CSIZE) {
         case CS5:
-                cval = 0x00;
+                cval = UART_LCR_WLEN5;
                 break;
         case CS6:
-                cval = 0x01;
+                cval = UART_LCR_WLEN6;
                 break;
         case CS7:
-                cval = 0x02;
+                cval = UART_LCR_WLEN7;
                 break;
         default:
         case CS8:
-                cval = 0x03;
+                cval = UART_LCR_WLEN8;
                 break;
         }
 
         if (termios->c_cflag & CSTOPB)
-                cval |= 0x04;
+                cval |= UART_LCR_STOP;
         if (termios->c_cflag & PARENB)
                 cval |= UART_LCR_PARITY;
         if (!(termios->c_cflag & PARODD))
diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
index b422c3abfba6..c4c8f4b44f53 100644
--- a/drivers/serial/cpm_uart/cpm_uart_cpm2.c
+++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
@@ -134,12 +134,21 @@ void scc1_lineif(struct uart_cpm_port *pinfo)
 
 void scc2_lineif(struct uart_cpm_port *pinfo)
 {
+        /*
+         * STx GP3 uses the SCC2 secondary option pin assignment
+         * which this driver doesn't account for in the static
+         * pin assignments. This kind of board specific info
+         * really has to get out of the driver so boards can
+         * be supported in a sane fashion.
+         */
+#ifndef CONFIG_STX_GP3
         volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
         io->iop_pparb |= 0x008b0000;
         io->iop_pdirb |= 0x00880000;
         io->iop_psorb |= 0x00880000;
         io->iop_pdirb &= ~0x00030000;
         io->iop_psorb &= ~0x00030000;
+#endif
         cpm2_immr->im_cpmux.cmx_scr &= 0xff00ffff;
         cpm2_immr->im_cpmux.cmx_scr |= 0x00090000;
         pinfo->brg = 2;
diff --git a/drivers/serial/icom.h b/drivers/serial/icom.h
index 23dc0f7ddf8b..798f1ef23712 100644
--- a/drivers/serial/icom.h
+++ b/drivers/serial/icom.h
@@ -286,5 +286,3 @@ struct lookup_int_table {
         u32     __iomem *global_int_mask;
         unsigned long   processor_id;
 };
-
-#define MSECS_TO_JIFFIES(ms) (((ms)*HZ+999)/1000)
diff --git a/drivers/serial/ioc4_serial.c b/drivers/serial/ioc4_serial.c
index ba4e13a22a50..793c3a7cbe47 100644
--- a/drivers/serial/ioc4_serial.c
+++ b/drivers/serial/ioc4_serial.c
@@ -20,7 +20,7 @@
 #include <linux/serial_reg.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/ioc4_common.h>
+#include <linux/ioc4.h>
 #include <linux/serial_core.h>
 
 /*
@@ -130,12 +130,19 @@
                                  IOC4_SIO_IR_S3_TX_EXPLICIT)
 
 /* Bitmasks for IOC4_OTHER_IR, IOC4_OTHER_IEC, and IOC4_OTHER_IES  */
-#define IOC4_OTHER_IR_ATA_INT           0x00000001  /* ATAPI intr pass-thru */
-#define IOC4_OTHER_IR_ATA_MEMERR        0x00000002  /* ATAPI DMA PCI error */
-#define IOC4_OTHER_IR_S0_MEMERR         0x00000004  /* Port 0 PCI error */
-#define IOC4_OTHER_IR_S1_MEMERR         0x00000008  /* Port 1 PCI error */
-#define IOC4_OTHER_IR_S2_MEMERR         0x00000010  /* Port 2 PCI error */
-#define IOC4_OTHER_IR_S3_MEMERR         0x00000020  /* Port 3 PCI error */
+#define IOC4_OTHER_IR_ATA_INT           0x00000001  /* ATAPI intr pass-thru */
+#define IOC4_OTHER_IR_ATA_MEMERR        0x00000002  /* ATAPI DMA PCI error */
+#define IOC4_OTHER_IR_S0_MEMERR         0x00000004  /* Port 0 PCI error */
+#define IOC4_OTHER_IR_S1_MEMERR         0x00000008  /* Port 1 PCI error */
+#define IOC4_OTHER_IR_S2_MEMERR         0x00000010  /* Port 2 PCI error */
+#define IOC4_OTHER_IR_S3_MEMERR         0x00000020  /* Port 3 PCI error */
+#define IOC4_OTHER_IR_KBD_INT           0x00000040  /* Keyboard/mouse */
+#define IOC4_OTHER_IR_RESERVED          0x007fff80  /* Reserved */
+#define IOC4_OTHER_IR_RT_INT            0x00800000  /* INT_OUT section output */
+#define IOC4_OTHER_IR_GEN_INT           0xff000000  /* Generic pins */
+
+#define IOC4_OTHER_IR_SER_MEMERR (IOC4_OTHER_IR_S0_MEMERR | IOC4_OTHER_IR_S1_MEMERR | \
+                                  IOC4_OTHER_IR_S2_MEMERR | IOC4_OTHER_IR_S3_MEMERR)
 
 /* Bitmasks for IOC4_SIO_CR */
 #define IOC4_SIO_CR_CMD_PULSE_SHIFT              0  /* byte bus strobe shift */
@@ -274,70 +281,24 @@ struct ioc4_uartregs {
 #define i4u_dlm u2.dlm
 #define i4u_fcr u3.fcr
 
-/* PCI memory space register map addressed using pci_bar0 */
-struct ioc4_memregs {
-        struct ioc4_mem {
-                /* Miscellaneous IOC4  registers */
-                uint32_t pci_err_addr_l;
-                uint32_t pci_err_addr_h;
-                uint32_t sio_ir;
-                uint32_t other_ir;
-
-                /* These registers are read-only for general kernel code.  */
-                uint32_t sio_ies_ro;
-                uint32_t other_ies_ro;
-                uint32_t sio_iec_ro;
-                uint32_t other_iec_ro;
-                uint32_t sio_cr;
-                uint32_t misc_fill1;
-                uint32_t int_out;
-                uint32_t misc_fill2;
-                uint32_t gpcr_s;
-                uint32_t gpcr_c;
-                uint32_t gpdr;
-                uint32_t misc_fill3;
-                uint32_t gppr_0;
-                uint32_t gppr_1;
-                uint32_t gppr_2;
-                uint32_t gppr_3;
-                uint32_t gppr_4;
-                uint32_t gppr_5;
-                uint32_t gppr_6;
-                uint32_t gppr_7;
-        } ioc4_mem;
-
-        char misc_fill4[0x100 - 0x5C - 4];
-
-        /* ATA/ATAP registers */
-        uint32_t ata_notused[9];
-        char ata_fill1[0x140 - 0x120 - 4];
-        uint32_t ata_notused1[8];
-        char ata_fill2[0x200 - 0x15C - 4];
-
-        /* Keyboard and mouse registers */
-        uint32_t km_notused[5];;
-        char km_fill1[0x300 - 0x210 - 4];
-
-        /* Serial port registers used for DMA serial I/O */
-        struct ioc4_serial {
-                uint32_t sbbr01_l;
-                uint32_t sbbr01_h;
-                uint32_t sbbr23_l;
-                uint32_t sbbr23_h;
-
-                struct ioc4_serialregs port_0;
-                struct ioc4_serialregs port_1;
-                struct ioc4_serialregs port_2;
-                struct ioc4_serialregs port_3;
-                struct ioc4_uartregs uart_0;
-                struct ioc4_uartregs uart_1;
-                struct ioc4_uartregs uart_2;
-                struct ioc4_uartregs uart_3;
-        } ioc4_serial;
-};
+/* Serial port registers used for DMA serial I/O */
+struct ioc4_serial {
+        uint32_t sbbr01_l;
+        uint32_t sbbr01_h;
+        uint32_t sbbr23_l;
+        uint32_t sbbr23_h;
+
+        struct ioc4_serialregs port_0;
+        struct ioc4_serialregs port_1;
+        struct ioc4_serialregs port_2;
+        struct ioc4_serialregs port_3;
+        struct ioc4_uartregs uart_0;
+        struct ioc4_uartregs uart_1;
+        struct ioc4_uartregs uart_2;
+        struct ioc4_uartregs uart_3;
+} ioc4_serial;
 
 /* UART clock speed */
-#define IOC4_SER_XIN_CLK        IOC4_SER_XIN_CLK_66
 #define IOC4_SER_XIN_CLK_66     66666667
 #define IOC4_SER_XIN_CLK_33     33333333
 
@@ -412,8 +373,8 @@ enum sio_proto {
                                         | UART_LCR_WLEN7 | UART_LCR_WLEN8)
 #define LCR_MASK_STOP_BITS      (UART_LCR_STOP)
 
-#define PENDING(_p)     (readl(&(_p)->ip_mem->sio_ir) & _p->ip_ienb)
-#define READ_SIO_IR(_p) readl(&(_p)->ip_mem->sio_ir)
+#define PENDING(_p)     (readl(&(_p)->ip_mem->sio_ir.raw) & _p->ip_ienb)
+#define READ_SIO_IR(_p) readl(&(_p)->ip_mem->sio_ir.raw)
 
 /* Default to 4k buffers */
 #ifdef IOC4_1K_BUFFERS
@@ -447,7 +408,7 @@ struct ioc4_control {
  */
 #define MAX_IOC4_INTR_ENTS      (8 * sizeof(uint32_t))
 struct ioc4_soft {
-        struct ioc4_mem __iomem *is_ioc4_mem_addr;
+        struct ioc4_misc_regs __iomem *is_ioc4_misc_addr;
         struct ioc4_serial __iomem *is_ioc4_serial_addr;
 
         /* Each interrupt type has an entry in the array */
@@ -486,7 +447,7 @@ struct ioc4_port {
         struct ioc4_soft *ip_ioc4_soft;
 
         /* pci mem addresses */
-        struct ioc4_mem __iomem *ip_mem;
+        struct ioc4_misc_regs __iomem *ip_mem;
         struct ioc4_serial __iomem *ip_serial;
         struct ioc4_serialregs __iomem *ip_serial_regs;
         struct ioc4_uartregs __iomem *ip_uart_regs;
@@ -553,7 +514,7 @@ struct hooks {
         uint32_t intr_dma_error;
         uint32_t intr_clear;
         uint32_t intr_all;
-        char rs422_select_pin;
+        int rs422_select_pin;
 };
 
 static struct hooks hooks_array[IOC4_NUM_SERIAL_PORTS] = {
@@ -669,7 +630,7 @@ static void handle_intr(void *arg, uint32_t sio_ir);
 static inline void
 write_ireg(struct ioc4_soft *ioc4_soft, uint32_t val, int which, int type)
 {
-        struct ioc4_mem __iomem *mem = ioc4_soft->is_ioc4_mem_addr;
+        struct ioc4_misc_regs __iomem *mem = ioc4_soft->is_ioc4_misc_addr;
         unsigned long flags;
 
         spin_lock_irqsave(&ioc4_soft->is_ir_lock, flags);
@@ -678,11 +639,11 @@ write_ireg(struct ioc4_soft *ioc4_soft, uint32_t val, int which, int type)
         case IOC4_SIO_INTR_TYPE:
                 switch (which) {
                 case IOC4_W_IES:
-                        writel(val, &mem->sio_ies_ro);
+                        writel(val, &mem->sio_ies.raw);
                         break;
 
                 case IOC4_W_IEC:
-                        writel(val, &mem->sio_iec_ro);
+                        writel(val, &mem->sio_iec.raw);
                         break;
                 }
                 break;
@@ -690,11 +651,11 @@ write_ireg(struct ioc4_soft *ioc4_soft, uint32_t val, int which, int type)
         case IOC4_OTHER_INTR_TYPE:
                 switch (which) {
                 case IOC4_W_IES:
-                        writel(val, &mem->other_ies_ro);
+                        writel(val, &mem->other_ies.raw);
                         break;
 
                 case IOC4_W_IEC:
-                        writel(val, &mem->other_iec_ro);
+                        writel(val, &mem->other_iec.raw);
                         break;
                 }
                 break;
@@ -747,7 +708,8 @@ static int set_baud(struct ioc4_port *port, int baud)
  */
 static struct ioc4_port *get_ioc4_port(struct uart_port *the_port)
 {
-        struct ioc4_control *control = dev_get_drvdata(the_port->dev);
+        struct ioc4_driver_data *idd = dev_get_drvdata(the_port->dev);
+        struct ioc4_control *control = idd->idd_serial_data;
         int ii;
 
         if (control) {
@@ -782,7 +744,7 @@ static struct ioc4_port *get_ioc4_port(struct uart_port *the_port)
 static inline uint32_t
 pending_intrs(struct ioc4_soft *soft, int type)
 {
-        struct ioc4_mem __iomem *mem = soft->is_ioc4_mem_addr;
+        struct ioc4_misc_regs __iomem *mem = soft->is_ioc4_misc_addr;
         unsigned long flag;
         uint32_t intrs = 0;
 
@@ -793,11 +755,11 @@ pending_intrs(struct ioc4_soft *soft, int type)
 
         switch (type) {
         case IOC4_SIO_INTR_TYPE:
-                intrs = readl(&mem->sio_ir) & readl(&mem->sio_ies_ro);
+                intrs = readl(&mem->sio_ir.raw) & readl(&mem->sio_ies.raw);
                 break;
 
         case IOC4_OTHER_INTR_TYPE:
-                intrs = readl(&mem->other_ir) & readl(&mem->other_ies_ro);
+                intrs = readl(&mem->other_ir.raw) & readl(&mem->other_ies.raw);
 
                 /* Don't process any ATA interrupte */
                 intrs &= ~(IOC4_OTHER_IR_ATA_INT | IOC4_OTHER_IR_ATA_MEMERR);
@@ -826,7 +788,7 @@ static int inline port_init(struct ioc4_port *port)
 
         /* Wait until any pending bus activity for this port has ceased */
         do
-                sio_cr = readl(&port->ip_mem->sio_cr);
+                sio_cr = readl(&port->ip_mem->sio_cr.raw);
         while (!(sio_cr & IOC4_SIO_CR_SIO_DIAG_IDLE));
 
         /* Finish reset sequence */
@@ -899,7 +861,7 @@ static int inline port_init(struct ioc4_port *port)
         write_ireg(port->ip_ioc4_soft, hooks->intr_clear,
                        IOC4_W_IEC, IOC4_SIO_INTR_TYPE);
         port->ip_ienb &= ~hooks->intr_clear;
-        writel(hooks->intr_clear, &port->ip_mem->sio_ir);
+        writel(hooks->intr_clear, &port->ip_mem->sio_ir.raw);
         return 0;
 }
 
@@ -918,23 +880,23 @@ static void handle_dma_error_intr(void *arg, uint32_t other_ir)
         spin_lock_irqsave(&port->ip_lock, flags);
 
         /* ACK the interrupt */
-        writel(hooks->intr_dma_error, &port->ip_mem->other_ir);
+        writel(hooks->intr_dma_error, &port->ip_mem->other_ir.raw);
 
-        if (readl(&port->ip_mem->pci_err_addr_l) & IOC4_PCI_ERR_ADDR_VLD) {
+        if (readl(&port->ip_mem->pci_err_addr_l.raw) & IOC4_PCI_ERR_ADDR_VLD) {
                 printk(KERN_ERR
                         "PCI error address is 0x%lx, "
                                 "master is serial port %c %s\n",
                      (((uint64_t)readl(&port->ip_mem->pci_err_addr_h)
                                                          << 32)
-                                | readl(&port->ip_mem->pci_err_addr_l))
+                                | readl(&port->ip_mem->pci_err_addr_l.raw))
                                         & IOC4_PCI_ERR_ADDR_ADDR_MSK, '1' +
-                     ((char)(readl(&port->ip_mem-> pci_err_addr_l) &
+                     ((char)(readl(&port->ip_mem->pci_err_addr_l.raw) &
                              IOC4_PCI_ERR_ADDR_MST_NUM_MSK) >> 1),
-                     (readl(&port->ip_mem->pci_err_addr_l)
+                     (readl(&port->ip_mem->pci_err_addr_l.raw)
                                 & IOC4_PCI_ERR_ADDR_MST_TYP_MSK)
                                 ? "RX" : "TX");
 
-                if (readl(&port->ip_mem->pci_err_addr_l)
+                if (readl(&port->ip_mem->pci_err_addr_l.raw)
                                                 & IOC4_PCI_ERR_ADDR_MUL_ERR) {
                         printk(KERN_ERR
                                 "Multiple errors occurred\n");
@@ -1018,26 +980,26 @@ static irqreturn_t ioc4_intr(int irq, void *arg, struct pt_regs *regs)
                                 "other_ies = 0x%x\n",
                                (intr_type == IOC4_SIO_INTR_TYPE) ? "sio" :
                                "other", this_ir,
-                               readl(&soft->is_ioc4_mem_addr->sio_ir),
-                               readl(&soft->is_ioc4_mem_addr->sio_ies_ro),
-                               readl(&soft->is_ioc4_mem_addr->other_ir),
-                               readl(&soft->is_ioc4_mem_addr->other_ies_ro));
+                               readl(&soft->is_ioc4_misc_addr->sio_ir.raw),
+                               readl(&soft->is_ioc4_misc_addr->sio_ies.raw),
+                               readl(&soft->is_ioc4_misc_addr->other_ir.raw),
+                               readl(&soft->is_ioc4_misc_addr->other_ies.raw));
                 }
         }
 #ifdef DEBUG_INTERRUPTS
         {
-                struct ioc4_mem __iomem *mem = soft->is_ioc4_mem_addr;
+                struct ioc4_misc_regs __iomem *mem = soft->is_ioc4_misc_addr;
                 spinlock_t *lp = &soft->is_ir_lock;
                 unsigned long flag;
 
                 spin_lock_irqsave(&soft->is_ir_lock, flag);
-                printk ("%s : %d : mem 0x%p sio_ir 0x%x sio_ies_ro 0x%x "
-                                "other_ir 0x%x other_ies_ro 0x%x mask 0x%x\n",
+                printk ("%s : %d : mem 0x%p sio_ir 0x%x sio_ies 0x%x "
+                                "other_ir 0x%x other_ies 0x%x mask 0x%x\n",
                      __FUNCTION__, __LINE__,
-                     (void *)mem, readl(&mem->sio_ir),
-                     readl(&mem->sio_ies_ro),
-                     readl(&mem->other_ir),
-                     readl(&mem->other_ies_ro),
+                     (void *)mem, readl(&mem->sio_ir.raw),
+                     readl(&mem->sio_ies.raw),
+                     readl(&mem->other_ir.raw),
+                     readl(&mem->other_ies.raw),
                      IOC4_OTHER_IR_ATA_INT | IOC4_OTHER_IR_ATA_MEMERR);
                 spin_unlock_irqrestore(&soft->is_ir_lock, flag);
         }
@@ -1049,21 +1011,20 @@ static irqreturn_t ioc4_intr(int irq, void *arg, struct pt_regs *regs)
  * ioc4_attach_local - Device initialization.
  *                      Called at *_attach() time for each
  *                      IOC4 with serial ports in the system.
- * @control: ioc4_control ptr
- * @pdev: PCI handle for this device
- * @soft: soft struct for this device
- * @ioc4: ioc4 mem space
+ * @idd: Master module data for this IOC4
  */
-static int inline ioc4_attach_local(struct pci_dev *pdev,
-                        struct ioc4_control *control,
-                        struct ioc4_soft *soft, void __iomem *ioc4_mem,
-                        void __iomem *ioc4_serial)
+static int inline ioc4_attach_local(struct ioc4_driver_data *idd)
 {
         struct ioc4_port *port;
         struct ioc4_port *ports[IOC4_NUM_SERIAL_PORTS];
         int port_number;
         uint16_t ioc4_revid_min = 62;
         uint16_t ioc4_revid;
+        struct pci_dev *pdev = idd->idd_pdev;
+        struct ioc4_control* control = idd->idd_serial_data;
+        struct ioc4_soft *soft = control->ic_soft;
+        void __iomem *ioc4_misc = idd->idd_misc_regs;
+        void __iomem *ioc4_serial = soft->is_ioc4_serial_addr;
 
         /* IOC4 firmware must be at least rev 62 */
         pci_read_config_word(pdev, PCI_COMMAND_SPECIAL, &ioc4_revid);
@@ -1076,7 +1037,7 @@ static int inline ioc4_attach_local(struct pci_dev *pdev,
                                 ioc4_revid, ioc4_revid_min);
                 return -EPERM;
         }
-        BUG_ON(ioc4_mem == NULL);
+        BUG_ON(ioc4_misc == NULL);
         BUG_ON(ioc4_serial == NULL);
 
         /* Create port structures for each port */
@@ -1100,10 +1061,18 @@ static int inline ioc4_attach_local(struct pci_dev *pdev,
                 port->ip_ioc4_soft = soft;
                 port->ip_pdev = pdev;
                 port->ip_ienb = 0;
-                port->ip_pci_bus_speed = IOC4_SER_XIN_CLK;
+                /* Use baud rate calculations based on detected PCI
+                 * bus speed.  Simply test whether the PCI clock is
+                 * running closer to 66MHz or 33MHz.
+                 */
+                if (idd->count_period/IOC4_EXTINT_COUNT_DIVISOR < 20) {
+                        port->ip_pci_bus_speed = IOC4_SER_XIN_CLK_66;
+                } else {
+                        port->ip_pci_bus_speed = IOC4_SER_XIN_CLK_33;
+                }
                 port->ip_baud = 9600;
                 port->ip_control = control;
-                port->ip_mem = ioc4_mem;
+                port->ip_mem = ioc4_misc;
                 port->ip_serial = ioc4_serial;
 
                 /* point to the right hook */
@@ -1604,14 +1573,12 @@ static int ioc4_set_proto(struct ioc4_port *port, enum sio_proto proto)
         switch (proto) {
         case PROTO_RS232:
                 /* Clear the appropriate GIO pin */
-                writel(0, (&port->ip_mem->gppr_0 +
-                                  hooks->rs422_select_pin));
+                writel(0, (&port->ip_mem->gppr[hooks->rs422_select_pin].raw));
                 break;
 
         case PROTO_RS422:
                 /* Set the appropriate GIO pin */
-                writel(1, (&port->ip_mem->gppr_0 +
-                                  hooks->rs422_select_pin));
+                writel(1, (&port->ip_mem->gppr[hooks->rs422_select_pin].raw));
                 break;
 
         default:
@@ -1885,7 +1852,7 @@ static void handle_intr(void *arg, uint32_t sio_ir)
                 if (sio_ir & hooks->intr_delta_dcd) {
                         /* ACK the interrupt */
                         writel(hooks->intr_delta_dcd,
-                                &port->ip_mem->sio_ir);
+                                &port->ip_mem->sio_ir.raw);
 
                         shadow = readl(&port->ip_serial_regs->shadow);
 
@@ -1907,7 +1874,7 @@ static void handle_intr(void *arg, uint32_t sio_ir)
                 if (sio_ir & hooks->intr_delta_cts) {
                         /* ACK the interrupt */
                         writel(hooks->intr_delta_cts,
-                                        &port->ip_mem->sio_ir);
+                                        &port->ip_mem->sio_ir.raw);
 
                         shadow = readl(&port->ip_serial_regs->shadow);
 
@@ -1928,7 +1895,7 @@ static void handle_intr(void *arg, uint32_t sio_ir)
                 if (sio_ir & hooks->intr_rx_timer) {
                         /* ACK the interrupt */
                         writel(hooks->intr_rx_timer,
-                                &port->ip_mem->sio_ir);
+                                &port->ip_mem->sio_ir.raw);
 
                         if ((port->ip_notify & N_DATA_READY)
                                         && (port->ip_port)) {
@@ -1974,7 +1941,7 @@ static void handle_intr(void *arg, uint32_t sio_ir)
 
                         /* ACK the interrupt */
                         writel(hooks->intr_tx_explicit,
-                                        &port->ip_mem->sio_ir);
+                                        &port->ip_mem->sio_ir.raw);
 
                         if (port->ip_notify & N_OUTPUT_LOWAT)
                                 ioc4_cb_output_lowat(port);
@@ -2634,7 +2601,8 @@ ioc4_serial_core_attach(struct pci_dev *pdev)
 {
         struct ioc4_port *port;
         struct uart_port *the_port;
-        struct ioc4_control *control = pci_get_drvdata(pdev);
+        struct ioc4_driver_data *idd = pci_get_drvdata(pdev);
+        struct ioc4_control *control = idd->idd_serial_data;
         int ii;
 
         DPRINT_CONFIG(("%s: attach pdev 0x%p - control 0x%p\n",
@@ -2680,55 +2648,29 @@ ioc4_serial_core_attach(struct pci_dev *pdev)
 
 /**
  * ioc4_serial_attach_one - register attach function
- *              called per card found from ioc4_serial_detect as part
- *              of module_init().
- * @pdev: handle for this card
- * @pci_id: pci id for this card
+ *              called per card found from IOC4 master module.
+ * @idd: Master module data for this IOC4
  */
 int
-ioc4_serial_attach_one(struct pci_dev *pdev, const struct pci_device_id *pci_id)
+ioc4_serial_attach_one(struct ioc4_driver_data *idd)
 {
-        struct ioc4_mem __iomem *mem;
-        unsigned long tmp_addr, tmp_addr1;
+        unsigned long tmp_addr1;
         struct ioc4_serial __iomem *serial;
         struct ioc4_soft *soft;
         struct ioc4_control *control;
-        int tmp, ret = 0;
+        int ret = 0;
 
 
-        DPRINT_CONFIG(("%s (0x%p, 0x%p)\n", __FUNCTION__, pdev, pci_id));
-
-        /* Map in the ioc4 memory */
-        tmp_addr = pci_resource_start(pdev, 0);
-        if (!tmp_addr) {
-                printk(KERN_WARNING
-                         "ioc4 (%p) : unable to get PIO mapping for "
-                                "MEM space\n", (void *)pdev);
-                return -ENODEV;
-        }
-        if (!request_region(tmp_addr, sizeof(struct ioc4_mem), "sioc4_mem")) {
-                printk(KERN_ALERT
-                        "ioc4 (%p): unable to get request region for "
-                        "MEM space\n", (void *)pdev);
-                return -ENODEV;
-        }
-        mem = ioremap(tmp_addr, sizeof(struct ioc4_mem));
-        if (!mem) {
-                printk(KERN_WARNING
-                         "ioc4 (%p) : unable to remap ioc4 memory\n",
-                                (void *)pdev);
-                ret = -ENODEV;
-                goto out1;
-        }
+        DPRINT_CONFIG(("%s (0x%p, 0x%p)\n", __FUNCTION__, idd->idd_pdev, idd->idd_pci_id));
 
         /* request serial registers */
-        tmp_addr1 = pci_resource_start(pdev, 0) + IOC4_SERIAL_OFFSET;
+        tmp_addr1 = idd->idd_bar0 + IOC4_SERIAL_OFFSET;
 
         if (!request_region(tmp_addr1, sizeof(struct ioc4_serial),
                                         "sioc4_uart")) {
                 printk(KERN_WARNING
                         "ioc4 (%p): unable to get request region for "
-                                "uart space\n", (void *)pdev);
+                                "uart space\n", (void *)idd->idd_pdev);
                 ret = -ENODEV;
                 goto out1;
         }
@@ -2736,12 +2678,12 @@ ioc4_serial_attach_one(struct pci_dev *pdev, const struct pci_device_id *pci_id)
         if (!serial) {
                 printk(KERN_WARNING
                          "ioc4 (%p) : unable to remap ioc4 serial register\n",
-                                (void *)pdev);
+                                (void *)idd->idd_pdev);
                 ret = -ENODEV;
                 goto out2;
         }
         DPRINT_CONFIG(("%s : mem 0x%p, serial 0x%p\n",
-                                __FUNCTION__, (void *)mem, (void *)serial));
+                                __FUNCTION__, (void *)idd->idd_misc_regs, (void *)serial));
 
         /* Get memory for the new card */
         control = kmalloc(sizeof(struct ioc4_control) * IOC4_NUM_SERIAL_PORTS,
@@ -2754,59 +2696,56 @@ ioc4_serial_attach_one(struct pci_dev *pdev, const struct pci_device_id *pci_id)
                 goto out2;
         }
         memset(control, 0, sizeof(struct ioc4_control));
-        pci_set_drvdata(pdev, control);
+        idd->idd_serial_data = control;
 
         /* Allocate the soft structure */
         soft = kmalloc(sizeof(struct ioc4_soft), GFP_KERNEL);
         if (!soft) {
                 printk(KERN_WARNING
                        "ioc4 (%p): unable to get memory for the soft struct\n",
-                       (void *)pdev);
+                       (void *)idd->idd_pdev);
                 ret = -ENOMEM;
                 goto out3;
         }
         memset(soft, 0, sizeof(struct ioc4_soft));
 
         spin_lock_init(&soft->is_ir_lock);
-        soft->is_ioc4_mem_addr = mem;
+        soft->is_ioc4_misc_addr = idd->idd_misc_regs;
         soft->is_ioc4_serial_addr = serial;
 
         /* Init the IOC4 */
-        pci_read_config_dword(pdev, PCI_COMMAND, &tmp);
-        pci_write_config_dword(pdev, PCI_COMMAND,
-                               tmp | PCI_COMMAND_PARITY | PCI_COMMAND_SERR);
-
-        writel(0xf << IOC4_SIO_CR_CMD_PULSE_SHIFT, &mem->sio_cr);
+        writel(0xf << IOC4_SIO_CR_CMD_PULSE_SHIFT,
+               &idd->idd_misc_regs->sio_cr.raw);
 
         /* Enable serial port mode select generic PIO pins as outputs */
         writel(IOC4_GPCR_UART0_MODESEL | IOC4_GPCR_UART1_MODESEL
                 | IOC4_GPCR_UART2_MODESEL | IOC4_GPCR_UART3_MODESEL,
-                &mem->gpcr_s);
+                &idd->idd_misc_regs->gpcr_s.raw);
 
-        /* Clear and disable all interrupts */
+        /* Clear and disable all serial interrupts */
         write_ireg(soft, ~0, IOC4_W_IEC, IOC4_SIO_INTR_TYPE);
-        writel(~0, &mem->sio_ir);
-        write_ireg(soft, ~(IOC4_OTHER_IR_ATA_INT | IOC4_OTHER_IR_ATA_MEMERR),
-                        IOC4_W_IEC, IOC4_OTHER_INTR_TYPE);
-        writel(~(IOC4_OTHER_IR_ATA_MEMERR | IOC4_OTHER_IR_ATA_MEMERR),
-                                        &mem->other_ir);
+        writel(~0, &idd->idd_misc_regs->sio_ir.raw);
+        write_ireg(soft, IOC4_OTHER_IR_SER_MEMERR, IOC4_W_IEC,
+                   IOC4_OTHER_INTR_TYPE);
+        writel(IOC4_OTHER_IR_SER_MEMERR, &idd->idd_misc_regs->other_ir.raw);
         control->ic_soft = soft;
-        if (!request_irq(pdev->irq, ioc4_intr, SA_SHIRQ,
+
+        /* Hook up interrupt handler */
+        if (!request_irq(idd->idd_pdev->irq, ioc4_intr, SA_SHIRQ,
                                 "sgi-ioc4serial", (void *)soft)) {
-                control->ic_irq = pdev->irq;
+                control->ic_irq = idd->idd_pdev->irq;
         } else {
                 printk(KERN_WARNING
                     "%s : request_irq fails for IRQ 0x%x\n ",
-                        __FUNCTION__, pdev->irq);
+                        __FUNCTION__, idd->idd_pdev->irq);
         }
-        if ((ret = ioc4_attach_local(pdev, control, soft,
-                                soft->is_ioc4_mem_addr,
-                                soft->is_ioc4_serial_addr)))
+        ret = ioc4_attach_local(idd);
+        if (ret)
                 goto out4;
 
         /* register port with the serial core */
 
-        if ((ret = ioc4_serial_core_attach(pdev)))
+        if ((ret = ioc4_serial_core_attach(idd->idd_pdev)))
                 goto out4;
 
         return ret;
@@ -2819,7 +2758,6 @@ out3:
 out2:
         release_region(tmp_addr1, sizeof(struct ioc4_serial));
 out1:
-        release_region(tmp_addr, sizeof(struct ioc4_mem));
 
         return ret;
 }
@@ -2828,11 +2766,10 @@ out1:
 /**
  * ioc4_serial_remove_one - detach function
  *
- * @pdev: handle for this card
+ * @idd: IOC4 master module data for this IOC4
  */
 
-#if 0
-void ioc4_serial_remove_one(struct pci_dev *pdev)
+int ioc4_serial_remove_one(struct ioc4_driver_data *idd)
 {
         int ii;
         struct ioc4_control *control;
@@ -2840,7 +2777,7 @@ void ioc4_serial_remove_one(struct pci_dev *pdev)
         struct ioc4_port *port;
         struct ioc4_soft *soft;
 
-        control = pci_get_drvdata(pdev);
+        control = idd->idd_serial_data;
 
         for (ii = 0; ii < IOC4_NUM_SERIAL_PORTS; ii++) {
                 the_port = &control->ic_port[ii].icp_uart_port;
@@ -2867,10 +2804,17 @@ void ioc4_serial_remove_one(struct pci_dev *pdev)
                 kfree(soft);
         }
         kfree(control);
-        pci_set_drvdata(pdev, NULL);
-        uart_unregister_driver(&ioc4_uart);
+        idd->idd_serial_data = NULL;
+
+        return 0;
 }
-#endif
+
+static struct ioc4_submodule ioc4_serial_submodule = {
+        .is_name = "IOC4_serial",
+        .is_owner = THIS_MODULE,
+        .is_probe = ioc4_serial_attach_one,
+        .is_remove = ioc4_serial_remove_one,
+};
 
 /**
  * ioc4_serial_init - module init
@@ -2886,12 +2830,20 @@ int ioc4_serial_init(void)
                         __FUNCTION__);
                 return ret;
         }
-        return 0;
+
+        /* register with IOC4 main module */
+        return ioc4_register_submodule(&ioc4_serial_submodule);
+}
+
+static void __devexit ioc4_serial_exit(void)
+{
+        ioc4_unregister_submodule(&ioc4_serial_submodule);
+        uart_unregister_driver(&ioc4_uart);
 }
 
+module_init(ioc4_serial_init);
+module_exit(ioc4_serial_exit);
+
 MODULE_AUTHOR("Pat Gefre - Silicon Graphics Inc. (SGI) <pfg@sgi.com>");
 MODULE_DESCRIPTION("Serial PCI driver module for SGI IOC4 Base-IO Card");
 MODULE_LICENSE("GPL");
-
-EXPORT_SYMBOL(ioc4_serial_init);
-EXPORT_SYMBOL(ioc4_serial_attach_one);
diff --git a/drivers/serial/m32r_sio.c b/drivers/serial/m32r_sio.c
index 08d61f13edc6..0301feacbde4 100644
--- a/drivers/serial/m32r_sio.c
+++ b/drivers/serial/m32r_sio.c
@@ -724,22 +724,22 @@ static void m32r_sio_set_termios(struct uart_port *port,
 
         switch (termios->c_cflag & CSIZE) {
         case CS5:
-                cval = 0x00;
+                cval = UART_LCR_WLEN5;
                 break;
         case CS6:
-                cval = 0x01;
+                cval = UART_LCR_WLEN6;
                 break;
         case CS7:
-                cval = 0x02;
+                cval = UART_LCR_WLEN7;
                 break;
         default:
         case CS8:
-                cval = 0x03;
+                cval = UART_LCR_WLEN8;
                 break;
         }
 
         if (termios->c_cflag & CSTOPB)
-                cval |= 0x04;
+                cval |= UART_LCR_STOP;
         if (termios->c_cflag & PARENB)
                 cval |= UART_LCR_PARITY;
         if (!(termios->c_cflag & PARODD))
diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c
index a8314aee2ab8..a2a643318002 100644
--- a/drivers/serial/mpsc.c
+++ b/drivers/serial/mpsc.c
@@ -67,7 +67,11 @@
 
 static struct mpsc_port_info mpsc_ports[MPSC_NUM_CTLRS];
 static struct mpsc_shared_regs mpsc_shared_regs;
+static struct uart_driver mpsc_reg;
 
+static void mpsc_start_rx(struct mpsc_port_info *pi);
+static void mpsc_free_ring_mem(struct mpsc_port_info *pi);
+static void mpsc_release_port(struct uart_port *port);
 /*
  ******************************************************************************
  *
@@ -546,7 +550,6 @@ static int
 mpsc_alloc_ring_mem(struct mpsc_port_info *pi)
 {
         int rc = 0;
-        static void mpsc_free_ring_mem(struct mpsc_port_info *pi);
 
         pr_debug("mpsc_alloc_ring_mem[%d]: Allocating ring mem\n",
                 pi->port.line);
@@ -745,7 +748,6 @@ mpsc_rx_intr(struct mpsc_port_info *pi, struct pt_regs *regs)
         int     rc = 0;
         u8      *bp;
         char    flag = TTY_NORMAL;
-        static void mpsc_start_rx(struct mpsc_port_info *pi);
 
         pr_debug("mpsc_rx_intr[%d]: Handling Rx intr\n", pi->port.line);
 
@@ -1178,7 +1180,6 @@ static void
 mpsc_shutdown(struct uart_port *port)
 {
         struct mpsc_port_info *pi = (struct mpsc_port_info *)port;
-        static void mpsc_release_port(struct uart_port *port);
 
         pr_debug("mpsc_shutdown[%d]: Shutting down MPSC\n", port->line);
 
@@ -1448,7 +1449,6 @@ mpsc_console_setup(struct console *co, char *options)
         return uart_set_options(&pi->port, co, baud, parity, bits, flow);
 }
 
-extern struct uart_driver mpsc_reg;
 static struct console mpsc_console = {
         .name   = MPSC_DEV_NAME,
         .write  = mpsc_console_write,
diff --git a/drivers/serial/pxa.c b/drivers/serial/pxa.c
index 9dc151d8fa61..08b08d6ae904 100644
--- a/drivers/serial/pxa.c
+++ b/drivers/serial/pxa.c
@@ -455,22 +455,22 @@ serial_pxa_set_termios(struct uart_port *port, struct termios *termios,
 
         switch (termios->c_cflag & CSIZE) {
         case CS5:
-                cval = 0x00;
+                cval = UART_LCR_WLEN5;
                 break;
         case CS6:
-                cval = 0x01;
+                cval = UART_LCR_WLEN6;
                 break;
         case CS7:
-                cval = 0x02;
+                cval = UART_LCR_WLEN7;
                 break;
         default:
         case CS8:
-                cval = 0x03;
+                cval = UART_LCR_WLEN8;
                 break;
         }
 
         if (termios->c_cflag & CSTOPB)
-                cval |= 0x04;
+                cval |= UART_LCR_STOP;
         if (termios->c_cflag & PARENB)
                 cval |= UART_LCR_PARITY;
         if (!(termios->c_cflag & PARODD))
diff --git a/drivers/serial/s3c2410.c b/drivers/serial/s3c2410.c
index 2a9f7ade2c9d..5c4678478b1d 100644
--- a/drivers/serial/s3c2410.c
+++ b/drivers/serial/s3c2410.c
@@ -198,7 +198,7 @@ static inline struct s3c24xx_uart_port *to_ourport(struct uart_port *port)
 
 /* translate a port to the device name */
 
-static inline char *s3c24xx_serial_portname(struct uart_port *port)
+static inline const char *s3c24xx_serial_portname(struct uart_port *port)
 {
         return to_platform_device(port->dev)->name;
 }
@@ -903,7 +903,7 @@ static void s3c24xx_serial_release_port(struct uart_port *port)
 
 static int s3c24xx_serial_request_port(struct uart_port *port)
 {
-        char *name = s3c24xx_serial_portname(port);
+        const char *name = s3c24xx_serial_portname(port);
         return request_mem_region(port->mapbase, MAP_SIZE, name) ? 0 : -EBUSY;
 }
 
diff --git a/drivers/serial/sa1100.c b/drivers/serial/sa1100.c
index 22565a67a57c..98641c3f5ab9 100644
--- a/drivers/serial/sa1100.c
+++ b/drivers/serial/sa1100.c
@@ -197,7 +197,7 @@ static void
 sa1100_rx_chars(struct sa1100_port *sport, struct pt_regs *regs)
 {
         struct tty_struct *tty = sport->port.info->tty;
-        unsigned int status, ch, flg, ignored = 0;
+        unsigned int status, ch, flg;
 
         status = UTSR1_TO_SM(UART_GET_UTSR1(sport)) |
                  UTSR0_TO_SM(UART_GET_UTSR0(sport));
diff --git a/drivers/serial/sn_console.c b/drivers/serial/sn_console.c
index fee6418e84c4..840815fde49b 100644
--- a/drivers/serial/sn_console.c
+++ b/drivers/serial/sn_console.c
@@ -572,6 +572,7 @@ static void sn_transmit_chars(struct sn_cons_port *port, int raw)
 
         if (uart_circ_empty(xmit) || uart_tx_stopped(&port->sc_port)) {
                 /* Nothing to do. */
+                ia64_sn_console_intr_disable(SAL_CONSOLE_INTR_XMIT);
                 return;
         }
 
diff --git a/drivers/serial/sunzilog.c b/drivers/serial/sunzilog.c
index 5c4231ae295b..8e65206d3d76 100644
--- a/drivers/serial/sunzilog.c
+++ b/drivers/serial/sunzilog.c
@@ -1071,7 +1071,7 @@ static void __init sunzilog_alloc_tables(void)
  */
 static struct zilog_layout __iomem * __init get_zs_sun4u(int chip, int zsnode)
 {
-        unsigned long mapped_addr;
+        void __iomem *mapped_addr;
         unsigned int sun4u_ino;
         struct sbus_bus *sbus = NULL;
         struct sbus_dev *sdev = NULL;
@@ -1111,9 +1111,9 @@ static struct zilog_layout __iomem * __init get_zs_sun4u(int chip, int zsnode)
                 apply_fhc_ranges(central_bus->child,
                                  &zsregs[0], 1);
                 apply_central_ranges(central_bus, &zsregs[0], 1);
-                mapped_addr =
-                        (((u64)zsregs[0].which_io)<<32UL) |
-                        ((u64)zsregs[0].phys_addr);
+                mapped_addr = (void __iomem *)
+                        ((((u64)zsregs[0].which_io)<<32UL) |
+                        ((u64)zsregs[0].phys_addr));
         }
 
         if (zilog_irq == -1) {
diff --git a/drivers/serial/vr41xx_siu.c b/drivers/serial/vr41xx_siu.c
index 5d2ceb623e6f..1f985327b0d4 100644
--- a/drivers/serial/vr41xx_siu.c
+++ b/drivers/serial/vr41xx_siu.c
@@ -234,7 +234,7 @@ static inline const char *siu_type_name(struct uart_port *port)
                 return "DSIU";
         }
 
-        return "unknown";
+        return NULL;
 }
 
 static unsigned int siu_tx_empty(struct uart_port *port)
@@ -482,9 +482,6 @@ static irqreturn_t siu_interrupt(int irq, void *dev_id, struct pt_regs *regs)
         struct uart_port *port;
         uint8_t iir, lsr;
 
-        if (dev_id == NULL)
-                return IRQ_NONE;
-
         port = (struct uart_port *)dev_id;
 
         iir = siu_read(port, UART_IIR);
@@ -507,6 +504,9 @@ static int siu_startup(struct uart_port *port)
 {
         int retval;
 
+        if (port->membase == NULL)
+                return -ENODEV;
+
         siu_clear_fifo(port);
 
         (void)siu_read(port, UART_LSR);
@@ -545,9 +545,6 @@ static void siu_shutdown(struct uart_port *port)
         unsigned long flags;
         uint8_t lcr;
 
-        if (port->membase == NULL)
-                return;
-
         siu_write(port, UART_IER, 0);
 
         spin_lock_irqsave(&port->lock, flags);
@@ -802,53 +799,6 @@ static int siu_init_ports(void)
 
 #ifdef CONFIG_SERIAL_VR41XX_CONSOLE
 
-static void early_set_termios(struct uart_port *port, struct termios *new,
-                              struct termios *old)
-{
-        tcflag_t c_cflag;
-        uint8_t lcr;
-        unsigned int baud, quot;
-
-        c_cflag = new->c_cflag;
-        switch (c_cflag & CSIZE) {
-        case CS5:
-                lcr = UART_LCR_WLEN5;
-                break;
-        case CS6:
-                lcr = UART_LCR_WLEN6;
-                break;
-        case CS7:
-                lcr = UART_LCR_WLEN7;
-                break;
-        default:
-                lcr = UART_LCR_WLEN8;
-                break;
-        }
-
-        if (c_cflag & CSTOPB)
-                lcr |= UART_LCR_STOP;
-        if (c_cflag & PARENB)
-                lcr |= UART_LCR_PARITY;
-        if ((c_cflag & PARODD) != PARODD)
-                lcr |= UART_LCR_EPAR;
-        if (c_cflag & CMSPAR)
-                lcr |= UART_LCR_SPAR;
-
-        baud = uart_get_baud_rate(port, new, old, 0, port->uartclk/16);
-        quot = uart_get_divisor(port, baud);
-
-        siu_write(port, UART_LCR, lcr | UART_LCR_DLAB);
-
-        siu_write(port, UART_DLL, (uint8_t)quot);
-        siu_write(port, UART_DLM, (uint8_t)(quot >> 8));
-
-        siu_write(port, UART_LCR, lcr);
-}
-
-static struct uart_ops early_uart_ops = {
-        .set_termios    = early_set_termios,
-};
-
 #define BOTH_EMPTY      (UART_LSR_TEMT | UART_LSR_THRE)
 
 static void wait_for_xmitr(struct uart_port *port)
@@ -915,7 +865,7 @@ static int siu_console_setup(struct console *con, char *options)
         if (port->membase == NULL) {
                 if (port->mapbase == 0)
                         return -ENODEV;
-                port->membase = (unsigned char __iomem *)KSEG1ADDR(port->mapbase);
+                port->membase = ioremap(port->mapbase, siu_port_size(port));
         }
 
         vr41xx_select_siu_interface(SIU_INTERFACE_RS232C);
@@ -949,7 +899,7 @@ static int __devinit siu_console_init(void)
 
         for (i = 0; i < num; i++) {
                 port = &siu_uart_ports[i];
-                port->ops = &early_uart_ops;
+                port->ops = &siu_uart_ops;
         }
 
         register_console(&siu_console);
@@ -994,8 +944,10 @@ static int siu_probe(struct device *dev)
                 port->dev = dev;
 
                 retval = uart_add_one_port(&siu_uart_driver, port);
-                if (retval)
+                if (retval < 0) {
+                        port->dev = NULL;
                         break;
+                }
         }
 
         if (i == 0 && retval < 0) {