diff options
author | Alan Cox <alan@redhat.com> | 2009-01-11 14:48:34 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-12 19:37:00 -0500 |
commit | 21b56ec4e96f2bd8c584db41bd9a42c6cb71fdac (patch) | |
tree | 9f3c5434966bb4d4817215bc8a3617362812648f /drivers/serial | |
parent | c774bda2fdc5412124a854a791d9f6f52936ff81 (diff) |
neo: Remove a bogus NULL check
Julia Lawall found an un-needed check in the neo driver. Her patch moves
the check to cover the code dereferencing it, however it cannot be NULL
anyway so remove the NULL check instead.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/serial')
-rw-r--r-- | drivers/serial/jsm/jsm_neo.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/serial/jsm/jsm_neo.c b/drivers/serial/jsm/jsm_neo.c index b7584ca55ade..e6390d023634 100644 --- a/drivers/serial/jsm/jsm_neo.c +++ b/drivers/serial/jsm/jsm_neo.c | |||
@@ -577,9 +577,6 @@ static void neo_parse_modem(struct jsm_channel *ch, u8 signals) | |||
577 | jsm_printk(MSIGS, INFO, &ch->ch_bd->pci_dev, | 577 | jsm_printk(MSIGS, INFO, &ch->ch_bd->pci_dev, |
578 | "neo_parse_modem: port: %d msignals: %x\n", ch->ch_portnum, msignals); | 578 | "neo_parse_modem: port: %d msignals: %x\n", ch->ch_portnum, msignals); |
579 | 579 | ||
580 | if (!ch) | ||
581 | return; | ||
582 | |||
583 | /* Scrub off lower bits. They signify delta's, which I don't care about */ | 580 | /* Scrub off lower bits. They signify delta's, which I don't care about */ |
584 | /* Keep DDCD and DDSR though */ | 581 | /* Keep DDCD and DDSR though */ |
585 | msignals &= 0xf8; | 582 | msignals &= 0xf8; |