diff options
author | Roel Kluin <12o3l@tiscali.nl> | 2008-04-23 17:59:36 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-04-28 16:24:45 -0400 |
commit | 681587c58639444215a7c88f7471819997d2f226 (patch) | |
tree | dc56d626f84e58df57526c26957b72dd1da12498 /drivers/serial | |
parent | 62783679540fbdfd74e10fbe9478d978141ba45f (diff) |
[ARM] serial: s3c2410: platform_get_irq() may return signed unnoticed
port->irq is unsigned, platform_get_irq() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'drivers/serial')
-rw-r--r-- | drivers/serial/s3c2410.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/serial/s3c2410.c b/drivers/serial/s3c2410.c index 4ffa2585429a..da5a02cb4f63 100644 --- a/drivers/serial/s3c2410.c +++ b/drivers/serial/s3c2410.c | |||
@@ -1022,6 +1022,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, | |||
1022 | struct uart_port *port = &ourport->port; | 1022 | struct uart_port *port = &ourport->port; |
1023 | struct s3c2410_uartcfg *cfg; | 1023 | struct s3c2410_uartcfg *cfg; |
1024 | struct resource *res; | 1024 | struct resource *res; |
1025 | int ret; | ||
1025 | 1026 | ||
1026 | dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev); | 1027 | dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev); |
1027 | 1028 | ||
@@ -1064,9 +1065,11 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, | |||
1064 | 1065 | ||
1065 | port->mapbase = res->start; | 1066 | port->mapbase = res->start; |
1066 | port->membase = S3C24XX_VA_UART + (res->start - S3C24XX_PA_UART); | 1067 | port->membase = S3C24XX_VA_UART + (res->start - S3C24XX_PA_UART); |
1067 | port->irq = platform_get_irq(platdev, 0); | 1068 | ret = platform_get_irq(platdev, 0); |
1068 | if (port->irq < 0) | 1069 | if (ret < 0) |
1069 | port->irq = 0; | 1070 | port->irq = 0; |
1071 | else | ||
1072 | port->irq = ret; | ||
1070 | 1073 | ||
1071 | ourport->clk = clk_get(&platdev->dev, "uart"); | 1074 | ourport->clk = clk_get(&platdev->dev, "uart"); |
1072 | 1075 | ||