[SERIAL] kernel console should send CRLF not LFCR

Glen Turner reported that writing LFCR rather than the more
traditional CRLF causes issues with some terminals.

Since this aflicts many serial drivers, extract the common code
to a library function (uart_console_write) and arrange for each
driver to supply a "putchar" function.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

1 files changed, 7 insertions, 10 deletions

diff --git a/drivers/serial/serial_lh7a40x.c b/drivers/serial/serial_lh7a40x.c
index 04186eaae227..aa521b8e0d4e 100644
--- a/drivers/serial/serial_lh7a40x.c
+++ b/drivers/serial/serial_lh7a40x.c
@@ -543,6 +543,12 @@ static struct uart_port_lh7a40x lh7a40x_ports[DEV_NR] = {
 #else
 # define LH7A40X_CONSOLE &lh7a40x_console
 
+static void lh7a40xuart_console_putchar(struct uart_port *port, int ch)
+{
+        while (UR(port, UART_R_STATUS) & nTxRdy)
+                ;
+        UR(port, UART_R_DATA) = ch;
+}
 
 static void lh7a40xuart_console_write (struct console* co,
                                        const char* s,
@@ -556,16 +562,7 @@ static void lh7a40xuart_console_write (struct console* co,
         UR (port, UART_R_INTEN) = 0;            /* Disable all interrupts */
         BIT_SET (port, UART_R_CON, UARTEN | SIRDIS); /* Enable UART */
 
-        for (; count-- > 0; ++s) {
-                while (UR (port, UART_R_STATUS) & nTxRdy)
-                        ;
-                UR (port, UART_R_DATA) = *s;
-                if (*s == '\n') {
-                        while ((UR (port, UART_R_STATUS) & TxBusy))
-                                ;
-                        UR (port, UART_R_DATA) = '\r';
-                }
-        }
+        uart_console_write(port, s, count, lh7a40xuart_console_putchar);
 
                                 /* Wait until all characters are sent */
         while (UR (port, UART_R_STATUS) & TxBusy)