diff options
| author | Dominik Brodowski <linux@dominikbrodowski.net> | 2010-07-29 10:19:39 -0400 |
|---|---|---|
| committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2010-09-29 11:20:22 -0400 |
| commit | fc301101034c06bf56a7f71bf682c48909e401a4 (patch) | |
| tree | f1faa456d436515d73679bb12587967efba05e7c /drivers/serial/serial_cs.c | |
| parent | 1a4a046030ade0f57b8f3b476d61c7c35d894b66 (diff) | |
pcmcia: simplify Status, ExtStatus register access
The Status (CISREG_CCSR) and ExtStatus (CISREG_ESR) registers were
only accessed to enable audio output for some drivers and IRQ for
serial_cs.c. The former also required setting config_req_t.Attributes
to CONF_ENABLE_SPKR; the latter can be simplified to setting this
field to CONF_ENABLE_ESR.
CC: netdev@vger.kernel.org
CC: linux-wireless@vger.kernel.org
CC: linux-serial@vger.kernel.org
CC: linux-scsi@vger.kernel.org
Tested-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/serial/serial_cs.c')
| -rw-r--r-- | drivers/serial/serial_cs.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/serial/serial_cs.c b/drivers/serial/serial_cs.c index 9597442a0ac1..0460c0882b70 100644 --- a/drivers/serial/serial_cs.c +++ b/drivers/serial/serial_cs.c | |||
| @@ -183,10 +183,8 @@ static void quirk_config_socket(struct pcmcia_device *link) | |||
| 183 | { | 183 | { |
| 184 | struct serial_info *info = link->priv; | 184 | struct serial_info *info = link->priv; |
| 185 | 185 | ||
| 186 | if (info->multi) { | 186 | if (info->multi) |
| 187 | link->conf.Present |= PRESENT_EXT_STATUS; | 187 | link->conf.Attributes |= CONF_ENABLE_ESR; |
| 188 | link->conf.ExtStatus = ESR_REQ_ATTN_ENA; | ||
| 189 | } | ||
| 190 | } | 188 | } |
| 191 | 189 | ||
| 192 | static const struct serial_quirk quirks[] = { | 190 | static const struct serial_quirk quirks[] = { |
| @@ -336,10 +334,9 @@ static int serial_probe(struct pcmcia_device *link) | |||
| 336 | link->priv = info; | 334 | link->priv = info; |
| 337 | 335 | ||
| 338 | link->conf.Attributes = CONF_ENABLE_IRQ; | 336 | link->conf.Attributes = CONF_ENABLE_IRQ; |
| 339 | if (do_sound) { | 337 | if (do_sound) |
| 340 | link->conf.Attributes |= CONF_ENABLE_SPKR; | 338 | link->conf.Attributes |= CONF_ENABLE_SPKR; |
| 341 | link->conf.Status = CCSR_AUDIO_ENA; | 339 | |
| 342 | } | ||
| 343 | link->conf.IntType = INT_MEMORY_AND_IO; | 340 | link->conf.IntType = INT_MEMORY_AND_IO; |
| 344 | 341 | ||
| 345 | return serial_config(link); | 342 | return serial_config(link); |
