[SERIAL] kernel console should send CRLF not LFCR

Glen Turner reported that writing LFCR rather than the more
traditional CRLF causes issues with some terminals.

Since this aflicts many serial drivers, extract the common code
to a library function (uart_console_write) and arrange for each
driver to supply a "putchar" function.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

1 files changed, 10 insertions, 16 deletions

diff --git a/drivers/serial/sa1100.c b/drivers/serial/sa1100.c
index 2c00b8625852..c2d9068b491d 100644
--- a/drivers/serial/sa1100.c
+++ b/drivers/serial/sa1100.c
@@ -689,6 +689,14 @@ void __init sa1100_register_uart(int idx, int port)
 
 
 #ifdef CONFIG_SERIAL_SA1100_CONSOLE
+static void sa1100_console_putchar(struct uart_port *port, int ch)
+{
+        struct sa1100_port *sport = (struct sa1100_port *)port;
+
+        while (!(UART_GET_UTSR1(sport) & UTSR1_TNF))
+                barrier();
+        UART_PUT_CHAR(sport, ch);
+}
 
 /*
  * Interrupts are disabled on entering
@@ -697,7 +705,7 @@ static void
 sa1100_console_write(struct console *co, const char *s, unsigned int count)
 {
         struct sa1100_port *sport = &sa1100_ports[co->index];
-        unsigned int old_utcr3, status, i;
+        unsigned int old_utcr3, status;
 
         /*
          *      First, save UTCR3 and then disable interrupts
@@ -706,21 +714,7 @@ sa1100_console_write(struct console *co, const char *s, unsigned int count)
         UART_PUT_UTCR3(sport, (old_utcr3 & ~(UTCR3_RIE | UTCR3_TIE)) |
                                 UTCR3_TXE);
 
-        /*
-         *      Now, do each character
-         */
-        for (i = 0; i < count; i++) {
-                do {
-                        status = UART_GET_UTSR1(sport);
-                } while (!(status & UTSR1_TNF));
-                UART_PUT_CHAR(sport, s[i]);
-                if (s[i] == '\n') {
-                        do {
-                                status = UART_GET_UTSR1(sport);
-                        } while (!(status & UTSR1_TNF));
-                        UART_PUT_CHAR(sport, '\r');
-                }
-        }
+        uart_console_write(&sport->port, s, count, sa1100_console_putchar);
 
         /*
          *      Finally, wait for transmitter to become empty