[SERIAL] kernel console should send CRLF not LFCR

Glen Turner reported that writing LFCR rather than the more
traditional CRLF causes issues with some terminals.

Since this aflicts many serial drivers, extract the common code
to a library function (uart_console_write) and arrange for each
driver to supply a "putchar" function.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

1 files changed, 5 insertions, 6 deletions

diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index 61dd17d7bace..928e6cf12dca 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -603,15 +603,14 @@ mpc52xx_console_write(struct console *co, const char *s, unsigned int count)
                 udelay(1);
 
         /* Write all the chars */
-        for ( i=0 ; i<count ; i++ ) {
-        
-                /* Send the char */
-                out_8(&psc->mpc52xx_psc_buffer_8, *s);
-
+        for (i = 0; i < count; i++, s++) {
                 /* Line return handling */
-                if ( *s++ == '\n' )
+                if (*s == '\n')
                         out_8(&psc->mpc52xx_psc_buffer_8, '\r');
                 
+                /* Send the char */
+                out_8(&psc->mpc52xx_psc_buffer_8, *s);
+
                 /* Wait the TX buffer to be empty */
                 j = 20000;      /* Maximum wait */      
                 while (!(in_be16(&psc->mpc52xx_psc_status) &