diff options
author | Scott Wood <scottwood@freescale.com> | 2009-04-03 16:48:44 -0400 |
---|---|---|
committer | Kumar Gala <galak@kernel.crashing.org> | 2009-04-06 10:09:28 -0400 |
commit | bd86ef378412fc30282daf722a833f734e4e2236 (patch) | |
tree | a93bd59ef3857747d94808b58f508b8d94c77f2f /drivers/serial/cpm_uart | |
parent | d91e4ea7047d96733d763f1626f1f21ff4298cef (diff) |
cpm_uart: Initialize port.dev before it's used.
Previously, this caused NULL to sometimes be passed as a device
to the DMA code. With recent DMA changes, that now causes a BUG().
Signed-off-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Diffstat (limited to 'drivers/serial/cpm_uart')
-rw-r--r-- | drivers/serial/cpm_uart/cpm_uart_core.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/serial/cpm_uart/cpm_uart_core.c b/drivers/serial/cpm_uart/cpm_uart_core.c index 5c6ef51da274..4dd00bea191a 100644 --- a/drivers/serial/cpm_uart/cpm_uart_core.c +++ b/drivers/serial/cpm_uart/cpm_uart_core.c | |||
@@ -1339,13 +1339,13 @@ static int __devinit cpm_uart_probe(struct of_device *ofdev, | |||
1339 | 1339 | ||
1340 | dev_set_drvdata(&ofdev->dev, pinfo); | 1340 | dev_set_drvdata(&ofdev->dev, pinfo); |
1341 | 1341 | ||
1342 | /* initialize the device pointer for the port */ | ||
1343 | pinfo->port.dev = &ofdev->dev; | ||
1344 | |||
1342 | ret = cpm_uart_init_port(ofdev->node, pinfo); | 1345 | ret = cpm_uart_init_port(ofdev->node, pinfo); |
1343 | if (ret) | 1346 | if (ret) |
1344 | return ret; | 1347 | return ret; |
1345 | 1348 | ||
1346 | /* initialize the device pointer for the port */ | ||
1347 | pinfo->port.dev = &ofdev->dev; | ||
1348 | |||
1349 | return uart_add_one_port(&cpm_reg, &pinfo->port); | 1349 | return uart_add_one_port(&cpm_reg, &pinfo->port); |
1350 | } | 1350 | } |
1351 | 1351 | ||