aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorRobert Love <robert.w.love@intel.com>2013-06-11 03:28:19 -0400
committerRobert Love <robert.w.love@intel.com>2013-07-09 14:18:47 -0400
commita2ceb1fbaa875172345f611a3d37c3662f7e5082 (patch)
tree0f9a67e501749d07729a8319edf6c7d5b841738e /drivers/scsi
parent3a2926054acf876313afaaddac00a8ad255f6d68 (diff)
libfcoe: Fix meaningless log statement
ctlr_dev was initialized to NULL, and never re-assigned. This caused the log statement to always report failure. This patch removes the unused variable and fixes the log statement to always report 'success', as that is what should be logged if the code reaches this point. Signed-off-by: Robert Love <robert.w.love@intel.com> Tested-by: Jack Morgan <jack.morgan@intel.com> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/fcoe/fcoe_transport.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
index bedd42211727..f1ae5edb2de1 100644
--- a/drivers/scsi/fcoe/fcoe_transport.c
+++ b/drivers/scsi/fcoe/fcoe_transport.c
@@ -707,7 +707,6 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus,
707{ 707{
708 struct net_device *netdev = NULL; 708 struct net_device *netdev = NULL;
709 struct fcoe_transport *ft = NULL; 709 struct fcoe_transport *ft = NULL;
710 struct fcoe_ctlr_device *ctlr_dev = NULL;
711 int rc = 0; 710 int rc = 0;
712 int err; 711 int err;
713 712
@@ -754,9 +753,8 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus,
754 goto out_putdev; 753 goto out_putdev;
755 } 754 }
756 755
757 LIBFCOE_TRANSPORT_DBG("transport %s %s to create fcoe on %s.\n", 756 LIBFCOE_TRANSPORT_DBG("transport %s succeeded to create fcoe on %s.\n",
758 ft->name, (ctlr_dev) ? "succeeded" : "failed", 757 ft->name, netdev->name);
759 netdev->name);
760 758
761out_putdev: 759out_putdev:
762 dev_put(netdev); 760 dev_put(netdev);