diff options
author | Giridhar Malavali <giridhar.malavali@qlogic.com> | 2010-12-21 19:00:20 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-12-23 17:02:22 -0500 |
commit | 10fbb7dd36eb3014fe4b928e596d89e036ee6210 (patch) | |
tree | 7ade50fca1df41c3f1b3bad90a507abbedbb4f24 /drivers/scsi | |
parent | c9e8fd5cfb7de50139a8aa0f70f9fe03311cdd01 (diff) |
[SCSI] qla2xxx: Code cleanup to remove unwanted comments and code.
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Lalit Chandivade <lalit.chandivade@qlogic.com>
Signed-off-by: Madhuranath Iyengar <Madhu.Iyengar@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/qla2xxx/qla_nx.c | 36 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_nx.h | 2 |
2 files changed, 0 insertions, 38 deletions
diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index 6ea5e98b850b..22b0d781c75a 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c | |||
@@ -1254,25 +1254,6 @@ qla82xx_pinit_from_rom(scsi_qla_host_t *vha) | |||
1254 | } | 1254 | } |
1255 | 1255 | ||
1256 | static int | 1256 | static int |
1257 | qla82xx_check_for_bad_spd(struct qla_hw_data *ha) | ||
1258 | { | ||
1259 | u32 val = 0; | ||
1260 | val = qla82xx_rd_32(ha, BOOT_LOADER_DIMM_STATUS); | ||
1261 | val &= QLA82XX_BOOT_LOADER_MN_ISSUE; | ||
1262 | if (val & QLA82XX_PEG_TUNE_MN_SPD_ZEROED) { | ||
1263 | qla_printk(KERN_INFO, ha, | ||
1264 | "Memory DIMM SPD not programmed. " | ||
1265 | " Assumed valid.\n"); | ||
1266 | return 1; | ||
1267 | } else if (val) { | ||
1268 | qla_printk(KERN_INFO, ha, | ||
1269 | "Memory DIMM type incorrect.Info:%08X.\n", val); | ||
1270 | return 2; | ||
1271 | } | ||
1272 | return 0; | ||
1273 | } | ||
1274 | |||
1275 | static int | ||
1276 | qla82xx_pci_mem_write_2M(struct qla_hw_data *ha, | 1257 | qla82xx_pci_mem_write_2M(struct qla_hw_data *ha, |
1277 | u64 off, void *data, int size) | 1258 | u64 off, void *data, int size) |
1278 | { | 1259 | { |
@@ -1337,11 +1318,6 @@ qla82xx_pci_mem_write_2M(struct qla_hw_data *ha, | |||
1337 | word[startword+1] |= tmpw >> (sz[0] * 8); | 1318 | word[startword+1] |= tmpw >> (sz[0] * 8); |
1338 | } | 1319 | } |
1339 | 1320 | ||
1340 | /* | ||
1341 | * don't lock here - write_wx gets the lock if each time | ||
1342 | * write_lock_irqsave(&adapter->adapter_lock, flags); | ||
1343 | * netxen_nic_pci_change_crbwindow_128M(adapter, 0); | ||
1344 | */ | ||
1345 | for (i = 0; i < loop; i++) { | 1321 | for (i = 0; i < loop; i++) { |
1346 | temp = off8 + (i << shift_amount); | 1322 | temp = off8 + (i << shift_amount); |
1347 | qla82xx_wr_32(ha, mem_crb+MIU_TEST_AGT_ADDR_LO, temp); | 1323 | qla82xx_wr_32(ha, mem_crb+MIU_TEST_AGT_ADDR_LO, temp); |
@@ -1443,12 +1419,6 @@ qla82xx_pci_mem_read_2M(struct qla_hw_data *ha, | |||
1443 | off0[1] = 0; | 1419 | off0[1] = 0; |
1444 | sz[1] = size - sz[0]; | 1420 | sz[1] = size - sz[0]; |
1445 | 1421 | ||
1446 | /* | ||
1447 | * don't lock here - write_wx gets the lock if each time | ||
1448 | * write_lock_irqsave(&adapter->adapter_lock, flags); | ||
1449 | * netxen_nic_pci_change_crbwindow_128M(adapter, 0); | ||
1450 | */ | ||
1451 | |||
1452 | for (i = 0; i < loop; i++) { | 1422 | for (i = 0; i < loop; i++) { |
1453 | temp = off8 + (i << shift_amount); | 1423 | temp = off8 + (i << shift_amount); |
1454 | qla82xx_wr_32(ha, mem_crb + MIU_TEST_AGT_ADDR_LO, temp); | 1424 | qla82xx_wr_32(ha, mem_crb + MIU_TEST_AGT_ADDR_LO, temp); |
@@ -1481,11 +1451,6 @@ qla82xx_pci_mem_read_2M(struct qla_hw_data *ha, | |||
1481 | } | 1451 | } |
1482 | } | 1452 | } |
1483 | 1453 | ||
1484 | /* | ||
1485 | * netxen_nic_pci_change_crbwindow_128M(adapter, 1); | ||
1486 | * write_unlock_irqrestore(&adapter->adapter_lock, flags); | ||
1487 | */ | ||
1488 | |||
1489 | if (j >= MAX_CTL_CHECK) | 1454 | if (j >= MAX_CTL_CHECK) |
1490 | return -1; | 1455 | return -1; |
1491 | 1456 | ||
@@ -1916,7 +1881,6 @@ qla82xx_check_cmdpeg_state(struct qla_hw_data *ha) | |||
1916 | qla_printk(KERN_INFO, ha, | 1881 | qla_printk(KERN_INFO, ha, |
1917 | "Cmd Peg initialization failed: 0x%x.\n", val); | 1882 | "Cmd Peg initialization failed: 0x%x.\n", val); |
1918 | 1883 | ||
1919 | qla82xx_check_for_bad_spd(ha); | ||
1920 | val = qla82xx_rd_32(ha, QLA82XX_ROMUSB_GLB_PEGTUNE_DONE); | 1884 | val = qla82xx_rd_32(ha, QLA82XX_ROMUSB_GLB_PEGTUNE_DONE); |
1921 | read_lock(&ha->hw_lock); | 1885 | read_lock(&ha->hw_lock); |
1922 | qla82xx_wr_32(ha, CRB_CMDPEG_STATE, PHAN_INITIALIZE_FAILED); | 1886 | qla82xx_wr_32(ha, CRB_CMDPEG_STATE, PHAN_INITIALIZE_FAILED); |
diff --git a/drivers/scsi/qla2xxx/qla_nx.h b/drivers/scsi/qla2xxx/qla_nx.h index 51ec0c5380e8..ed5883f1778a 100644 --- a/drivers/scsi/qla2xxx/qla_nx.h +++ b/drivers/scsi/qla2xxx/qla_nx.h | |||
@@ -523,8 +523,6 @@ | |||
523 | # define QLA82XX_CAM_RAM_BASE (QLA82XX_CRB_CAM + 0x02000) | 523 | # define QLA82XX_CAM_RAM_BASE (QLA82XX_CRB_CAM + 0x02000) |
524 | # define QLA82XX_CAM_RAM(reg) (QLA82XX_CAM_RAM_BASE + (reg)) | 524 | # define QLA82XX_CAM_RAM(reg) (QLA82XX_CAM_RAM_BASE + (reg)) |
525 | 525 | ||
526 | #define QLA82XX_PEG_TUNE_MN_SPD_ZEROED 0x80000000 | ||
527 | #define QLA82XX_BOOT_LOADER_MN_ISSUE 0xff00ffff | ||
528 | #define QLA82XX_PORT_MODE_ADDR (QLA82XX_CAM_RAM(0x24)) | 526 | #define QLA82XX_PORT_MODE_ADDR (QLA82XX_CAM_RAM(0x24)) |
529 | #define QLA82XX_PEG_HALT_STATUS1 (QLA82XX_CAM_RAM(0xa8)) | 527 | #define QLA82XX_PEG_HALT_STATUS1 (QLA82XX_CAM_RAM(0xa8)) |
530 | #define QLA82XX_PEG_HALT_STATUS2 (QLA82XX_CAM_RAM(0xac)) | 528 | #define QLA82XX_PEG_HALT_STATUS2 (QLA82XX_CAM_RAM(0xac)) |