aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorMike Christie <michaelc@cs.wisc.edu>2006-06-28 13:00:31 -0400
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>2006-06-29 11:09:06 -0400
commit6a8a0d3621745279a131d95f0204dc9ddac60d55 (patch)
treee3e856d0a8b3f0697a1e59492dd840dbd3babb8a /drivers/scsi
parent8434aa8b6fe5af27a33b8aa830c24e3680356c83 (diff)
[SCSI] iscsi: pass target nr to session creation
So the drivers do not use the channel numbers, but some do use the target numbers. We were just adding some goofy variable that just increases for the target nr. This is useless for software iscsi because it is always zero. And for qla4xxx the target nr is actually the index of the target/session in its FW or FLASH tables. We needed to expose this to userspace so apps could access those numbers so this patch just adds the target nr to the iscsi session creation functions. This way when qla4xxx's Hw thinks a session is at target nr 4 in its hw, it is exposed as that number in sysfs. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/libiscsi.c2
-rw-r--r--drivers/scsi/scsi_transport_iscsi.c14
2 files changed, 8 insertions, 8 deletions
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 499e79f0cac5..7e6e031cc41b 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1290,7 +1290,7 @@ iscsi_session_setup(struct iscsi_transport *iscsit,
1290 if (!try_module_get(iscsit->owner)) 1290 if (!try_module_get(iscsit->owner))
1291 goto cls_session_fail; 1291 goto cls_session_fail;
1292 1292
1293 cls_session = iscsi_create_session(shost, iscsit); 1293 cls_session = iscsi_create_session(shost, iscsit, 0);
1294 if (!cls_session) 1294 if (!cls_session)
1295 goto module_put; 1295 goto module_put;
1296 *(unsigned long*)shost->hostdata = (unsigned long)cls_session; 1296 *(unsigned long*)shost->hostdata = (unsigned long)cls_session;
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index f39da0cf5f18..7963c0538de5 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -304,6 +304,8 @@ iscsi_alloc_session(struct Scsi_Host *shost,
304 INIT_LIST_HEAD(&session->host_list); 304 INIT_LIST_HEAD(&session->host_list);
305 INIT_LIST_HEAD(&session->sess_list); 305 INIT_LIST_HEAD(&session->sess_list);
306 306
307 /* this is released in the dev's release function */
308 scsi_host_get(shost);
307 session->dev.parent = &shost->shost_gendev; 309 session->dev.parent = &shost->shost_gendev;
308 session->dev.release = iscsi_session_release; 310 session->dev.release = iscsi_session_release;
309 device_initialize(&session->dev); 311 device_initialize(&session->dev);
@@ -313,18 +315,15 @@ iscsi_alloc_session(struct Scsi_Host *shost,
313} 315}
314EXPORT_SYMBOL_GPL(iscsi_alloc_session); 316EXPORT_SYMBOL_GPL(iscsi_alloc_session);
315 317
316int iscsi_add_session(struct iscsi_cls_session *session) 318int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
317{ 319{
318 struct Scsi_Host *shost = iscsi_session_to_shost(session); 320 struct Scsi_Host *shost = iscsi_session_to_shost(session);
319 struct iscsi_host *ihost; 321 struct iscsi_host *ihost;
320 int err; 322 int err;
321 323
322 /* this is released in the dev's release function */
323 scsi_host_get(shost);
324 ihost = shost->shost_data; 324 ihost = shost->shost_data;
325
326 session->sid = iscsi_session_nr++; 325 session->sid = iscsi_session_nr++;
327 session->target_id = ihost->next_target_id++; 326 session->target_id = target_id;
328 327
329 snprintf(session->dev.bus_id, BUS_ID_SIZE, "session%u", 328 snprintf(session->dev.bus_id, BUS_ID_SIZE, "session%u",
330 session->sid); 329 session->sid);
@@ -356,7 +355,8 @@ EXPORT_SYMBOL_GPL(iscsi_add_session);
356 **/ 355 **/
357struct iscsi_cls_session * 356struct iscsi_cls_session *
358iscsi_create_session(struct Scsi_Host *shost, 357iscsi_create_session(struct Scsi_Host *shost,
359 struct iscsi_transport *transport) 358 struct iscsi_transport *transport,
359 unsigned int target_id)
360{ 360{
361 struct iscsi_cls_session *session; 361 struct iscsi_cls_session *session;
362 362
@@ -364,7 +364,7 @@ iscsi_create_session(struct Scsi_Host *shost,
364 if (!session) 364 if (!session)
365 return NULL; 365 return NULL;
366 366
367 if (iscsi_add_session(session)) { 367 if (iscsi_add_session(session, target_id)) {
368 iscsi_free_session(session); 368 iscsi_free_session(session);
369 return NULL; 369 return NULL;
370 } 370 }