aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-09-25 19:59:07 -0400
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>2006-09-26 14:35:36 -0400
commita2a65a3ecb54ecd1a8f0409f11cb82ae083c6964 (patch)
treecb4cf44eae7dc53a2951aaf32f76c5b93b5280c4 /drivers/scsi
parentdcbccbde00b85b4d4a1c206b419e7a3d2ab2b1cd (diff)
[SCSI] Signedness issue in drivers/scsi/ipr.c
gcc 4.1 with some extra warnings show the following: drivers/scsi/ipr.c:6361: warning: comparison of unsigned expression < 0 is always false drivers/scsi/ipr.c:6385: warning: comparison of unsigned expression < 0 is always false drivers/scsi/ipr.c:6415: warning: comparison of unsigned expression < 0 is always false The problem is that rc is of the type u32, which can never be smaller than zero, therefore all three error handling checks get useless. This patch changes it to a normal int, because all usages / all functions it get used with expect an int. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Acked-by: Brian King <brking@us.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/ipr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 2e21e162056a..e1fe9494125b 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -6996,7 +6996,7 @@ static int __devinit ipr_probe_ioa(struct pci_dev *pdev,
6996 struct Scsi_Host *host; 6996 struct Scsi_Host *host;
6997 unsigned long ipr_regs_pci; 6997 unsigned long ipr_regs_pci;
6998 void __iomem *ipr_regs; 6998 void __iomem *ipr_regs;
6999 u32 rc = PCIBIOS_SUCCESSFUL; 6999 int rc = PCIBIOS_SUCCESSFUL;
7000 volatile u32 mask, uproc; 7000 volatile u32 mask, uproc;
7001 7001
7002 ENTER; 7002 ENTER;