diff options
author | Bart Van Assche <bvanassche@acm.org> | 2013-06-25 11:27:25 -0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2013-07-08 12:28:06 -0400 |
commit | c5dcfaac943da1a2981e7488f74b0d4259fbb43f (patch) | |
tree | 8ebce26e22bdd784cf4904be19c031f2897d1095 /drivers/scsi | |
parent | 6593d5bdbdb26d848ac5afa469cdca7abd3298df (diff) |
[SCSI] qla2xxx: Remove two superfluous tests.
Since ha->model_desc is an array comparing it against NULL is
superfluous. Hence remove these tests.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/qla2xxx/qla_gs.c | 3 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_os.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index d0ea8b921177..f26442a73d1e 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c | |||
@@ -1370,8 +1370,7 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha) | |||
1370 | /* Model description. */ | 1370 | /* Model description. */ |
1371 | eiter = (struct ct_fdmi_hba_attr *) (entries + size); | 1371 | eiter = (struct ct_fdmi_hba_attr *) (entries + size); |
1372 | eiter->type = __constant_cpu_to_be16(FDMI_HBA_MODEL_DESCRIPTION); | 1372 | eiter->type = __constant_cpu_to_be16(FDMI_HBA_MODEL_DESCRIPTION); |
1373 | if (ha->model_desc) | 1373 | strncpy(eiter->a.model_desc, ha->model_desc, 80); |
1374 | strncpy(eiter->a.model_desc, ha->model_desc, 80); | ||
1375 | alen = strlen(eiter->a.model_desc); | 1374 | alen = strlen(eiter->a.model_desc); |
1376 | alen += (alen & 3) ? (4 - (alen & 3)) : 4; | 1375 | alen += (alen & 3) ? (4 - (alen & 3)) : 4; |
1377 | eiter->len = cpu_to_be16(4 + alen); | 1376 | eiter->len = cpu_to_be16(4 + alen); |
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index c2e2e20d2e21..6df5223888f8 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c | |||
@@ -2839,8 +2839,7 @@ skip_dpc: | |||
2839 | qla2x00_dfs_setup(base_vha); | 2839 | qla2x00_dfs_setup(base_vha); |
2840 | 2840 | ||
2841 | ql_log(ql_log_info, base_vha, 0x00fb, | 2841 | ql_log(ql_log_info, base_vha, 0x00fb, |
2842 | "QLogic %s - %s.\n", | 2842 | "QLogic %s - %s.\n", ha->model_number, ha->model_desc); |
2843 | ha->model_number, ha->model_desc ? ha->model_desc : ""); | ||
2844 | ql_log(ql_log_info, base_vha, 0x00fc, | 2843 | ql_log(ql_log_info, base_vha, 0x00fc, |
2845 | "ISP%04X: %s @ %s hdma%c host#=%ld fw=%s.\n", | 2844 | "ISP%04X: %s @ %s hdma%c host#=%ld fw=%s.\n", |
2846 | pdev->device, ha->isp_ops->pci_info_str(base_vha, pci_info), | 2845 | pdev->device, ha->isp_ops->pci_info_str(base_vha, pci_info), |