aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2005-06-19 07:39:23 -0400
committerJames Bottomley <jejb@titanic.(none)>2005-06-26 13:14:10 -0400
commita4c8f6285165a7089edb2010dbd894148ca95d57 (patch)
tree50ce1ab6b0944f13d821ada235292e4363ddb1c2 /drivers/scsi
parentfa4c49669f0408557bc52cd7054c920a8790dec6 (diff)
[SCSI] remove scsi_cmnd.eh_state
it's never set to anything, and just three broken drivers are looking at it and doing odd things. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/dpt_i2o.c5
-rw-r--r--drivers/scsi/eata.c10
-rw-r--r--drivers/scsi/u14-34f.c9
3 files changed, 0 insertions, 24 deletions
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index bbe346bd3cb8..c2604e88d3b0 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -418,11 +418,6 @@ static int adpt_queue(struct scsi_cmnd * cmd, void (*done) (struct scsi_cmnd *))
418 return 1; 418 return 1;
419 } 419 }
420 420
421 if(cmd->eh_state != SCSI_STATE_QUEUED){
422 // If we are not doing error recovery
423 mod_timer(&cmd->eh_timeout, timeout);
424 }
425
426 // TODO if the cmd->device if offline then I may need to issue a bus rescan 421 // TODO if the cmd->device if offline then I may need to issue a bus rescan
427 // followed by a get_lct to see if the device is there anymore 422 // followed by a get_lct to see if the device is there anymore
428 if((pDev = (struct adpt_device*) (cmd->device->hostdata)) == NULL) { 423 if((pDev = (struct adpt_device*) (cmd->device->hostdata)) == NULL) {
diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
index 1bb8727eea3e..c10e45b94b62 100644
--- a/drivers/scsi/eata.c
+++ b/drivers/scsi/eata.c
@@ -1899,16 +1899,6 @@ static int eata2x_eh_abort(struct scsi_cmnd *SCarg)
1899 printk("%s: abort, mbox %d, interrupt pending.\n", 1899 printk("%s: abort, mbox %d, interrupt pending.\n",
1900 ha->board_name, i); 1900 ha->board_name, i);
1901 1901
1902 if (SCarg->eh_state == SCSI_STATE_TIMEOUT) {
1903 unmap_dma(i, ha);
1904 SCarg->host_scribble = NULL;
1905 ha->cp_stat[i] = FREE;
1906 printk
1907 ("%s, abort, mbox %d, eh_state timeout, pid %ld.\n",
1908 ha->board_name, i, SCarg->pid);
1909 return SUCCESS;
1910 }
1911
1912 return FAILED; 1902 return FAILED;
1913 } 1903 }
1914 1904
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 98369ce09283..b0b6cdf02cbd 100644
--- a/drivers/scsi/u14-34f.c
+++ b/drivers/scsi/u14-34f.c
@@ -1372,15 +1372,6 @@ static int u14_34f_eh_abort(struct scsi_cmnd *SCarg) {
1372 if (inb(sh[j]->io_port + REG_SYS_INTR) & IRQ_ASSERTED) 1372 if (inb(sh[j]->io_port + REG_SYS_INTR) & IRQ_ASSERTED)
1373 printk("%s: abort, mbox %d, interrupt pending.\n", BN(j), i); 1373 printk("%s: abort, mbox %d, interrupt pending.\n", BN(j), i);
1374 1374
1375 if (SCarg->eh_state == SCSI_STATE_TIMEOUT) {
1376 unmap_dma(i, j);
1377 SCarg->host_scribble = NULL;
1378 HD(j)->cp_stat[i] = FREE;
1379 printk("%s, abort, mbox %d, eh_state timeout, pid %ld.\n",
1380 BN(j), i, SCarg->pid);
1381 return SUCCESS;
1382 }
1383
1384 return FAILED; 1375 return FAILED;
1385 } 1376 }
1386 1377