diff options
author | Tejun Heo <htejun@gmail.com> | 2005-05-13 11:46:18 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.(none)> | 2005-05-20 13:53:53 -0400 |
commit | 5b8ef8425898e957243053c26ac2b68bd4bc42ec (patch) | |
tree | 258db4841aca495cf8c3f0384d8db0e20c235721 /drivers/scsi | |
parent | 0155a37ea5459f5bf1113c6fa519f943ef77d730 (diff) |
[SCSI] remove spurious if tests from scsi_eh_{times_out|done}
'if' tests which check if eh_action isn't NULL in both
functions are always true. Remove the redundant if's as it
can give wrong impressions.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/scsi_error.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index f5195cda5ef1..103558574662 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c | |||
@@ -434,8 +434,7 @@ static void scsi_eh_times_out(struct scsi_cmnd *scmd) | |||
434 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s: scmd:%p\n", __FUNCTION__, | 434 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s: scmd:%p\n", __FUNCTION__, |
435 | scmd)); | 435 | scmd)); |
436 | 436 | ||
437 | if (scmd->device->host->eh_action) | 437 | up(scmd->device->host->eh_action); |
438 | up(scmd->device->host->eh_action); | ||
439 | } | 438 | } |
440 | 439 | ||
441 | /** | 440 | /** |
@@ -457,8 +456,7 @@ static void scsi_eh_done(struct scsi_cmnd *scmd) | |||
457 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s scmd: %p result: %x\n", | 456 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s scmd: %p result: %x\n", |
458 | __FUNCTION__, scmd, scmd->result)); | 457 | __FUNCTION__, scmd, scmd->result)); |
459 | 458 | ||
460 | if (scmd->device->host->eh_action) | 459 | up(scmd->device->host->eh_action); |
461 | up(scmd->device->host->eh_action); | ||
462 | } | 460 | } |
463 | } | 461 | } |
464 | 462 | ||