diff options
author | Brian King <brking@linux.vnet.ibm.com> | 2008-07-22 09:31:39 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-07-26 15:14:57 -0400 |
commit | 0ae808e02e000058cf65a47662c187dc061bcfd3 (patch) | |
tree | a3ad1f54461da1d89c37898b4b6a6bacae0555c0 /drivers/scsi | |
parent | e41443ec3bb3dc4b12c861e91a5d36feb45f8a46 (diff) |
[SCSI] ibmvfc: Reduce unnecessary log noise
Reduces some unnecessary log noise by removing a printk during
host port state query and increasing the log level required to
log received async events.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/ibmvscsi/ibmvfc.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index c4a7c06793c5..8d393800f47e 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c | |||
@@ -963,6 +963,9 @@ static void ibmvfc_get_host_port_state(struct Scsi_Host *shost) | |||
963 | case IBMVFC_HALTED: | 963 | case IBMVFC_HALTED: |
964 | fc_host_port_state(shost) = FC_PORTSTATE_BLOCKED; | 964 | fc_host_port_state(shost) = FC_PORTSTATE_BLOCKED; |
965 | break; | 965 | break; |
966 | case IBMVFC_NO_CRQ: | ||
967 | fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; | ||
968 | break; | ||
966 | default: | 969 | default: |
967 | ibmvfc_log(vhost, 3, "Unknown port state: %d\n", vhost->state); | 970 | ibmvfc_log(vhost, 3, "Unknown port state: %d\n", vhost->state); |
968 | fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; | 971 | fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; |
@@ -1404,7 +1407,7 @@ static void ibmvfc_log_error(struct ibmvfc_event *evt) | |||
1404 | err = cmd_status[index].name; | 1407 | err = cmd_status[index].name; |
1405 | } | 1408 | } |
1406 | 1409 | ||
1407 | if (!logerr && (vhost->log_level <= IBMVFC_DEFAULT_LOG_LEVEL)) | 1410 | if (!logerr && (vhost->log_level <= (IBMVFC_DEFAULT_LOG_LEVEL + 1))) |
1408 | return; | 1411 | return; |
1409 | 1412 | ||
1410 | if (rsp->flags & FCP_RSP_LEN_VALID) | 1413 | if (rsp->flags & FCP_RSP_LEN_VALID) |
@@ -2054,7 +2057,7 @@ static void ibmvfc_handle_async(struct ibmvfc_async_crq *crq, | |||
2054 | { | 2057 | { |
2055 | const char *desc = ibmvfc_get_ae_desc(crq->event); | 2058 | const char *desc = ibmvfc_get_ae_desc(crq->event); |
2056 | 2059 | ||
2057 | ibmvfc_log(vhost, 2, "%s event received\n", desc); | 2060 | ibmvfc_log(vhost, 3, "%s event received\n", desc); |
2058 | 2061 | ||
2059 | switch (crq->event) { | 2062 | switch (crq->event) { |
2060 | case IBMVFC_AE_LINK_UP: | 2063 | case IBMVFC_AE_LINK_UP: |