diff options
| author | Mark Haverkamp <markh@osdl.org> | 2005-09-01 11:19:23 -0400 |
|---|---|---|
| committer | James Bottomley <jejb@mulgrave.(none)> | 2005-09-04 20:46:06 -0400 |
| commit | 77d71d222e871670300f3e3092e2a06f20c842f0 (patch) | |
| tree | 0cec7672a87b0becb254e67482c69074594943cb /drivers/scsi | |
| parent | deb92b7ee98e8e580cafaa63bd1edbe6646877bc (diff) | |
[SCSI] aacraid: bad BUG_ON fix
This was noticed by Doug Bazamic and the fix found by Mark Salyzyn at
Adaptec.
There was an error in the BUG_ON() statement that validated the
calculated fib size which can cause the driver to panic.
Signed-off-by: Mark Haverkamp <markh@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/aacraid/aachba.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 83bfab73ff65..a8e3dfcd0dc7 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c | |||
| @@ -972,7 +972,7 @@ static int aac_read(struct scsi_cmnd * scsicmd, int cid) | |||
| 972 | fibsize = sizeof(struct aac_read64) + | 972 | fibsize = sizeof(struct aac_read64) + |
| 973 | ((le32_to_cpu(readcmd->sg.count) - 1) * | 973 | ((le32_to_cpu(readcmd->sg.count) - 1) * |
| 974 | sizeof (struct sgentry64)); | 974 | sizeof (struct sgentry64)); |
| 975 | BUG_ON (fibsize > (sizeof(struct hw_fib) - | 975 | BUG_ON (fibsize > (dev->max_fib_size - |
| 976 | sizeof(struct aac_fibhdr))); | 976 | sizeof(struct aac_fibhdr))); |
| 977 | /* | 977 | /* |
| 978 | * Now send the Fib to the adapter | 978 | * Now send the Fib to the adapter |