scsi: simplify scsi_free_sgtable()

Just pass in the command, no point in passing in the scatterlist
and scatterlist pool index seperately.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

2 files changed, 7 insertions, 6 deletions

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 960f949b8f8f..7e1dcc57f115 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -741,13 +741,14 @@ struct scatterlist *scsi_alloc_sgtable(struct scsi_cmnd *cmd, gfp_t gfp_mask)
 
 EXPORT_SYMBOL(scsi_alloc_sgtable);
 
-void scsi_free_sgtable(struct scatterlist *sgl, int index)
+void scsi_free_sgtable(struct scsi_cmnd *cmd)
 {
+        struct scatterlist *sgl = cmd->request_buffer;
         struct scsi_host_sg_pool *sgp;
 
-        BUG_ON(index >= SG_MEMPOOL_NR);
+        BUG_ON(cmd->sglist_len >= SG_MEMPOOL_NR);
 
-        sgp = scsi_sg_pools + index;
+        sgp = scsi_sg_pools + cmd->sglist_len;
         mempool_free(sgl, sgp->pool);
 }
 
@@ -773,7 +774,7 @@ EXPORT_SYMBOL(scsi_free_sgtable);
 static void scsi_release_buffers(struct scsi_cmnd *cmd)
 {
         if (cmd->use_sg)
-                scsi_free_sgtable(cmd->request_buffer, cmd->sglist_len);
+                scsi_free_sgtable(cmd);
 
         /*
          * Zero these out.  They now point to freed memory, and it is
diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c
index 66c692ffa305..a91761c3645f 100644
--- a/drivers/scsi/scsi_tgt_lib.c
+++ b/drivers/scsi/scsi_tgt_lib.c
@@ -332,7 +332,7 @@ static void scsi_tgt_cmd_done(struct scsi_cmnd *cmd)
         scsi_tgt_uspace_send_status(cmd, tcmd->itn_id, tcmd->tag);
 
         if (cmd->request_buffer)
-                scsi_free_sgtable(cmd->request_buffer, cmd->sglist_len);
+                scsi_free_sgtable(cmd);
 
         queue_work(scsi_tgtd, &tcmd->work);
 }
@@ -373,7 +373,7 @@ static int scsi_tgt_init_cmd(struct scsi_cmnd *cmd, gfp_t gfp_mask)
         }
 
         eprintk("cmd %p cnt %d\n", cmd, cmd->use_sg);
-        scsi_free_sgtable(cmd->request_buffer, cmd->sglist_len);
+        scsi_free_sgtable(cmd);
         return -EINVAL;
 }