diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/scsi | |
parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/scsi')
-rw-r--r-- | drivers/scsi/aha1542.c | 2 | ||||
-rw-r--r-- | drivers/scsi/dc395x.c | 2 | ||||
-rw-r--r-- | drivers/scsi/nsp32.c | 4 | ||||
-rw-r--r-- | drivers/scsi/pcmcia/nsp_cs.c | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 195823a51aab..ed119cedaae0 100644 --- a/drivers/scsi/aha1542.c +++ b/drivers/scsi/aha1542.c | |||
@@ -102,7 +102,7 @@ static int setup_dmaspeed[MAXBOARDS] __initdata = { -1, -1, -1, -1 }; | |||
102 | */ | 102 | */ |
103 | 103 | ||
104 | #if defined(MODULE) | 104 | #if defined(MODULE) |
105 | static int isapnp = 0; | 105 | static bool isapnp = 0; |
106 | static int aha1542[] = {0x330, 11, 4, -1}; | 106 | static int aha1542[] = {0x330, 11, 4, -1}; |
107 | module_param_array(aha1542, int, NULL, 0); | 107 | module_param_array(aha1542, int, NULL, 0); |
108 | module_param(isapnp, bool, 0); | 108 | module_param(isapnp, bool, 0); |
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index f5b718d3c31b..13aeca3d51f2 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c | |||
@@ -546,7 +546,7 @@ static struct ParameterData __devinitdata cfg_data[] = { | |||
546 | * command line overrides will be used. If set to 1 then safe and | 546 | * command line overrides will be used. If set to 1 then safe and |
547 | * slow settings will be used. | 547 | * slow settings will be used. |
548 | */ | 548 | */ |
549 | static int use_safe_settings = 0; | 549 | static bool use_safe_settings = 0; |
550 | module_param_named(safe, use_safe_settings, bool, 0); | 550 | module_param_named(safe, use_safe_settings, bool, 0); |
551 | MODULE_PARM_DESC(safe, "Use safe and slow settings only. Default: false"); | 551 | MODULE_PARM_DESC(safe, "Use safe and slow settings only. Default: false"); |
552 | 552 | ||
diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c index f6a50c98c36f..002924963cd8 100644 --- a/drivers/scsi/nsp32.c +++ b/drivers/scsi/nsp32.c | |||
@@ -59,11 +59,11 @@ MODULE_PARM_DESC(trans_mode, "transfer mode (0: BIOS(default) 1: Async 2: Ultra2 | |||
59 | #define ASYNC_MODE 1 | 59 | #define ASYNC_MODE 1 |
60 | #define ULTRA20M_MODE 2 | 60 | #define ULTRA20M_MODE 2 |
61 | 61 | ||
62 | static int auto_param = 0; /* default: ON */ | 62 | static bool auto_param = 0; /* default: ON */ |
63 | module_param (auto_param, bool, 0); | 63 | module_param (auto_param, bool, 0); |
64 | MODULE_PARM_DESC(auto_param, "AutoParameter mode (0: ON(default) 1: OFF)"); | 64 | MODULE_PARM_DESC(auto_param, "AutoParameter mode (0: ON(default) 1: OFF)"); |
65 | 65 | ||
66 | static int disc_priv = 1; /* default: OFF */ | 66 | static bool disc_priv = 1; /* default: OFF */ |
67 | module_param (disc_priv, bool, 0); | 67 | module_param (disc_priv, bool, 0); |
68 | MODULE_PARM_DESC(disc_priv, "disconnection privilege mode (0: ON 1: OFF(default))"); | 68 | MODULE_PARM_DESC(disc_priv, "disconnection privilege mode (0: ON 1: OFF(default))"); |
69 | 69 | ||
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index ca86721a71b9..b61a753eb896 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c | |||
@@ -70,7 +70,7 @@ module_param(nsp_burst_mode, int, 0); | |||
70 | MODULE_PARM_DESC(nsp_burst_mode, "Burst transfer mode (0=io8, 1=io32, 2=mem32(default))"); | 70 | MODULE_PARM_DESC(nsp_burst_mode, "Burst transfer mode (0=io8, 1=io32, 2=mem32(default))"); |
71 | 71 | ||
72 | /* Release IO ports after configuration? */ | 72 | /* Release IO ports after configuration? */ |
73 | static int free_ports = 0; | 73 | static bool free_ports = 0; |
74 | module_param(free_ports, bool, 0); | 74 | module_param(free_ports, bool, 0); |
75 | MODULE_PARM_DESC(free_ports, "Release IO ports after configuration? (default: 0 (=no))"); | 75 | MODULE_PARM_DESC(free_ports, "Release IO ports after configuration? (default: 0 (=no))"); |
76 | 76 | ||