diff options
author | Christoph Hellwig <hch@infradead.org> | 2011-04-04 09:42:14 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2011-05-01 11:22:40 -0400 |
commit | 5cd049a59913f359e7d30c11d2dc6187822e77b1 (patch) | |
tree | f1406a16f6f0b786857e4433467d7ad762e45186 /drivers/scsi/wd33c93.c | |
parent | f04ca1b65480df9ecbaaa797e62b063387429410 (diff) |
[SCSI] remove cmd->serial_number litter
Stop using cmd->serial_number in printks.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/wd33c93.c')
-rw-r--r-- | drivers/scsi/wd33c93.c | 45 |
1 files changed, 22 insertions, 23 deletions
diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c index 4468ae3610f7..97ae716134d0 100644 --- a/drivers/scsi/wd33c93.c +++ b/drivers/scsi/wd33c93.c | |||
@@ -381,7 +381,7 @@ wd33c93_queuecommand_lck(struct scsi_cmnd *cmd, | |||
381 | hostdata = (struct WD33C93_hostdata *) cmd->device->host->hostdata; | 381 | hostdata = (struct WD33C93_hostdata *) cmd->device->host->hostdata; |
382 | 382 | ||
383 | DB(DB_QUEUE_COMMAND, | 383 | DB(DB_QUEUE_COMMAND, |
384 | printk("Q-%d-%02x-%ld( ", cmd->device->id, cmd->cmnd[0], cmd->serial_number)) | 384 | printk("Q-%d-%02x( ", cmd->device->id, cmd->cmnd[0])) |
385 | 385 | ||
386 | /* Set up a few fields in the scsi_cmnd structure for our own use: | 386 | /* Set up a few fields in the scsi_cmnd structure for our own use: |
387 | * - host_scribble is the pointer to the next cmd in the input queue | 387 | * - host_scribble is the pointer to the next cmd in the input queue |
@@ -462,7 +462,7 @@ wd33c93_queuecommand_lck(struct scsi_cmnd *cmd, | |||
462 | 462 | ||
463 | wd33c93_execute(cmd->device->host); | 463 | wd33c93_execute(cmd->device->host); |
464 | 464 | ||
465 | DB(DB_QUEUE_COMMAND, printk(")Q-%ld ", cmd->serial_number)) | 465 | DB(DB_QUEUE_COMMAND, printk(")Q ")) |
466 | 466 | ||
467 | spin_unlock_irq(&hostdata->lock); | 467 | spin_unlock_irq(&hostdata->lock); |
468 | return 0; | 468 | return 0; |
@@ -687,7 +687,7 @@ wd33c93_execute(struct Scsi_Host *instance) | |||
687 | */ | 687 | */ |
688 | 688 | ||
689 | DB(DB_EXECUTE, | 689 | DB(DB_EXECUTE, |
690 | printk("%s%ld)EX-2 ", (cmd->SCp.phase) ? "d:" : "", cmd->serial_number)) | 690 | printk("%s)EX-2 ", (cmd->SCp.phase) ? "d:" : "")) |
691 | } | 691 | } |
692 | 692 | ||
693 | static void | 693 | static void |
@@ -963,7 +963,7 @@ wd33c93_intr(struct Scsi_Host *instance) | |||
963 | case CSR_XFER_DONE | PHS_COMMAND: | 963 | case CSR_XFER_DONE | PHS_COMMAND: |
964 | case CSR_UNEXP | PHS_COMMAND: | 964 | case CSR_UNEXP | PHS_COMMAND: |
965 | case CSR_SRV_REQ | PHS_COMMAND: | 965 | case CSR_SRV_REQ | PHS_COMMAND: |
966 | DB(DB_INTR, printk("CMND-%02x,%ld", cmd->cmnd[0], cmd->serial_number)) | 966 | DB(DB_INTR, printk("CMND-%02x", cmd->cmnd[0])) |
967 | transfer_pio(regs, cmd->cmnd, cmd->cmd_len, DATA_OUT_DIR, | 967 | transfer_pio(regs, cmd->cmnd, cmd->cmd_len, DATA_OUT_DIR, |
968 | hostdata); | 968 | hostdata); |
969 | hostdata->state = S_CONNECTED; | 969 | hostdata->state = S_CONNECTED; |
@@ -1007,7 +1007,7 @@ wd33c93_intr(struct Scsi_Host *instance) | |||
1007 | switch (msg) { | 1007 | switch (msg) { |
1008 | 1008 | ||
1009 | case COMMAND_COMPLETE: | 1009 | case COMMAND_COMPLETE: |
1010 | DB(DB_INTR, printk("CCMP-%ld", cmd->serial_number)) | 1010 | DB(DB_INTR, printk("CCMP")) |
1011 | write_wd33c93_cmd(regs, WD_CMD_NEGATE_ACK); | 1011 | write_wd33c93_cmd(regs, WD_CMD_NEGATE_ACK); |
1012 | hostdata->state = S_PRE_CMP_DISC; | 1012 | hostdata->state = S_PRE_CMP_DISC; |
1013 | break; | 1013 | break; |
@@ -1174,7 +1174,7 @@ wd33c93_intr(struct Scsi_Host *instance) | |||
1174 | 1174 | ||
1175 | write_wd33c93(regs, WD_SOURCE_ID, SRCID_ER); | 1175 | write_wd33c93(regs, WD_SOURCE_ID, SRCID_ER); |
1176 | if (phs == 0x60) { | 1176 | if (phs == 0x60) { |
1177 | DB(DB_INTR, printk("SX-DONE-%ld", cmd->serial_number)) | 1177 | DB(DB_INTR, printk("SX-DONE")) |
1178 | cmd->SCp.Message = COMMAND_COMPLETE; | 1178 | cmd->SCp.Message = COMMAND_COMPLETE; |
1179 | lun = read_wd33c93(regs, WD_TARGET_LUN); | 1179 | lun = read_wd33c93(regs, WD_TARGET_LUN); |
1180 | DB(DB_INTR, printk(":%d.%d", cmd->SCp.Status, lun)) | 1180 | DB(DB_INTR, printk(":%d.%d", cmd->SCp.Status, lun)) |
@@ -1200,8 +1200,8 @@ wd33c93_intr(struct Scsi_Host *instance) | |||
1200 | wd33c93_execute(instance); | 1200 | wd33c93_execute(instance); |
1201 | } else { | 1201 | } else { |
1202 | printk | 1202 | printk |
1203 | ("%02x:%02x:%02x-%ld: Unknown SEL_XFER_DONE phase!!---", | 1203 | ("%02x:%02x:%02x: Unknown SEL_XFER_DONE phase!!---", |
1204 | asr, sr, phs, cmd->serial_number); | 1204 | asr, sr, phs); |
1205 | spin_unlock_irqrestore(&hostdata->lock, flags); | 1205 | spin_unlock_irqrestore(&hostdata->lock, flags); |
1206 | } | 1206 | } |
1207 | break; | 1207 | break; |
@@ -1266,7 +1266,7 @@ wd33c93_intr(struct Scsi_Host *instance) | |||
1266 | spin_unlock_irqrestore(&hostdata->lock, flags); | 1266 | spin_unlock_irqrestore(&hostdata->lock, flags); |
1267 | return; | 1267 | return; |
1268 | } | 1268 | } |
1269 | DB(DB_INTR, printk("UNEXP_DISC-%ld", cmd->serial_number)) | 1269 | DB(DB_INTR, printk("UNEXP_DISC")) |
1270 | hostdata->connected = NULL; | 1270 | hostdata->connected = NULL; |
1271 | hostdata->busy[cmd->device->id] &= ~(1 << cmd->device->lun); | 1271 | hostdata->busy[cmd->device->id] &= ~(1 << cmd->device->lun); |
1272 | hostdata->state = S_UNCONNECTED; | 1272 | hostdata->state = S_UNCONNECTED; |
@@ -1292,7 +1292,7 @@ wd33c93_intr(struct Scsi_Host *instance) | |||
1292 | */ | 1292 | */ |
1293 | 1293 | ||
1294 | write_wd33c93(regs, WD_SOURCE_ID, SRCID_ER); | 1294 | write_wd33c93(regs, WD_SOURCE_ID, SRCID_ER); |
1295 | DB(DB_INTR, printk("DISC-%ld", cmd->serial_number)) | 1295 | DB(DB_INTR, printk("DISC")) |
1296 | if (cmd == NULL) { | 1296 | if (cmd == NULL) { |
1297 | printk(" - Already disconnected! "); | 1297 | printk(" - Already disconnected! "); |
1298 | hostdata->state = S_UNCONNECTED; | 1298 | hostdata->state = S_UNCONNECTED; |
@@ -1491,7 +1491,6 @@ wd33c93_intr(struct Scsi_Host *instance) | |||
1491 | } else | 1491 | } else |
1492 | hostdata->state = S_CONNECTED; | 1492 | hostdata->state = S_CONNECTED; |
1493 | 1493 | ||
1494 | DB(DB_INTR, printk("-%ld", cmd->serial_number)) | ||
1495 | spin_unlock_irqrestore(&hostdata->lock, flags); | 1494 | spin_unlock_irqrestore(&hostdata->lock, flags); |
1496 | break; | 1495 | break; |
1497 | 1496 | ||
@@ -1637,8 +1636,8 @@ wd33c93_abort(struct scsi_cmnd * cmd) | |||
1637 | cmd->host_scribble = NULL; | 1636 | cmd->host_scribble = NULL; |
1638 | cmd->result = DID_ABORT << 16; | 1637 | cmd->result = DID_ABORT << 16; |
1639 | printk | 1638 | printk |
1640 | ("scsi%d: Abort - removing command %ld from input_Q. ", | 1639 | ("scsi%d: Abort - removing command from input_Q. ", |
1641 | instance->host_no, cmd->serial_number); | 1640 | instance->host_no); |
1642 | enable_irq(cmd->device->host->irq); | 1641 | enable_irq(cmd->device->host->irq); |
1643 | cmd->scsi_done(cmd); | 1642 | cmd->scsi_done(cmd); |
1644 | return SUCCESS; | 1643 | return SUCCESS; |
@@ -1662,8 +1661,8 @@ wd33c93_abort(struct scsi_cmnd * cmd) | |||
1662 | uchar sr, asr; | 1661 | uchar sr, asr; |
1663 | unsigned long timeout; | 1662 | unsigned long timeout; |
1664 | 1663 | ||
1665 | printk("scsi%d: Aborting connected command %ld - ", | 1664 | printk("scsi%d: Aborting connected command - ", |
1666 | instance->host_no, cmd->serial_number); | 1665 | instance->host_no); |
1667 | 1666 | ||
1668 | printk("stopping DMA - "); | 1667 | printk("stopping DMA - "); |
1669 | if (hostdata->dma == D_DMA_RUNNING) { | 1668 | if (hostdata->dma == D_DMA_RUNNING) { |
@@ -1729,8 +1728,8 @@ wd33c93_abort(struct scsi_cmnd * cmd) | |||
1729 | while (tmp) { | 1728 | while (tmp) { |
1730 | if (tmp == cmd) { | 1729 | if (tmp == cmd) { |
1731 | printk | 1730 | printk |
1732 | ("scsi%d: Abort - command %ld found on disconnected_Q - ", | 1731 | ("scsi%d: Abort - command found on disconnected_Q - ", |
1733 | instance->host_no, cmd->serial_number); | 1732 | instance->host_no); |
1734 | printk("Abort SNOOZE. "); | 1733 | printk("Abort SNOOZE. "); |
1735 | enable_irq(cmd->device->host->irq); | 1734 | enable_irq(cmd->device->host->irq); |
1736 | return FAILED; | 1735 | return FAILED; |
@@ -2180,8 +2179,8 @@ wd33c93_proc_info(struct Scsi_Host *instance, char *buf, char **start, off_t off | |||
2180 | strcat(bp, "\nconnected: "); | 2179 | strcat(bp, "\nconnected: "); |
2181 | if (hd->connected) { | 2180 | if (hd->connected) { |
2182 | cmd = (struct scsi_cmnd *) hd->connected; | 2181 | cmd = (struct scsi_cmnd *) hd->connected; |
2183 | sprintf(tbuf, " %ld-%d:%d(%02x)", | 2182 | sprintf(tbuf, " %d:%d(%02x)", |
2184 | cmd->serial_number, cmd->device->id, cmd->device->lun, cmd->cmnd[0]); | 2183 | cmd->device->id, cmd->device->lun, cmd->cmnd[0]); |
2185 | strcat(bp, tbuf); | 2184 | strcat(bp, tbuf); |
2186 | } | 2185 | } |
2187 | } | 2186 | } |
@@ -2189,8 +2188,8 @@ wd33c93_proc_info(struct Scsi_Host *instance, char *buf, char **start, off_t off | |||
2189 | strcat(bp, "\ninput_Q: "); | 2188 | strcat(bp, "\ninput_Q: "); |
2190 | cmd = (struct scsi_cmnd *) hd->input_Q; | 2189 | cmd = (struct scsi_cmnd *) hd->input_Q; |
2191 | while (cmd) { | 2190 | while (cmd) { |
2192 | sprintf(tbuf, " %ld-%d:%d(%02x)", | 2191 | sprintf(tbuf, " %d:%d(%02x)", |
2193 | cmd->serial_number, cmd->device->id, cmd->device->lun, cmd->cmnd[0]); | 2192 | cmd->device->id, cmd->device->lun, cmd->cmnd[0]); |
2194 | strcat(bp, tbuf); | 2193 | strcat(bp, tbuf); |
2195 | cmd = (struct scsi_cmnd *) cmd->host_scribble; | 2194 | cmd = (struct scsi_cmnd *) cmd->host_scribble; |
2196 | } | 2195 | } |
@@ -2199,8 +2198,8 @@ wd33c93_proc_info(struct Scsi_Host *instance, char *buf, char **start, off_t off | |||
2199 | strcat(bp, "\ndisconnected_Q:"); | 2198 | strcat(bp, "\ndisconnected_Q:"); |
2200 | cmd = (struct scsi_cmnd *) hd->disconnected_Q; | 2199 | cmd = (struct scsi_cmnd *) hd->disconnected_Q; |
2201 | while (cmd) { | 2200 | while (cmd) { |
2202 | sprintf(tbuf, " %ld-%d:%d(%02x)", | 2201 | sprintf(tbuf, " %d:%d(%02x)", |
2203 | cmd->serial_number, cmd->device->id, cmd->device->lun, cmd->cmnd[0]); | 2202 | cmd->device->id, cmd->device->lun, cmd->cmnd[0]); |
2204 | strcat(bp, tbuf); | 2203 | strcat(bp, tbuf); |
2205 | cmd = (struct scsi_cmnd *) cmd->host_scribble; | 2204 | cmd = (struct scsi_cmnd *) cmd->host_scribble; |
2206 | } | 2205 | } |