diff options
author | Christoph Hellwig <hch@infradead.org> | 2011-04-04 09:42:14 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2011-05-01 11:22:40 -0400 |
commit | 5cd049a59913f359e7d30c11d2dc6187822e77b1 (patch) | |
tree | f1406a16f6f0b786857e4433467d7ad762e45186 /drivers/scsi/tmscsim.c | |
parent | f04ca1b65480df9ecbaaa797e62b063387429410 (diff) |
[SCSI] remove cmd->serial_number litter
Stop using cmd->serial_number in printks.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/tmscsim.c')
-rw-r--r-- | drivers/scsi/tmscsim.c | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c index a124a28f2ccb..a1baccce05f0 100644 --- a/drivers/scsi/tmscsim.c +++ b/drivers/scsi/tmscsim.c | |||
@@ -565,12 +565,12 @@ dc390_StartSCSI( struct dc390_acb* pACB, struct dc390_dcb* pDCB, struct dc390_sr | |||
565 | pDCB->TagMask |= 1 << tag[1]; | 565 | pDCB->TagMask |= 1 << tag[1]; |
566 | pSRB->TagNumber = tag[1]; | 566 | pSRB->TagNumber = tag[1]; |
567 | DC390_write8(ScsiFifo, tag[1]); | 567 | DC390_write8(ScsiFifo, tag[1]); |
568 | DEBUG1(printk(KERN_INFO "DC390: Select w/DisCn for Cmd %li (SRB %p), block tag %02x\n", scmd->serial_number, pSRB, tag[1])); | 568 | DEBUG1(printk(KERN_INFO "DC390: Select w/DisCn for SRB %p, block tag %02x\n", pSRB, tag[1])); |
569 | cmd = SEL_W_ATN3; | 569 | cmd = SEL_W_ATN3; |
570 | } else { | 570 | } else { |
571 | /* No TagQ */ | 571 | /* No TagQ */ |
572 | //no_tag: | 572 | //no_tag: |
573 | DEBUG1(printk(KERN_INFO "DC390: Select w%s/DisCn for Cmd %li (SRB %p), No TagQ\n", disc_allowed ? "" : "o", scmd->serial_number, pSRB)); | 573 | DEBUG1(printk(KERN_INFO "DC390: Select w%s/DisCn for SRB %p, No TagQ\n", disc_allowed ? "" : "o", pSRB)); |
574 | } | 574 | } |
575 | 575 | ||
576 | pSRB->SRBState = SRB_START_; | 576 | pSRB->SRBState = SRB_START_; |
@@ -620,8 +620,8 @@ dc390_StartSCSI( struct dc390_acb* pACB, struct dc390_dcb* pDCB, struct dc390_sr | |||
620 | if (DC390_read8 (Scsi_Status) & INTERRUPT) | 620 | if (DC390_read8 (Scsi_Status) & INTERRUPT) |
621 | { | 621 | { |
622 | dc390_freetag (pDCB, pSRB); | 622 | dc390_freetag (pDCB, pSRB); |
623 | DEBUG0(printk ("DC390: Interrupt during Start SCSI (pid %li, target %02i-%02i)\n", | 623 | DEBUG0(printk ("DC390: Interrupt during Start SCSI (target %02i-%02i)\n", |
624 | scmd->serial_number, scmd->device->id, scmd->device->lun)); | 624 | scmd->device->id, scmd->device->lun)); |
625 | pSRB->SRBState = SRB_READY; | 625 | pSRB->SRBState = SRB_READY; |
626 | //DC390_write8 (ScsiCmd, CLEAR_FIFO_CMD); | 626 | //DC390_write8 (ScsiCmd, CLEAR_FIFO_CMD); |
627 | pACB->SelLost++; | 627 | pACB->SelLost++; |
@@ -1705,8 +1705,7 @@ dc390_SRBdone( struct dc390_acb* pACB, struct dc390_dcb* pDCB, struct dc390_srb* | |||
1705 | 1705 | ||
1706 | status = pSRB->TargetStatus; | 1706 | status = pSRB->TargetStatus; |
1707 | 1707 | ||
1708 | DEBUG0(printk (" SRBdone (%02x,%08x), SRB %p, pid %li\n", status, pcmd->result,\ | 1708 | DEBUG0(printk (" SRBdone (%02x,%08x), SRB %p\n", status, pcmd->result, pSRB)); |
1709 | pSRB, pcmd->serial_number)); | ||
1710 | if(pSRB->SRBFlag & AUTO_REQSENSE) | 1709 | if(pSRB->SRBFlag & AUTO_REQSENSE) |
1711 | { /* Last command was a Request Sense */ | 1710 | { /* Last command was a Request Sense */ |
1712 | pSRB->SRBFlag &= ~AUTO_REQSENSE; | 1711 | pSRB->SRBFlag &= ~AUTO_REQSENSE; |
@@ -1727,7 +1726,7 @@ dc390_SRBdone( struct dc390_acb* pACB, struct dc390_dcb* pDCB, struct dc390_srb* | |||
1727 | } else { | 1726 | } else { |
1728 | SET_RES_DRV(pcmd->result, DRIVER_SENSE); | 1727 | SET_RES_DRV(pcmd->result, DRIVER_SENSE); |
1729 | //pSRB->ScsiCmdLen = (u8) (pSRB->Segment1[0] >> 8); | 1728 | //pSRB->ScsiCmdLen = (u8) (pSRB->Segment1[0] >> 8); |
1730 | DEBUG0 (printk ("DC390: RETRY pid %li (%02x), target %02i-%02i\n", pcmd->serial_number, pcmd->cmnd[0], pcmd->device->id, pcmd->device->lun)); | 1729 | DEBUG0 (printk ("DC390: RETRY (%02x), target %02i-%02i\n", pcmd->cmnd[0], pcmd->device->id, pcmd->device->lun)); |
1731 | pSRB->TotalXferredLen = 0; | 1730 | pSRB->TotalXferredLen = 0; |
1732 | SET_RES_DID(pcmd->result, DID_SOFT_ERROR); | 1731 | SET_RES_DID(pcmd->result, DID_SOFT_ERROR); |
1733 | } | 1732 | } |
@@ -1747,7 +1746,7 @@ dc390_SRBdone( struct dc390_acb* pACB, struct dc390_dcb* pDCB, struct dc390_srb* | |||
1747 | else if (status == SAM_STAT_TASK_SET_FULL) | 1746 | else if (status == SAM_STAT_TASK_SET_FULL) |
1748 | { | 1747 | { |
1749 | scsi_track_queue_full(pcmd->device, pDCB->GoingSRBCnt - 1); | 1748 | scsi_track_queue_full(pcmd->device, pDCB->GoingSRBCnt - 1); |
1750 | DEBUG0 (printk ("DC390: RETRY pid %li (%02x), target %02i-%02i\n", pcmd->serial_number, pcmd->cmnd[0], pcmd->device->id, pcmd->device->lun)); | 1749 | DEBUG0 (printk ("DC390: RETRY (%02x), target %02i-%02i\n", pcmd->cmnd[0], pcmd->device->id, pcmd->device->lun)); |
1751 | pSRB->TotalXferredLen = 0; | 1750 | pSRB->TotalXferredLen = 0; |
1752 | SET_RES_DID(pcmd->result, DID_SOFT_ERROR); | 1751 | SET_RES_DID(pcmd->result, DID_SOFT_ERROR); |
1753 | } | 1752 | } |
@@ -1801,7 +1800,7 @@ cmd_done: | |||
1801 | /* Add to free list */ | 1800 | /* Add to free list */ |
1802 | dc390_Free_insert (pACB, pSRB); | 1801 | dc390_Free_insert (pACB, pSRB); |
1803 | 1802 | ||
1804 | DEBUG0(printk (KERN_DEBUG "DC390: SRBdone: done pid %li\n", pcmd->serial_number)); | 1803 | DEBUG0(printk (KERN_DEBUG "DC390: SRBdone: done\n")); |
1805 | pcmd->scsi_done (pcmd); | 1804 | pcmd->scsi_done (pcmd); |
1806 | 1805 | ||
1807 | return; | 1806 | return; |
@@ -1997,8 +1996,7 @@ static int DC390_abort(struct scsi_cmnd *cmd) | |||
1997 | struct dc390_acb *pACB = (struct dc390_acb*) cmd->device->host->hostdata; | 1996 | struct dc390_acb *pACB = (struct dc390_acb*) cmd->device->host->hostdata; |
1998 | struct dc390_dcb *pDCB = (struct dc390_dcb*) cmd->device->hostdata; | 1997 | struct dc390_dcb *pDCB = (struct dc390_dcb*) cmd->device->hostdata; |
1999 | 1998 | ||
2000 | scmd_printk(KERN_WARNING, cmd, | 1999 | scmd_printk(KERN_WARNING, cmd, "DC390: Abort command\n"); |
2001 | "DC390: Abort command (pid %li)\n", cmd->serial_number); | ||
2002 | 2000 | ||
2003 | /* abort() is too stupid for already sent commands at the moment. | 2001 | /* abort() is too stupid for already sent commands at the moment. |
2004 | * If it's called we are in trouble anyway, so let's dump some info | 2002 | * If it's called we are in trouble anyway, so let's dump some info |
@@ -2006,7 +2004,7 @@ static int DC390_abort(struct scsi_cmnd *cmd) | |||
2006 | dc390_dumpinfo(pACB, pDCB, NULL); | 2004 | dc390_dumpinfo(pACB, pDCB, NULL); |
2007 | 2005 | ||
2008 | pDCB->DCBFlag |= ABORT_DEV_; | 2006 | pDCB->DCBFlag |= ABORT_DEV_; |
2009 | printk(KERN_INFO "DC390: Aborted pid %li\n", cmd->serial_number); | 2007 | printk(KERN_INFO "DC390: Aborted.\n"); |
2010 | 2008 | ||
2011 | return FAILED; | 2009 | return FAILED; |
2012 | } | 2010 | } |