aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/t128.c
diff options
context:
space:
mode:
authorFinn Thain <fthain@telegraphics.com.au>2014-11-12 00:11:52 -0500
committerChristoph Hellwig <hch@lst.de>2014-11-20 03:11:05 -0500
commit4d3d2a54f731aa25f66adcf934ba9a55ca8204d4 (patch)
tree99ddb1b68ec6d13a81550f07f4d877b1bea81df4 /drivers/scsi/t128.c
parented8b9e7f1827ebae902e868866438d1bcdbef0a2 (diff)
ncr5380: Remove more useless prototypes
Make use of the host template static initializer instead of assigning handlers at run-time. Move __maybe_unused qualifiers from declarations to definitions. Move the atari_scsi_bus_reset() wrapper after the definition of NCR5380_bus_reset(). All of the host template handler prototypes are now redundant so remove them. The write_info() handler is only relevant to drivers using PSEUDO_DMA so this patch fixes the compiler warning in atari_NCR5380.c and sun3_NCR5380.c: CC drivers/scsi/atari_scsi.o drivers/scsi/NCR5380.h:329: warning: 'NCR5380_write_info' declared 'static' but never defined Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Tested-by: Michael Schmitz <schmitzmic@gmail.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/t128.c')
-rw-r--r--drivers/scsi/t128.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/scsi/t128.c b/drivers/scsi/t128.c
index ccfdc427c4c7..f06ad91d737d 100644
--- a/drivers/scsi/t128.c
+++ b/drivers/scsi/t128.c
@@ -201,10 +201,6 @@ static int __init t128_detect(struct scsi_host_template *tpnt)
201 void __iomem *p; 201 void __iomem *p;
202 int sig, count; 202 int sig, count;
203 203
204 tpnt->proc_name = "t128";
205 tpnt->show_info = t128_show_info;
206 tpnt->write_info = t128_write_info;
207
208 for (count = 0; current_override < NO_OVERRIDES; ++current_override) { 204 for (count = 0; current_override < NO_OVERRIDES; ++current_override) {
209 base = 0; 205 base = 0;
210 p = NULL; 206 p = NULL;
@@ -435,6 +431,9 @@ static struct scsi_host_template driver_template = {
435 .name = "Trantor T128/T128F/T228", 431 .name = "Trantor T128/T128F/T228",
436 .detect = t128_detect, 432 .detect = t128_detect,
437 .release = t128_release, 433 .release = t128_release,
434 .proc_name = "t128",
435 .show_info = t128_show_info,
436 .write_info = t128_write_info,
438 .queuecommand = t128_queue_command, 437 .queuecommand = t128_queue_command,
439 .eh_abort_handler = t128_abort, 438 .eh_abort_handler = t128_abort,
440 .eh_bus_reset_handler = t128_bus_reset, 439 .eh_bus_reset_handler = t128_bus_reset,