diff options
author | Julia Lawall <julia@diku.dk> | 2008-10-14 12:00:19 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-10-23 12:42:19 -0400 |
commit | 3fe68cc152fc7cc6a763c692544a0ab71926c800 (patch) | |
tree | d6552ab321c1cf3104daec5edd100ef83992a635 /drivers/scsi/sun3x_esp.c | |
parent | d4c9b736080056ae3ba81dcf2ac418193c57dbb1 (diff) |
[SCSI] sun3x_esp: Convert && to ||
The pattern !E && !E->fld is nonsensical. The patch below updates this
according to the assumption that && should be ||. But perhaps another
solution was intended.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@disable and_comm@
expression E;
identifier fld;
@@
- !E && !E->fld
+ !E || !E->fld
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/sun3x_esp.c')
-rw-r--r-- | drivers/scsi/sun3x_esp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/sun3x_esp.c b/drivers/scsi/sun3x_esp.c index 7514b3a0390e..34a99620e5bd 100644 --- a/drivers/scsi/sun3x_esp.c +++ b/drivers/scsi/sun3x_esp.c | |||
@@ -213,7 +213,7 @@ static int __devinit esp_sun3x_probe(struct platform_device *dev) | |||
213 | esp->ops = &sun3x_esp_ops; | 213 | esp->ops = &sun3x_esp_ops; |
214 | 214 | ||
215 | res = platform_get_resource(dev, IORESOURCE_MEM, 0); | 215 | res = platform_get_resource(dev, IORESOURCE_MEM, 0); |
216 | if (!res && !res->start) | 216 | if (!res || !res->start) |
217 | goto fail_unlink; | 217 | goto fail_unlink; |
218 | 218 | ||
219 | esp->regs = ioremap_nocache(res->start, 0x20); | 219 | esp->regs = ioremap_nocache(res->start, 0x20); |
@@ -221,7 +221,7 @@ static int __devinit esp_sun3x_probe(struct platform_device *dev) | |||
221 | goto fail_unmap_regs; | 221 | goto fail_unmap_regs; |
222 | 222 | ||
223 | res = platform_get_resource(dev, IORESOURCE_MEM, 1); | 223 | res = platform_get_resource(dev, IORESOURCE_MEM, 1); |
224 | if (!res && !res->start) | 224 | if (!res || !res->start) |
225 | goto fail_unmap_regs; | 225 | goto fail_unmap_regs; |
226 | 226 | ||
227 | esp->dma_regs = ioremap_nocache(res->start, 0x10); | 227 | esp->dma_regs = ioremap_nocache(res->start, 0x10); |