diff options
author | Hannes Reinecke <hare@suse.de> | 2014-10-30 04:44:36 -0400 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2014-11-12 05:16:08 -0500 |
commit | b6c92b7e0af575e2b8b05bdf33633cf9e1661cbf (patch) | |
tree | 9330198bfa322d9dfd400cd8c52bd9d4432ddfbc /drivers/scsi/sun3_NCR5380.c | |
parent | 883a030f989a17b81167f3a181cf93d741fa98b4 (diff) |
scsi: correct return values for .eh_abort_handler implementations
The .eh_abort_handler needs to return SUCCESS, FAILED, or
FAST_IO_FAIL. So fixup all callers to adhere to this requirement.
Reviewed-by: Robert Elliott <elliott@hp.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/sun3_NCR5380.c')
-rw-r--r-- | drivers/scsi/sun3_NCR5380.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/scsi/sun3_NCR5380.c b/drivers/scsi/sun3_NCR5380.c index 3abd796b9893..835bd8dafe0a 100644 --- a/drivers/scsi/sun3_NCR5380.c +++ b/drivers/scsi/sun3_NCR5380.c | |||
@@ -2590,15 +2590,15 @@ static void NCR5380_reselect (struct Scsi_Host *instance) | |||
2590 | * Purpose : abort a command | 2590 | * Purpose : abort a command |
2591 | * | 2591 | * |
2592 | * Inputs : cmd - the struct scsi_cmnd to abort, code - code to set the | 2592 | * Inputs : cmd - the struct scsi_cmnd to abort, code - code to set the |
2593 | * host byte of the result field to, if zero DID_ABORTED is | 2593 | * host byte of the result field to, if zero DID_ABORTED is |
2594 | * used. | 2594 | * used. |
2595 | * | 2595 | * |
2596 | * Returns : 0 - success, -1 on failure. | 2596 | * Returns : SUCCESS - success, FAILED on failure. |
2597 | * | 2597 | * |
2598 | * XXX - there is no way to abort the command that is currently | 2598 | * XXX - there is no way to abort the command that is currently |
2599 | * connected, you have to wait for it to complete. If this is | 2599 | * connected, you have to wait for it to complete. If this is |
2600 | * a problem, we could implement longjmp() / setjmp(), setjmp() | 2600 | * a problem, we could implement longjmp() / setjmp(), setjmp() |
2601 | * called where the loop started in NCR5380_main(). | 2601 | * called where the loop started in NCR5380_main(). |
2602 | */ | 2602 | */ |
2603 | 2603 | ||
2604 | static int NCR5380_abort(struct scsi_cmnd *cmd) | 2604 | static int NCR5380_abort(struct scsi_cmnd *cmd) |