diff options
author | James Bottomley <James.Bottomley@steeleye.com> | 2005-10-02 12:45:08 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.(none)> | 2005-10-28 15:23:02 -0400 |
commit | 9ccfc756a70d454dfa82f48897e2883560c01a0e (patch) | |
tree | 9a6d3b10b1ec0e5fe7a63252a21598a03e93ad4e /drivers/scsi/st.c | |
parent | 9a41a62b74388827998253d62c58707e63cc5874 (diff) |
[SCSI] move the mid-layer printk's over to shost/starget/sdev_printk
This should eliminate (at least in the mid layer) to make numeric
assumptions about any of the enumeration variables. As a side effect,
it will also make all the messages consistent and line us up nicely for
the error logging strategy (if it ever shows itself again).
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/st.c')
-rw-r--r-- | drivers/scsi/st.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 927d700f0073..dc5ffc16a252 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c | |||
@@ -3887,9 +3887,8 @@ static int st_probe(struct device *dev) | |||
3887 | if (SDp->type != TYPE_TAPE) | 3887 | if (SDp->type != TYPE_TAPE) |
3888 | return -ENODEV; | 3888 | return -ENODEV; |
3889 | if ((stp = st_incompatible(SDp))) { | 3889 | if ((stp = st_incompatible(SDp))) { |
3890 | printk(KERN_INFO | 3890 | sdev_printk(KERN_INFO, SDp, |
3891 | "st: Found incompatible tape at scsi%d, channel %d, id %d, lun %d\n", | 3891 | "Found incompatible tape\n"); |
3892 | SDp->host->host_no, SDp->channel, SDp->id, SDp->lun); | ||
3893 | printk(KERN_INFO "st: The suggested driver is %s.\n", stp); | 3892 | printk(KERN_INFO "st: The suggested driver is %s.\n", stp); |
3894 | return -ENODEV; | 3893 | return -ENODEV; |
3895 | } | 3894 | } |
@@ -4077,9 +4076,8 @@ static int st_probe(struct device *dev) | |||
4077 | } | 4076 | } |
4078 | disk->number = devfs_register_tape(SDp->devfs_name); | 4077 | disk->number = devfs_register_tape(SDp->devfs_name); |
4079 | 4078 | ||
4080 | printk(KERN_WARNING | 4079 | sdev_printk(KERN_WARNING, SDp, |
4081 | "Attached scsi tape %s at scsi%d, channel %d, id %d, lun %d\n", | 4080 | "Attached scsi tape %s", tape_name(tpnt)); |
4082 | tape_name(tpnt), SDp->host->host_no, SDp->channel, SDp->id, SDp->lun); | ||
4083 | printk(KERN_WARNING "%s: try direct i/o: %s (alignment %d B), max page reachable by HBA %lu\n", | 4081 | printk(KERN_WARNING "%s: try direct i/o: %s (alignment %d B), max page reachable by HBA %lu\n", |
4084 | tape_name(tpnt), tpnt->try_dio ? "yes" : "no", | 4082 | tape_name(tpnt), tpnt->try_dio ? "yes" : "no", |
4085 | queue_dma_alignment(SDp->request_queue) + 1, tpnt->max_pfn); | 4083 | queue_dma_alignment(SDp->request_queue) + 1, tpnt->max_pfn); |