diff options
author | Jason J. Herne <hernejj@gmail.com> | 2012-11-14 17:03:22 -0500 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2012-11-27 00:00:38 -0500 |
commit | 53ad570be625045aba3ae7de8d82401364c655e1 (patch) | |
tree | 3034c3094a3ae501b0b53ebd2149fd93f4d9b5df /drivers/scsi/sd.c | |
parent | 0b4334473d48aa18e8448f9f718f1dcd0398c550 (diff) |
[SCSI] sd: Use SCSI read/write(16) with > 32-bit LBA drives
Force large capacity (> 0xFFFFFFFF blocks) drives to use READ/WRITE(16) instead
of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
when a large capacity drive is installed. This issue was reported and discussed
here: http://marc.info/?l=linux-usb&m=135247705222324
Signed-off-by: Jason J. Herne <hernejj@gmail.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/sd.c')
-rw-r--r-- | drivers/scsi/sd.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index a45e12ac7e28..c5a189c50286 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c | |||
@@ -1011,7 +1011,7 @@ static int sd_prep_fn(struct request_queue *q, struct request *rq) | |||
1011 | SCpnt->cmnd[29] = (unsigned char) (this_count >> 16) & 0xff; | 1011 | SCpnt->cmnd[29] = (unsigned char) (this_count >> 16) & 0xff; |
1012 | SCpnt->cmnd[30] = (unsigned char) (this_count >> 8) & 0xff; | 1012 | SCpnt->cmnd[30] = (unsigned char) (this_count >> 8) & 0xff; |
1013 | SCpnt->cmnd[31] = (unsigned char) this_count & 0xff; | 1013 | SCpnt->cmnd[31] = (unsigned char) this_count & 0xff; |
1014 | } else if (block > 0xffffffff) { | 1014 | } else if (sdp->use_16_for_rw) { |
1015 | SCpnt->cmnd[0] += READ_16 - READ_6; | 1015 | SCpnt->cmnd[0] += READ_16 - READ_6; |
1016 | SCpnt->cmnd[1] = protect | ((rq->cmd_flags & REQ_FUA) ? 0x8 : 0); | 1016 | SCpnt->cmnd[1] = protect | ((rq->cmd_flags & REQ_FUA) ? 0x8 : 0); |
1017 | SCpnt->cmnd[2] = sizeof(block) > 4 ? (unsigned char) (block >> 56) & 0xff : 0; | 1017 | SCpnt->cmnd[2] = sizeof(block) > 4 ? (unsigned char) (block >> 56) & 0xff : 0; |
@@ -2203,6 +2203,8 @@ got_data: | |||
2203 | } | 2203 | } |
2204 | } | 2204 | } |
2205 | 2205 | ||
2206 | sdp->use_16_for_rw = (sdkp->capacity > 0xffffffff); | ||
2207 | |||
2206 | /* Rescale capacity to 512-byte units */ | 2208 | /* Rescale capacity to 512-byte units */ |
2207 | if (sector_size == 4096) | 2209 | if (sector_size == 4096) |
2208 | sdkp->capacity <<= 3; | 2210 | sdkp->capacity <<= 3; |