diff options
| author | Tejun Heo <htejun@gmail.com> | 2006-01-06 03:49:03 -0500 | 
|---|---|---|
| committer | Jens Axboe <axboe@suse.de> | 2006-01-06 03:49:03 -0500 | 
| commit | 8ffdc6550c47f75ca4e6c9f30a2a89063e035cf2 (patch) | |
| tree | a478b9acef5c66242a964154f7ad3a0ea750ef0f /drivers/scsi/sd.c | |
| parent | 64100099ed22f71cce656c5c2caecf5c9cf255dc (diff) | |
[BLOCK] add @uptodate to end_that_request_last() and @error to rq_end_io_fn()
add @uptodate argument to end_that_request_last() and @error
to rq_end_io_fn().  there's no generic way to pass error code
to request completion function, making generic error handling
of non-fs request difficult (rq->errors is driver-specific and
each driver uses it differently).  this patch adds @uptodate
to end_that_request_last() and @error to rq_end_io_fn().
for fs requests, this doesn't really matter, so just using the
same uptodate argument used in the last call to
end_that_request_first() should suffice.  imho, this can also
help the generic command-carrying request jens is working on.
Signed-off-by: tejun heo <htejun@gmail.com>
Signed-Off-By: Jens Axboe <axboe@suse.de>
Diffstat (limited to 'drivers/scsi/sd.c')
| -rw-r--r-- | drivers/scsi/sd.c | 2 | 
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3d3ad7d1b779..d651150ee76d 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c  | |||
| @@ -748,7 +748,7 @@ static void sd_end_flush(request_queue_t *q, struct request *flush_rq) | |||
| 748 | * force journal abort of barriers | 748 | * force journal abort of barriers | 
| 749 | */ | 749 | */ | 
| 750 | end_that_request_first(rq, -EOPNOTSUPP, rq->hard_nr_sectors); | 750 | end_that_request_first(rq, -EOPNOTSUPP, rq->hard_nr_sectors); | 
| 751 | end_that_request_last(rq); | 751 | end_that_request_last(rq, -EOPNOTSUPP); | 
| 752 | } | 752 | } | 
| 753 | } | 753 | } | 
| 754 | 754 | ||
