diff options
author | Tony Lindgren <tony@atomide.com> | 2010-03-01 17:19:05 -0500 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2010-03-01 17:19:05 -0500 |
commit | d702d12167a2c05a346f49aac7a311d597762495 (patch) | |
tree | baae42c299cce34d6df24b5d01f8b1d0b481bd9a /drivers/scsi/scsi_transport_fc.c | |
parent | 9418c65f9bd861d0f7e39aab9cfb3aa6f2275d11 (diff) | |
parent | ac0f6f927db539e03e1f3f61bcd4ed57d5cde7a9 (diff) |
Merge with mainline to remove plat-omap/Kconfig conflict
Conflicts:
arch/arm/plat-omap/Kconfig
Diffstat (limited to 'drivers/scsi/scsi_transport_fc.c')
-rw-r--r-- | drivers/scsi/scsi_transport_fc.c | 26 |
1 files changed, 21 insertions, 5 deletions
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index 653f22a8deb9..79660ee3e211 100644 --- a/drivers/scsi/scsi_transport_fc.c +++ b/drivers/scsi/scsi_transport_fc.c | |||
@@ -475,7 +475,8 @@ MODULE_PARM_DESC(dev_loss_tmo, | |||
475 | "Maximum number of seconds that the FC transport should" | 475 | "Maximum number of seconds that the FC transport should" |
476 | " insulate the loss of a remote port. Once this value is" | 476 | " insulate the loss of a remote port. Once this value is" |
477 | " exceeded, the scsi target is removed. Value should be" | 477 | " exceeded, the scsi target is removed. Value should be" |
478 | " between 1 and SCSI_DEVICE_BLOCK_MAX_TIMEOUT."); | 478 | " between 1 and SCSI_DEVICE_BLOCK_MAX_TIMEOUT if" |
479 | " fast_io_fail_tmo is not set."); | ||
479 | 480 | ||
480 | /* | 481 | /* |
481 | * Netlink Infrastructure | 482 | * Netlink Infrastructure |
@@ -842,9 +843,17 @@ store_fc_rport_dev_loss_tmo(struct device *dev, struct device_attribute *attr, | |||
842 | (rport->port_state == FC_PORTSTATE_NOTPRESENT)) | 843 | (rport->port_state == FC_PORTSTATE_NOTPRESENT)) |
843 | return -EBUSY; | 844 | return -EBUSY; |
844 | val = simple_strtoul(buf, &cp, 0); | 845 | val = simple_strtoul(buf, &cp, 0); |
845 | if ((*cp && (*cp != '\n')) || | 846 | if ((*cp && (*cp != '\n')) || (val < 0)) |
846 | (val < 0) || (val > SCSI_DEVICE_BLOCK_MAX_TIMEOUT)) | ||
847 | return -EINVAL; | 847 | return -EINVAL; |
848 | |||
849 | /* | ||
850 | * If fast_io_fail is off we have to cap | ||
851 | * dev_loss_tmo at SCSI_DEVICE_BLOCK_MAX_TIMEOUT | ||
852 | */ | ||
853 | if (rport->fast_io_fail_tmo == -1 && | ||
854 | val > SCSI_DEVICE_BLOCK_MAX_TIMEOUT) | ||
855 | return -EINVAL; | ||
856 | |||
848 | i->f->set_rport_dev_loss_tmo(rport, val); | 857 | i->f->set_rport_dev_loss_tmo(rport, val); |
849 | return count; | 858 | return count; |
850 | } | 859 | } |
@@ -925,9 +934,16 @@ store_fc_rport_fast_io_fail_tmo(struct device *dev, | |||
925 | rport->fast_io_fail_tmo = -1; | 934 | rport->fast_io_fail_tmo = -1; |
926 | else { | 935 | else { |
927 | val = simple_strtoul(buf, &cp, 0); | 936 | val = simple_strtoul(buf, &cp, 0); |
928 | if ((*cp && (*cp != '\n')) || | 937 | if ((*cp && (*cp != '\n')) || (val < 0)) |
929 | (val < 0) || (val >= rport->dev_loss_tmo)) | ||
930 | return -EINVAL; | 938 | return -EINVAL; |
939 | /* | ||
940 | * Cap fast_io_fail by dev_loss_tmo or | ||
941 | * SCSI_DEVICE_BLOCK_MAX_TIMEOUT. | ||
942 | */ | ||
943 | if ((val >= rport->dev_loss_tmo) || | ||
944 | (val > SCSI_DEVICE_BLOCK_MAX_TIMEOUT)) | ||
945 | return -EINVAL; | ||
946 | |||
931 | rport->fast_io_fail_tmo = val; | 947 | rport->fast_io_fail_tmo = val; |
932 | } | 948 | } |
933 | return count; | 949 | return count; |