diff options
author | Masatake YAMATO <jet@gyve.org> | 2007-09-19 09:59:16 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.localdomain> | 2007-10-12 14:49:11 -0400 |
commit | 10f4b89a0f0586a67f57efb2f5d12fffbb371490 (patch) | |
tree | 417073ad0e2a8ae5759bb6370960ff80931ad597 /drivers/scsi/scsi_scan.c | |
parent | 427d0bd4fde60f40e9518817d826e48c05262a98 (diff) |
[SCSI] Fix signness of parameters in scsi module
In scsi module I've found some inconsistency between variable type
used in module_param_named and type passed to module_param_named as an
argument. Especially the inconsistency of `max_scsi_luns' parameter is
a bit serious because the description text says "last scsi LUN (should
be between 1 and 2^32-1)".
Signed-off-by: Masatake YAMATO <jet@gyve.org>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/scsi_scan.c')
-rw-r--r-- | drivers/scsi/scsi_scan.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 309b2246d2d3..20df7fe4f48f 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c | |||
@@ -85,7 +85,7 @@ static unsigned int max_scsi_luns = MAX_SCSI_LUNS; | |||
85 | static unsigned int max_scsi_luns = 1; | 85 | static unsigned int max_scsi_luns = 1; |
86 | #endif | 86 | #endif |
87 | 87 | ||
88 | module_param_named(max_luns, max_scsi_luns, int, S_IRUGO|S_IWUSR); | 88 | module_param_named(max_luns, max_scsi_luns, uint, S_IRUGO|S_IWUSR); |
89 | MODULE_PARM_DESC(max_luns, | 89 | MODULE_PARM_DESC(max_luns, |
90 | "last scsi LUN (should be between 1 and 2^32-1)"); | 90 | "last scsi LUN (should be between 1 and 2^32-1)"); |
91 | 91 | ||
@@ -109,14 +109,14 @@ MODULE_PARM_DESC(scan, "sync, async or none"); | |||
109 | */ | 109 | */ |
110 | static unsigned int max_scsi_report_luns = 511; | 110 | static unsigned int max_scsi_report_luns = 511; |
111 | 111 | ||
112 | module_param_named(max_report_luns, max_scsi_report_luns, int, S_IRUGO|S_IWUSR); | 112 | module_param_named(max_report_luns, max_scsi_report_luns, uint, S_IRUGO|S_IWUSR); |
113 | MODULE_PARM_DESC(max_report_luns, | 113 | MODULE_PARM_DESC(max_report_luns, |
114 | "REPORT LUNS maximum number of LUNS received (should be" | 114 | "REPORT LUNS maximum number of LUNS received (should be" |
115 | " between 1 and 16384)"); | 115 | " between 1 and 16384)"); |
116 | 116 | ||
117 | static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+3; | 117 | static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ+3; |
118 | 118 | ||
119 | module_param_named(inq_timeout, scsi_inq_timeout, int, S_IRUGO|S_IWUSR); | 119 | module_param_named(inq_timeout, scsi_inq_timeout, uint, S_IRUGO|S_IWUSR); |
120 | MODULE_PARM_DESC(inq_timeout, | 120 | MODULE_PARM_DESC(inq_timeout, |
121 | "Timeout (in seconds) waiting for devices to answer INQUIRY." | 121 | "Timeout (in seconds) waiting for devices to answer INQUIRY." |
122 | " Default is 5. Some non-compliant devices need more."); | 122 | " Default is 5. Some non-compliant devices need more."); |