diff options
author | <htejun@gmail.com> | 2005-04-03 15:59:11 -0400 |
---|---|---|
committer | James Bottomley <jejb@titanic> | 2005-04-18 13:33:15 -0400 |
commit | c6295cdf656de63d6d1123def71daba6cd91939c (patch) | |
tree | c4e5d02355df7443afa45ecc491807a67962f0d8 /drivers/scsi/scsi_error.c | |
parent | d3a933dc9851e74581f9f4c8e703e77901ae8d01 (diff) |
[PATCH] scsi: remove meaningless scsi_cmnd->serial_number_at_timeout field
scsi_cmnd->serial_number_at_timeout doesn't serve any purpose
anymore. All serial_number == serial_number_at_timeout tests
are always true in abort callbacks. Kill the field. Also, as
->pid always equals ->serial_number and ->serial_number
doesn't have any special meaning anymore, update comments
above ->serial_number accordingly. Once we remove all uses of
this field from all lldd's, this field should go.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/scsi_error.c')
-rw-r--r-- | drivers/scsi/scsi_error.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 173abb88e3e8..13bac93fc397 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c | |||
@@ -79,11 +79,6 @@ int scsi_eh_scmd_add(struct scsi_cmnd *scmd, int eh_flag) | |||
79 | */ | 79 | */ |
80 | scmd->owner = SCSI_OWNER_ERROR_HANDLER; | 80 | scmd->owner = SCSI_OWNER_ERROR_HANDLER; |
81 | scmd->state = SCSI_STATE_FAILED; | 81 | scmd->state = SCSI_STATE_FAILED; |
82 | /* | ||
83 | * Set the serial_number_at_timeout to the current | ||
84 | * serial_number | ||
85 | */ | ||
86 | scmd->serial_number_at_timeout = scmd->serial_number; | ||
87 | list_add_tail(&scmd->eh_entry, &shost->eh_cmd_q); | 82 | list_add_tail(&scmd->eh_entry, &shost->eh_cmd_q); |
88 | set_bit(SHOST_RECOVERY, &shost->shost_state); | 83 | set_bit(SHOST_RECOVERY, &shost->shost_state); |
89 | shost->host_failed++; | 84 | shost->host_failed++; |
@@ -1061,7 +1056,6 @@ static int scsi_try_bus_reset(struct scsi_cmnd *scmd) | |||
1061 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s: Snd Bus RST\n", | 1056 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s: Snd Bus RST\n", |
1062 | __FUNCTION__)); | 1057 | __FUNCTION__)); |
1063 | scmd->owner = SCSI_OWNER_LOWLEVEL; | 1058 | scmd->owner = SCSI_OWNER_LOWLEVEL; |
1064 | scmd->serial_number_at_timeout = scmd->serial_number; | ||
1065 | 1059 | ||
1066 | if (!scmd->device->host->hostt->eh_bus_reset_handler) | 1060 | if (!scmd->device->host->hostt->eh_bus_reset_handler) |
1067 | return FAILED; | 1061 | return FAILED; |
@@ -1093,7 +1087,6 @@ static int scsi_try_host_reset(struct scsi_cmnd *scmd) | |||
1093 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s: Snd Host RST\n", | 1087 | SCSI_LOG_ERROR_RECOVERY(3, printk("%s: Snd Host RST\n", |
1094 | __FUNCTION__)); | 1088 | __FUNCTION__)); |
1095 | scmd->owner = SCSI_OWNER_LOWLEVEL; | 1089 | scmd->owner = SCSI_OWNER_LOWLEVEL; |
1096 | scmd->serial_number_at_timeout = scmd->serial_number; | ||
1097 | 1090 | ||
1098 | if (!scmd->device->host->hostt->eh_host_reset_handler) | 1091 | if (!scmd->device->host->hostt->eh_host_reset_handler) |
1099 | return FAILED; | 1092 | return FAILED; |