diff options
author | James Bottomley <James.Bottomley@steeleye.com> | 2005-10-02 12:45:08 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.(none)> | 2005-10-28 15:23:02 -0400 |
commit | 9ccfc756a70d454dfa82f48897e2883560c01a0e (patch) | |
tree | 9a6d3b10b1ec0e5fe7a63252a21598a03e93ad4e /drivers/scsi/scsi.c | |
parent | 9a41a62b74388827998253d62c58707e63cc5874 (diff) |
[SCSI] move the mid-layer printk's over to shost/starget/sdev_printk
This should eliminate (at least in the mid layer) to make numeric
assumptions about any of the enumeration variables. As a side effect,
it will also make all the messages consistent and line us up nicely for
the error logging strategy (if it ever shows itself again).
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/scsi.c')
-rw-r--r-- | drivers/scsi/scsi.c | 21 |
1 files changed, 8 insertions, 13 deletions
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index a5711d545d71..071d109b4b2a 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c | |||
@@ -410,9 +410,7 @@ void scsi_log_send(struct scsi_cmnd *cmd) | |||
410 | SCSI_LOG_MLQUEUE_BITS); | 410 | SCSI_LOG_MLQUEUE_BITS); |
411 | if (level > 1) { | 411 | if (level > 1) { |
412 | sdev = cmd->device; | 412 | sdev = cmd->device; |
413 | printk(KERN_INFO "scsi <%d:%d:%d:%d> send ", | 413 | sdev_printk(KERN_INFO, sdev, "send "); |
414 | sdev->host->host_no, sdev->channel, sdev->id, | ||
415 | sdev->lun); | ||
416 | if (level > 2) | 414 | if (level > 2) |
417 | printk("0x%p ", cmd); | 415 | printk("0x%p ", cmd); |
418 | /* | 416 | /* |
@@ -456,9 +454,7 @@ void scsi_log_completion(struct scsi_cmnd *cmd, int disposition) | |||
456 | if (((level > 0) && (cmd->result || disposition != SUCCESS)) || | 454 | if (((level > 0) && (cmd->result || disposition != SUCCESS)) || |
457 | (level > 1)) { | 455 | (level > 1)) { |
458 | sdev = cmd->device; | 456 | sdev = cmd->device; |
459 | printk(KERN_INFO "scsi <%d:%d:%d:%d> done ", | 457 | sdev_printk(KERN_INFO, sdev, "done "); |
460 | sdev->host->host_no, sdev->channel, sdev->id, | ||
461 | sdev->lun); | ||
462 | if (level > 2) | 458 | if (level > 2) |
463 | printk("0x%p ", cmd); | 459 | printk("0x%p ", cmd); |
464 | /* | 460 | /* |
@@ -810,9 +806,9 @@ static void scsi_softirq(struct softirq_action *h) | |||
810 | disposition = scsi_decide_disposition(cmd); | 806 | disposition = scsi_decide_disposition(cmd); |
811 | if (disposition != SUCCESS && | 807 | if (disposition != SUCCESS && |
812 | time_before(cmd->jiffies_at_alloc + wait_for, jiffies)) { | 808 | time_before(cmd->jiffies_at_alloc + wait_for, jiffies)) { |
813 | dev_printk(KERN_ERR, &cmd->device->sdev_gendev, | 809 | sdev_printk(KERN_ERR, cmd->device, |
814 | "timing out command, waited %lus\n", | 810 | "timing out command, waited %lus\n", |
815 | wait_for/HZ); | 811 | wait_for/HZ); |
816 | disposition = SUCCESS; | 812 | disposition = SUCCESS; |
817 | } | 813 | } |
818 | 814 | ||
@@ -970,10 +966,9 @@ void scsi_adjust_queue_depth(struct scsi_device *sdev, int tagged, int tags) | |||
970 | sdev->simple_tags = 1; | 966 | sdev->simple_tags = 1; |
971 | break; | 967 | break; |
972 | default: | 968 | default: |
973 | printk(KERN_WARNING "(scsi%d:%d:%d:%d) " | 969 | sdev_printk(KERN_WARNING, sdev, |
974 | "scsi_adjust_queue_depth, bad queue type, " | 970 | "scsi_adjust_queue_depth, bad queue type, " |
975 | "disabled\n", sdev->host->host_no, | 971 | "disabled\n"); |
976 | sdev->channel, sdev->id, sdev->lun); | ||
977 | case 0: | 972 | case 0: |
978 | sdev->ordered_tags = sdev->simple_tags = 0; | 973 | sdev->ordered_tags = sdev->simple_tags = 0; |
979 | sdev->queue_depth = tags; | 974 | sdev->queue_depth = tags; |