aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/sata_uli.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2006-06-16 02:00:18 -0400
committerJeff Garzik <jeff@garzik.org>2006-06-20 05:12:15 -0400
commitd7a80dad2fe19a2b8c119c8e9cba605474a75a2b (patch)
treeb32a32f95bc40f7fa4dbc1f127213aaa75e96ca9 /drivers/scsi/sata_uli.c
parent40ef1d8d48e364dce689342adfdc475aa53f4808 (diff)
[PATCH] libata: convert several bmdma-style controllers to new EH, take #3
Convert sata_sis, svw, uli and vsc drivers to new EH. All the drivers used to specify ATA_FLAG_SATA_RESET to tell libata to use SATA hardreset instead of SRST. This patch makes all the converted drivers use the standard bmdma error handler which uses both SRST and SATA hardreset. All the controllers should be able to perform SRST but still needs verification. If some of the controllers can't do SRST, it will be very easy to spot as it will show up during boot probing. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/scsi/sata_uli.c')
-rw-r--r--drivers/scsi/sata_uli.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/scsi/sata_uli.c b/drivers/scsi/sata_uli.c
index e69ba229adca..f668c997e9af 100644
--- a/drivers/scsi/sata_uli.c
+++ b/drivers/scsi/sata_uli.c
@@ -103,8 +103,6 @@ static const struct ata_port_operations uli_ops = {
103 .exec_command = ata_exec_command, 103 .exec_command = ata_exec_command,
104 .dev_select = ata_std_dev_select, 104 .dev_select = ata_std_dev_select,
105 105
106 .phy_reset = sata_phy_reset,
107
108 .bmdma_setup = ata_bmdma_setup, 106 .bmdma_setup = ata_bmdma_setup,
109 .bmdma_start = ata_bmdma_start, 107 .bmdma_start = ata_bmdma_start,
110 .bmdma_stop = ata_bmdma_stop, 108 .bmdma_stop = ata_bmdma_stop,
@@ -113,7 +111,10 @@ static const struct ata_port_operations uli_ops = {
113 .qc_issue = ata_qc_issue_prot, 111 .qc_issue = ata_qc_issue_prot,
114 .data_xfer = ata_pio_data_xfer, 112 .data_xfer = ata_pio_data_xfer,
115 113
116 .eng_timeout = ata_eng_timeout, 114 .freeze = ata_bmdma_freeze,
115 .thaw = ata_bmdma_thaw,
116 .error_handler = ata_bmdma_error_handler,
117 .post_internal_cmd = ata_bmdma_post_internal_cmd,
117 118
118 .irq_handler = ata_interrupt, 119 .irq_handler = ata_interrupt,
119 .irq_clear = ata_bmdma_irq_clear, 120 .irq_clear = ata_bmdma_irq_clear,
@@ -128,8 +129,7 @@ static const struct ata_port_operations uli_ops = {
128 129
129static struct ata_port_info uli_port_info = { 130static struct ata_port_info uli_port_info = {
130 .sht = &uli_sht, 131 .sht = &uli_sht,
131 .host_flags = ATA_FLAG_SATA | ATA_FLAG_SATA_RESET | 132 .host_flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY,
132 ATA_FLAG_NO_LEGACY,
133 .pio_mask = 0x1f, /* pio0-4 */ 133 .pio_mask = 0x1f, /* pio0-4 */
134 .udma_mask = 0x7f, /* udma0-6 */ 134 .udma_mask = 0x7f, /* udma0-6 */
135 .port_ops = &uli_ops, 135 .port_ops = &uli_ops,