diff options
author | Jeff Garzik <jgarzik@pobox.com> | 2006-01-27 02:39:25 -0500 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2006-01-27 02:39:25 -0500 |
commit | 7103c7bc863c10dd2a26c19c8cf4d7d2846da947 (patch) | |
tree | 73a9d674670c37e4f160c0d4553f3d14664900be /drivers/scsi/sata_mv.c | |
parent | b4d28889f7ebfe498dedaceb773b4c785b97d195 (diff) | |
parent | a72ec4ce6d3ae92e76baf5b2c65cc26e5e775e83 (diff) |
Merge branch 'tmp'
Diffstat (limited to 'drivers/scsi/sata_mv.c')
-rw-r--r-- | drivers/scsi/sata_mv.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c index 498d6284a2f7..0042c7840d80 100644 --- a/drivers/scsi/sata_mv.c +++ b/drivers/scsi/sata_mv.c | |||
@@ -1838,7 +1838,6 @@ static void mv_phy_reset(struct ata_port *ap) | |||
1838 | static void mv_eng_timeout(struct ata_port *ap) | 1838 | static void mv_eng_timeout(struct ata_port *ap) |
1839 | { | 1839 | { |
1840 | struct ata_queued_cmd *qc; | 1840 | struct ata_queued_cmd *qc; |
1841 | unsigned long flags; | ||
1842 | 1841 | ||
1843 | printk(KERN_ERR "ata%u: Entering mv_eng_timeout\n",ap->id); | 1842 | printk(KERN_ERR "ata%u: Entering mv_eng_timeout\n",ap->id); |
1844 | DPRINTK("All regs @ start of eng_timeout\n"); | 1843 | DPRINTK("All regs @ start of eng_timeout\n"); |
@@ -1857,17 +1856,8 @@ static void mv_eng_timeout(struct ata_port *ap) | |||
1857 | printk(KERN_ERR "ata%u: BUG: timeout without command\n", | 1856 | printk(KERN_ERR "ata%u: BUG: timeout without command\n", |
1858 | ap->id); | 1857 | ap->id); |
1859 | } else { | 1858 | } else { |
1860 | /* hack alert! We cannot use the supplied completion | ||
1861 | * function from inside the ->eh_strategy_handler() thread. | ||
1862 | * libata is the only user of ->eh_strategy_handler() in | ||
1863 | * any kernel, so the default scsi_done() assumes it is | ||
1864 | * not being called from the SCSI EH. | ||
1865 | */ | ||
1866 | spin_lock_irqsave(&ap->host_set->lock, flags); | ||
1867 | qc->scsidone = scsi_finish_command; | ||
1868 | qc->err_mask |= AC_ERR_TIMEOUT; | 1859 | qc->err_mask |= AC_ERR_TIMEOUT; |
1869 | ata_qc_complete(qc); | 1860 | ata_eh_qc_complete(qc); |
1870 | spin_unlock_irqrestore(&ap->host_set->lock, flags); | ||
1871 | } | 1861 | } |
1872 | } | 1862 | } |
1873 | 1863 | ||