diff options
author | Adrian Bunk <bunk@stusta.de> | 2007-04-26 03:35:16 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2007-05-06 10:33:16 -0400 |
commit | 4797547778fd51e6ee929c5dd67ab3807898eb82 (patch) | |
tree | d24af8ee2d5b4b7a819a31d443b7c02ba9b4d92b /drivers/scsi/qla4xxx/ql4_mbx.c | |
parent | 15061f23a134e1e92f430a1aeb37a73e4af2a2a9 (diff) |
[SCSI] qla4xxx: possible cleanups
- make needlessly global code static
- #if 0 unused functions
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Ravi Anand <ravi.anand@qlogic.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/qla4xxx/ql4_mbx.c')
-rw-r--r-- | drivers/scsi/qla4xxx/ql4_mbx.c | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index 7f28657eef3f..f116ff917237 100644 --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++ b/drivers/scsi/qla4xxx/ql4_mbx.c | |||
@@ -20,9 +20,9 @@ | |||
20 | * If outCount is 0, this routine completes successfully WITHOUT waiting | 20 | * If outCount is 0, this routine completes successfully WITHOUT waiting |
21 | * for the mailbox command to complete. | 21 | * for the mailbox command to complete. |
22 | **/ | 22 | **/ |
23 | int qla4xxx_mailbox_command(struct scsi_qla_host *ha, uint8_t inCount, | 23 | static int qla4xxx_mailbox_command(struct scsi_qla_host *ha, uint8_t inCount, |
24 | uint8_t outCount, uint32_t *mbx_cmd, | 24 | uint8_t outCount, uint32_t *mbx_cmd, |
25 | uint32_t *mbx_sts) | 25 | uint32_t *mbx_sts) |
26 | { | 26 | { |
27 | int status = QLA_ERROR; | 27 | int status = QLA_ERROR; |
28 | uint8_t i; | 28 | uint8_t i; |
@@ -170,6 +170,8 @@ mbox_exit: | |||
170 | } | 170 | } |
171 | 171 | ||
172 | 172 | ||
173 | #if 0 | ||
174 | |||
173 | /** | 175 | /** |
174 | * qla4xxx_issue_iocb - issue mailbox iocb command | 176 | * qla4xxx_issue_iocb - issue mailbox iocb command |
175 | * @ha: adapter state pointer. | 177 | * @ha: adapter state pointer. |
@@ -243,6 +245,8 @@ int qla4xxx_clear_database_entry(struct scsi_qla_host * ha, | |||
243 | return QLA_SUCCESS; | 245 | return QLA_SUCCESS; |
244 | } | 246 | } |
245 | 247 | ||
248 | #endif /* 0 */ | ||
249 | |||
246 | /** | 250 | /** |
247 | * qla4xxx_initialize_fw_cb - initializes firmware control block. | 251 | * qla4xxx_initialize_fw_cb - initializes firmware control block. |
248 | * @ha: Pointer to host adapter structure. | 252 | * @ha: Pointer to host adapter structure. |
@@ -570,6 +574,7 @@ int qla4xxx_set_ddb_entry(struct scsi_qla_host * ha, uint16_t fw_ddb_index, | |||
570 | return qla4xxx_mailbox_command(ha, 4, 1, &mbox_cmd[0], &mbox_sts[0]); | 574 | return qla4xxx_mailbox_command(ha, 4, 1, &mbox_cmd[0], &mbox_sts[0]); |
571 | } | 575 | } |
572 | 576 | ||
577 | #if 0 | ||
573 | int qla4xxx_conn_open_session_login(struct scsi_qla_host * ha, | 578 | int qla4xxx_conn_open_session_login(struct scsi_qla_host * ha, |
574 | uint16_t fw_ddb_index) | 579 | uint16_t fw_ddb_index) |
575 | { | 580 | { |
@@ -594,6 +599,7 @@ int qla4xxx_conn_open_session_login(struct scsi_qla_host * ha, | |||
594 | 599 | ||
595 | return status; | 600 | return status; |
596 | } | 601 | } |
602 | #endif /* 0 */ | ||
597 | 603 | ||
598 | /** | 604 | /** |
599 | * qla4xxx_get_crash_record - retrieves crash record. | 605 | * qla4xxx_get_crash_record - retrieves crash record. |
@@ -649,6 +655,7 @@ exit_get_crash_record: | |||
649 | crash_record, crash_record_dma); | 655 | crash_record, crash_record_dma); |
650 | } | 656 | } |
651 | 657 | ||
658 | #if 0 | ||
652 | /** | 659 | /** |
653 | * qla4xxx_get_conn_event_log - retrieves connection event log | 660 | * qla4xxx_get_conn_event_log - retrieves connection event log |
654 | * @ha: Pointer to host adapter structure. | 661 | * @ha: Pointer to host adapter structure. |
@@ -738,6 +745,7 @@ exit_get_event_log: | |||
738 | dma_free_coherent(&ha->pdev->dev, event_log_size, event_log, | 745 | dma_free_coherent(&ha->pdev->dev, event_log_size, event_log, |
739 | event_log_dma); | 746 | event_log_dma); |
740 | } | 747 | } |
748 | #endif /* 0 */ | ||
741 | 749 | ||
742 | /** | 750 | /** |
743 | * qla4xxx_reset_lun - issues LUN Reset | 751 | * qla4xxx_reset_lun - issues LUN Reset |
@@ -834,7 +842,8 @@ int qla4xxx_get_fw_version(struct scsi_qla_host * ha) | |||
834 | return QLA_SUCCESS; | 842 | return QLA_SUCCESS; |
835 | } | 843 | } |
836 | 844 | ||
837 | int qla4xxx_get_default_ddb(struct scsi_qla_host *ha, dma_addr_t dma_addr) | 845 | static int qla4xxx_get_default_ddb(struct scsi_qla_host *ha, |
846 | dma_addr_t dma_addr) | ||
838 | { | 847 | { |
839 | uint32_t mbox_cmd[MBOX_REG_COUNT]; | 848 | uint32_t mbox_cmd[MBOX_REG_COUNT]; |
840 | uint32_t mbox_sts[MBOX_REG_COUNT]; | 849 | uint32_t mbox_sts[MBOX_REG_COUNT]; |
@@ -855,7 +864,7 @@ int qla4xxx_get_default_ddb(struct scsi_qla_host *ha, dma_addr_t dma_addr) | |||
855 | return QLA_SUCCESS; | 864 | return QLA_SUCCESS; |
856 | } | 865 | } |
857 | 866 | ||
858 | int qla4xxx_req_ddb_entry(struct scsi_qla_host *ha, uint32_t *ddb_index) | 867 | static int qla4xxx_req_ddb_entry(struct scsi_qla_host *ha, uint32_t *ddb_index) |
859 | { | 868 | { |
860 | uint32_t mbox_cmd[MBOX_REG_COUNT]; | 869 | uint32_t mbox_cmd[MBOX_REG_COUNT]; |
861 | uint32_t mbox_sts[MBOX_REG_COUNT]; | 870 | uint32_t mbox_sts[MBOX_REG_COUNT]; |