diff options
author | Frederik Deweerdt <deweerdt@free.fr> | 2006-10-05 16:49:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-05 18:49:02 -0400 |
commit | d7a297baa6edea94167163bed808c6a8933bd5aa (patch) | |
tree | b703dc50266304765eaa14753a5ba4616d340199 /drivers/scsi/qla2xxx | |
parent | d223a60106891bfe46febfacf46b20cd8509aaad (diff) |
[PATCH] fix qla{2,4} build error
commit 0181944fe647cae18d545ac1167df3d15d393701 adds a
'extended_error_logging' global variable to qla2xxx which is defined by
qla4xxx too.
Trying to build both drivers results in the following error:
LD drivers/scsi/built-in.o
drivers/scsi/qla4xxx/built-in.o: In function `qla4xxx_slave_configure':
drivers/scsi/qla4xxx/ql4_os.c:1433: multiple definition of `extended_error_logging'
drivers/scsi/qla2xxx/built-in.o:drivers/scsi/qla2xxx/qla_os.c:2166:
first defined here
make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2
The following patch simply adds a qla2_ (qla4_ respectively) prefix to
the variable name.
Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/scsi/qla2xxx')
-rw-r--r-- | drivers/scsi/qla2xxx/qla_dbg.h | 14 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_gbl.h | 2 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_init.c | 2 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_os.c | 8 |
4 files changed, 13 insertions, 13 deletions
diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h index 533425338e05..90dad7e88985 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.h +++ b/drivers/scsi/qla2xxx/qla_dbg.h | |||
@@ -38,7 +38,7 @@ | |||
38 | * Macros use for debugging the driver. | 38 | * Macros use for debugging the driver. |
39 | */ | 39 | */ |
40 | 40 | ||
41 | #define DEBUG(x) do { if (extended_error_logging) { x; } } while (0) | 41 | #define DEBUG(x) do { if (qla2_extended_error_logging) { x; } } while (0) |
42 | 42 | ||
43 | #if defined(QL_DEBUG_LEVEL_1) | 43 | #if defined(QL_DEBUG_LEVEL_1) |
44 | #define DEBUG1(x) do {x;} while (0) | 44 | #define DEBUG1(x) do {x;} while (0) |
@@ -46,12 +46,12 @@ | |||
46 | #define DEBUG1(x) do {} while (0) | 46 | #define DEBUG1(x) do {} while (0) |
47 | #endif | 47 | #endif |
48 | 48 | ||
49 | #define DEBUG2(x) do { if (extended_error_logging) { x; } } while (0) | 49 | #define DEBUG2(x) do { if (qla2_extended_error_logging) { x; } } while (0) |
50 | #define DEBUG2_3(x) do { if (extended_error_logging) { x; } } while (0) | 50 | #define DEBUG2_3(x) do { if (qla2_extended_error_logging) { x; } } while (0) |
51 | #define DEBUG2_3_11(x) do { if (extended_error_logging) { x; } } while (0) | 51 | #define DEBUG2_3_11(x) do { if (qla2_extended_error_logging) { x; } } while (0) |
52 | #define DEBUG2_9_10(x) do { if (extended_error_logging) { x; } } while (0) | 52 | #define DEBUG2_9_10(x) do { if (qla2_extended_error_logging) { x; } } while (0) |
53 | #define DEBUG2_11(x) do { if (extended_error_logging) { x; } } while (0) | 53 | #define DEBUG2_11(x) do { if (qla2_extended_error_logging) { x; } } while (0) |
54 | #define DEBUG2_13(x) do { if (extended_error_logging) { x; } } while (0) | 54 | #define DEBUG2_13(x) do { if (qla2_extended_error_logging) { x; } } while (0) |
55 | 55 | ||
56 | #if defined(QL_DEBUG_LEVEL_3) | 56 | #if defined(QL_DEBUG_LEVEL_3) |
57 | #define DEBUG3(x) do {x;} while (0) | 57 | #define DEBUG3(x) do {x;} while (0) |
diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h index bef7011378c6..990b897560cc 100644 --- a/drivers/scsi/qla2xxx/qla_gbl.h +++ b/drivers/scsi/qla2xxx/qla_gbl.h | |||
@@ -60,7 +60,7 @@ extern int ql2xplogiabsentdevice; | |||
60 | extern int ql2xloginretrycount; | 60 | extern int ql2xloginretrycount; |
61 | extern int ql2xfdmienable; | 61 | extern int ql2xfdmienable; |
62 | extern int ql2xallocfwdump; | 62 | extern int ql2xallocfwdump; |
63 | extern int extended_error_logging; | 63 | extern int qla2_extended_error_logging; |
64 | 64 | ||
65 | extern void qla2x00_sp_compl(scsi_qla_host_t *, srb_t *); | 65 | extern void qla2x00_sp_compl(scsi_qla_host_t *, srb_t *); |
66 | 66 | ||
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index d5d26273c04e..833b93085fd3 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c | |||
@@ -1644,7 +1644,7 @@ qla2x00_nvram_config(scsi_qla_host_t *ha) | |||
1644 | * Set host adapter parameters. | 1644 | * Set host adapter parameters. |
1645 | */ | 1645 | */ |
1646 | if (nv->host_p[0] & BIT_7) | 1646 | if (nv->host_p[0] & BIT_7) |
1647 | extended_error_logging = 1; | 1647 | qla2_extended_error_logging = 1; |
1648 | ha->flags.disable_risc_code_load = ((nv->host_p[0] & BIT_4) ? 1 : 0); | 1648 | ha->flags.disable_risc_code_load = ((nv->host_p[0] & BIT_4) ? 1 : 0); |
1649 | /* Always load RISC code on non ISP2[12]00 chips. */ | 1649 | /* Always load RISC code on non ISP2[12]00 chips. */ |
1650 | if (!IS_QLA2100(ha) && !IS_QLA2200(ha)) | 1650 | if (!IS_QLA2100(ha) && !IS_QLA2200(ha)) |
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 3ba8c239f171..3f20d765563e 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c | |||
@@ -61,9 +61,9 @@ MODULE_PARM_DESC(ql2xallocfwdump, | |||
61 | "during HBA initialization. Memory allocation requirements " | 61 | "during HBA initialization. Memory allocation requirements " |
62 | "vary by ISP type. Default is 1 - allocate memory."); | 62 | "vary by ISP type. Default is 1 - allocate memory."); |
63 | 63 | ||
64 | int extended_error_logging; | 64 | int qla2_extended_error_logging; |
65 | module_param(extended_error_logging, int, S_IRUGO|S_IRUSR); | 65 | module_param(qla2_extended_error_logging, int, S_IRUGO|S_IRUSR); |
66 | MODULE_PARM_DESC(extended_error_logging, | 66 | MODULE_PARM_DESC(qla2_extended_error_logging, |
67 | "Option to enable extended error logging, " | 67 | "Option to enable extended error logging, " |
68 | "Default is 0 - no logging. 1 - log errors."); | 68 | "Default is 0 - no logging. 1 - log errors."); |
69 | 69 | ||
@@ -2697,7 +2697,7 @@ qla2x00_module_init(void) | |||
2697 | 2697 | ||
2698 | /* Derive version string. */ | 2698 | /* Derive version string. */ |
2699 | strcpy(qla2x00_version_str, QLA2XXX_VERSION); | 2699 | strcpy(qla2x00_version_str, QLA2XXX_VERSION); |
2700 | if (extended_error_logging) | 2700 | if (qla2_extended_error_logging) |
2701 | strcat(qla2x00_version_str, "-debug"); | 2701 | strcat(qla2x00_version_str, "-debug"); |
2702 | 2702 | ||
2703 | qla2xxx_transport_template = | 2703 | qla2xxx_transport_template = |