aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/qla2xxx/qla_isr.c
diff options
context:
space:
mode:
authorGiridhar Malavali <giridhar.malavali@qlogic.com>2009-03-24 12:08:13 -0400
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2009-04-03 10:22:51 -0400
commitd1b1bef4c9e67aa550e602a6a7f93bbb47dff0b8 (patch)
treeba34b0f43f1153c313acb3d1fe4c9610219f101e /drivers/scsi/qla2xxx/qla_isr.c
parentad0ecd61f4ad3260ca8f7216765ddbb1a10677ea (diff)
[SCSI] qla2xxx: Drop use of IRQF_DISABLE.
When IRQs are shared by multiple controllers and if the first one to register does not disable the IRQ, then IRQ will be enabled for all other controllers by default, irrespective of their setting. With IRQF_DISABLED registration, the driver interrupt routine was called with interrupt enabled always. Disbaling the registration with IRQF_DISABLED, since driver code is re-entrant safe and all critical sections are guarded with interrupt safe locks. Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com> Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_isr.c')
-rw-r--r--drivers/scsi/qla2xxx/qla_isr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 0f03812861b3..d04981848e56 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2018,7 +2018,7 @@ skip_msix:
2018skip_msi: 2018skip_msi:
2019 2019
2020 ret = request_irq(ha->pdev->irq, ha->isp_ops->intr_handler, 2020 ret = request_irq(ha->pdev->irq, ha->isp_ops->intr_handler,
2021 IRQF_DISABLED|IRQF_SHARED, QLA2XXX_DRIVER_NAME, rsp); 2021 IRQF_SHARED, QLA2XXX_DRIVER_NAME, rsp);
2022 if (ret) { 2022 if (ret) {
2023 qla_printk(KERN_WARNING, ha, 2023 qla_printk(KERN_WARNING, ha,
2024 "Failed to reserve interrupt %d already in use.\n", 2024 "Failed to reserve interrupt %d already in use.\n",