diff options
author | Dan Carpenter <error27@gmail.com> | 2010-12-21 19:00:15 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-12-23 16:43:32 -0500 |
commit | 8ae598d02517af967685a671303c4ed10cded3c4 (patch) | |
tree | c901f3fd8e750c590a944f91fae27f844802954f /drivers/scsi/qla2xxx/qla_init.c | |
parent | 579d12b58abb4bd1161728f0a4a2524258ecf0a3 (diff) |
[SCSI] qla2xxx: list cursors are not null
This is just a cleanup.
The unneeded NULL check annoys static checkers because we already
derefenced it and the we check it and then (if it's not the _safe()
version) we dereference it again without checking. And the static
checker is all, "Wah? Is it null or not?"
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Madhuranath Iyengar <Madhu.Iyengar@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_init.c')
-rw-r--r-- | drivers/scsi/qla2xxx/qla_init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 6f7cf3970383..e9b800e72559 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c | |||
@@ -3888,7 +3888,7 @@ qla2x00_update_fcports(scsi_qla_host_t *base_vha) | |||
3888 | list_for_each_entry(vha, &base_vha->hw->vp_list, list) { | 3888 | list_for_each_entry(vha, &base_vha->hw->vp_list, list) { |
3889 | atomic_inc(&vha->vref_count); | 3889 | atomic_inc(&vha->vref_count); |
3890 | list_for_each_entry(fcport, &vha->vp_fcports, list) { | 3890 | list_for_each_entry(fcport, &vha->vp_fcports, list) { |
3891 | if (fcport && fcport->drport && | 3891 | if (fcport->drport && |
3892 | atomic_read(&fcport->state) != FCS_UNCONFIGURED) { | 3892 | atomic_read(&fcport->state) != FCS_UNCONFIGURED) { |
3893 | spin_unlock_irqrestore(&ha->vport_slock, flags); | 3893 | spin_unlock_irqrestore(&ha->vport_slock, flags); |
3894 | 3894 | ||