aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/qla2xxx/qla_init.c
diff options
context:
space:
mode:
authorAndrew Vasquez <andrew.vasquez@qlogic.com>2008-01-17 12:02:18 -0500
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2008-01-23 12:29:32 -0500
commitfc44765f5a232d451fa58a04606b254ac257b429 (patch)
tree2c536cbd8780f850b2ae6f5e64fc3bb2d9dea0b7 /drivers/scsi/qla2xxx/qla_init.c
parentdf613b96077cee826b14089ae6e75eeabf71faa3 (diff)
[SCSI] qla2xxx: Correct late-memset() of EFT buffer.
Original code would clear the buffer after the firmware had already been initialized to use the buffer, thus potentially and inadvertantly clearing data previously DMA'd by the firmware. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_init.c')
-rw-r--r--drivers/scsi/qla2xxx/qla_init.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index cacfd2509387..7637fa7546b5 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -766,6 +766,7 @@ qla2x00_alloc_fw_dump(scsi_qla_host_t *ha)
766 goto cont_alloc; 766 goto cont_alloc;
767 } 767 }
768 768
769 memset(tc, 0, EFT_SIZE);
769 rval = qla2x00_enable_eft_trace(ha, tc_dma, EFT_NUM_BUFFERS); 770 rval = qla2x00_enable_eft_trace(ha, tc_dma, EFT_NUM_BUFFERS);
770 if (rval) { 771 if (rval) {
771 qla_printk(KERN_WARNING, ha, "Unable to initialize " 772 qla_printk(KERN_WARNING, ha, "Unable to initialize "
@@ -779,7 +780,6 @@ qla2x00_alloc_fw_dump(scsi_qla_host_t *ha)
779 EFT_SIZE / 1024); 780 EFT_SIZE / 1024);
780 781
781 eft_size = EFT_SIZE; 782 eft_size = EFT_SIZE;
782 memset(tc, 0, eft_size);
783 ha->eft_dma = tc_dma; 783 ha->eft_dma = tc_dma;
784 ha->eft = tc; 784 ha->eft = tc;
785 785