diff options
author | Joe Perches <joe@perches.ccom> | 2011-11-18 12:03:05 -0500 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2011-12-15 01:55:01 -0500 |
commit | 086b3e8a399ecd089534280597cfba45b2b55887 (patch) | |
tree | b765a9cb01a156e3cd93d40f0e79ab60b02b343e /drivers/scsi/qla2xxx/qla_dbg.h | |
parent | 98cdfb4347f5d38b97de2045d688e44e2a26ea42 (diff) |
[SCSI] qla2xxx: Use less stack to emit logging messages.
Return early when logging level too low.
Use normal kernel codeing style for function braces.
Add const where appropriate to logging functions.
Remove now unused #define QL_DBG_BUF_LEN.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_dbg.h')
-rw-r--r-- | drivers/scsi/qla2xxx/qla_dbg.h | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h index 98a377b99017..06928141cf64 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.h +++ b/drivers/scsi/qla2xxx/qla_dbg.h | |||
@@ -245,14 +245,14 @@ struct qla2xxx_fw_dump { | |||
245 | extern int ql_errlev; | 245 | extern int ql_errlev; |
246 | 246 | ||
247 | void | 247 | void |
248 | ql_dbg(uint32_t, scsi_qla_host_t *vha, int32_t, char *, ...); | 248 | ql_dbg(uint32_t, scsi_qla_host_t *vha, int32_t, const char *fmt, ...); |
249 | void | 249 | void |
250 | ql_dbg_pci(uint32_t, struct pci_dev *pdev, int32_t, char *, ...); | 250 | ql_dbg_pci(uint32_t, struct pci_dev *pdev, int32_t, const char *fmt, ...); |
251 | 251 | ||
252 | void | 252 | void |
253 | ql_log(uint32_t, scsi_qla_host_t *vha, int32_t, char *, ...); | 253 | ql_log(uint32_t, scsi_qla_host_t *vha, int32_t, const char *fmt, ...); |
254 | void | 254 | void |
255 | ql_log_pci(uint32_t, struct pci_dev *pdev, int32_t, char *, ...); | 255 | ql_log_pci(uint32_t, struct pci_dev *pdev, int32_t, const char *fmt, ...); |
256 | 256 | ||
257 | /* Debug Levels */ | 257 | /* Debug Levels */ |
258 | /* The 0x40000000 is the max value any debug level can have | 258 | /* The 0x40000000 is the max value any debug level can have |
@@ -275,5 +275,3 @@ ql_log_pci(uint32_t, struct pci_dev *pdev, int32_t, char *, ...); | |||
275 | #define ql_dbg_misc 0x00010000 /* For dumping everything that is not | 275 | #define ql_dbg_misc 0x00010000 /* For dumping everything that is not |
276 | * not covered by upper categories | 276 | * not covered by upper categories |
277 | */ | 277 | */ |
278 | |||
279 | #define QL_DBG_BUF_LEN 512 | ||