diff options
author | James Bottomley <James.Bottomley@suse.de> | 2010-07-27 16:51:13 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-07-28 10:07:49 -0400 |
commit | df64d3caab8db6ae17dacd229a03d7689a10c432 (patch) | |
tree | 247fe4f9f39b22186e42e7f4687dd62c2690e47b /drivers/scsi/pm8001 | |
parent | 653c42d552d0fd0b05485442aed45dd2d62269c0 (diff) |
[SCSI] Unify SAM_ and SAM_STAT_ macros
We have two separate definitions for identical constants with nearly the
same name. One comes from the generic headers in scsi.h; the other is
an enum in libsas.h ... it's causing confusion about which one is
correct (fortunately they both are).
Fix this by eliminating the libsas.h duplicate
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/pm8001')
-rw-r--r-- | drivers/scsi/pm8001/pm8001_hwi.c | 14 | ||||
-rw-r--r-- | drivers/scsi/pm8001/pm8001_sas.c | 4 |
2 files changed, 9 insertions, 9 deletions
diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index 5ff8261c5d67..356ad268de6d 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c | |||
@@ -1480,7 +1480,7 @@ mpi_ssp_completion(struct pm8001_hba_info *pm8001_ha , void *piomb) | |||
1480 | ",param = %d \n", param)); | 1480 | ",param = %d \n", param)); |
1481 | if (param == 0) { | 1481 | if (param == 0) { |
1482 | ts->resp = SAS_TASK_COMPLETE; | 1482 | ts->resp = SAS_TASK_COMPLETE; |
1483 | ts->stat = SAM_GOOD; | 1483 | ts->stat = SAM_STAT_GOOD; |
1484 | } else { | 1484 | } else { |
1485 | ts->resp = SAS_TASK_COMPLETE; | 1485 | ts->resp = SAS_TASK_COMPLETE; |
1486 | ts->stat = SAS_PROTO_RESPONSE; | 1486 | ts->stat = SAS_PROTO_RESPONSE; |
@@ -1909,7 +1909,7 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) | |||
1909 | PM8001_IO_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS\n")); | 1909 | PM8001_IO_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS\n")); |
1910 | if (param == 0) { | 1910 | if (param == 0) { |
1911 | ts->resp = SAS_TASK_COMPLETE; | 1911 | ts->resp = SAS_TASK_COMPLETE; |
1912 | ts->stat = SAM_GOOD; | 1912 | ts->stat = SAM_STAT_GOOD; |
1913 | } else { | 1913 | } else { |
1914 | u8 len; | 1914 | u8 len; |
1915 | ts->resp = SAS_TASK_COMPLETE; | 1915 | ts->resp = SAS_TASK_COMPLETE; |
@@ -2450,7 +2450,7 @@ mpi_smp_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) | |||
2450 | case IO_SUCCESS: | 2450 | case IO_SUCCESS: |
2451 | PM8001_IO_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS\n")); | 2451 | PM8001_IO_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS\n")); |
2452 | ts->resp = SAS_TASK_COMPLETE; | 2452 | ts->resp = SAS_TASK_COMPLETE; |
2453 | ts->stat = SAM_GOOD; | 2453 | ts->stat = SAM_STAT_GOOD; |
2454 | if (pm8001_dev) | 2454 | if (pm8001_dev) |
2455 | pm8001_dev->running_req--; | 2455 | pm8001_dev->running_req--; |
2456 | break; | 2456 | break; |
@@ -2479,19 +2479,19 @@ mpi_smp_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) | |||
2479 | PM8001_IO_DBG(pm8001_ha, | 2479 | PM8001_IO_DBG(pm8001_ha, |
2480 | pm8001_printk("IO_ERROR_HW_TIMEOUT\n")); | 2480 | pm8001_printk("IO_ERROR_HW_TIMEOUT\n")); |
2481 | ts->resp = SAS_TASK_COMPLETE; | 2481 | ts->resp = SAS_TASK_COMPLETE; |
2482 | ts->stat = SAM_BUSY; | 2482 | ts->stat = SAM_STAT_BUSY; |
2483 | break; | 2483 | break; |
2484 | case IO_XFER_ERROR_BREAK: | 2484 | case IO_XFER_ERROR_BREAK: |
2485 | PM8001_IO_DBG(pm8001_ha, | 2485 | PM8001_IO_DBG(pm8001_ha, |
2486 | pm8001_printk("IO_XFER_ERROR_BREAK\n")); | 2486 | pm8001_printk("IO_XFER_ERROR_BREAK\n")); |
2487 | ts->resp = SAS_TASK_COMPLETE; | 2487 | ts->resp = SAS_TASK_COMPLETE; |
2488 | ts->stat = SAM_BUSY; | 2488 | ts->stat = SAM_STAT_BUSY; |
2489 | break; | 2489 | break; |
2490 | case IO_XFER_ERROR_PHY_NOT_READY: | 2490 | case IO_XFER_ERROR_PHY_NOT_READY: |
2491 | PM8001_IO_DBG(pm8001_ha, | 2491 | PM8001_IO_DBG(pm8001_ha, |
2492 | pm8001_printk("IO_XFER_ERROR_PHY_NOT_READY\n")); | 2492 | pm8001_printk("IO_XFER_ERROR_PHY_NOT_READY\n")); |
2493 | ts->resp = SAS_TASK_COMPLETE; | 2493 | ts->resp = SAS_TASK_COMPLETE; |
2494 | ts->stat = SAM_BUSY; | 2494 | ts->stat = SAM_STAT_BUSY; |
2495 | break; | 2495 | break; |
2496 | case IO_OPEN_CNX_ERROR_PROTOCOL_NOT_SUPPORTED: | 2496 | case IO_OPEN_CNX_ERROR_PROTOCOL_NOT_SUPPORTED: |
2497 | PM8001_IO_DBG(pm8001_ha, | 2497 | PM8001_IO_DBG(pm8001_ha, |
@@ -3260,7 +3260,7 @@ mpi_task_abort_resp(struct pm8001_hba_info *pm8001_ha, void *piomb) | |||
3260 | case IO_SUCCESS: | 3260 | case IO_SUCCESS: |
3261 | PM8001_EH_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS\n")); | 3261 | PM8001_EH_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS\n")); |
3262 | ts->resp = SAS_TASK_COMPLETE; | 3262 | ts->resp = SAS_TASK_COMPLETE; |
3263 | ts->stat = SAM_GOOD; | 3263 | ts->stat = SAM_STAT_GOOD; |
3264 | break; | 3264 | break; |
3265 | case IO_NOT_VALID: | 3265 | case IO_NOT_VALID: |
3266 | PM8001_EH_DBG(pm8001_ha, pm8001_printk("IO_NOT_VALID\n")); | 3266 | PM8001_EH_DBG(pm8001_ha, pm8001_printk("IO_NOT_VALID\n")); |
diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index cd02ceaf67ff..6ae059ebb4bb 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c | |||
@@ -763,7 +763,7 @@ static int pm8001_exec_internal_tmf_task(struct domain_device *dev, | |||
763 | } | 763 | } |
764 | 764 | ||
765 | if (task->task_status.resp == SAS_TASK_COMPLETE && | 765 | if (task->task_status.resp == SAS_TASK_COMPLETE && |
766 | task->task_status.stat == SAM_GOOD) { | 766 | task->task_status.stat == SAM_STAT_GOOD) { |
767 | res = TMF_RESP_FUNC_COMPLETE; | 767 | res = TMF_RESP_FUNC_COMPLETE; |
768 | break; | 768 | break; |
769 | } | 769 | } |
@@ -853,7 +853,7 @@ pm8001_exec_internal_task_abort(struct pm8001_hba_info *pm8001_ha, | |||
853 | } | 853 | } |
854 | 854 | ||
855 | if (task->task_status.resp == SAS_TASK_COMPLETE && | 855 | if (task->task_status.resp == SAS_TASK_COMPLETE && |
856 | task->task_status.stat == SAM_GOOD) { | 856 | task->task_status.stat == SAM_STAT_GOOD) { |
857 | res = TMF_RESP_FUNC_COMPLETE; | 857 | res = TMF_RESP_FUNC_COMPLETE; |
858 | break; | 858 | break; |
859 | 859 | ||