diff options
author | Jeff Garzik <jgarzik@pobox.com> | 2005-05-28 07:52:51 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2005-06-17 13:04:45 -0400 |
commit | 3471c288036bf0835a82d0b1bbce2002f6e68390 (patch) | |
tree | 9a646a16877b7c600c583a32f703dd02a621c603 /drivers/scsi/pcmcia | |
parent | e3df715501be3329986e5d9dfa9a477f49e7996b (diff) |
[SCSI] Remove no-op implementations of SCSI EH hooks
Drivers need not implement a hook that returns FAILED, and does nothing
else, since the SCSI midlayer code will do that for us.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/pcmcia')
-rw-r--r-- | drivers/scsi/pcmcia/nsp_cs.c | 15 | ||||
-rw-r--r-- | drivers/scsi/pcmcia/qlogic_stub.c | 2 |
2 files changed, 0 insertions, 17 deletions
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index 496c412c8854..3dddb323e718 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c | |||
@@ -92,9 +92,7 @@ static Scsi_Host_Template nsp_driver_template = { | |||
92 | #endif | 92 | #endif |
93 | .info = nsp_info, | 93 | .info = nsp_info, |
94 | .queuecommand = nsp_queuecommand, | 94 | .queuecommand = nsp_queuecommand, |
95 | /* .eh_strategy_handler = nsp_eh_strategy,*/ | ||
96 | /* .eh_abort_handler = nsp_eh_abort,*/ | 95 | /* .eh_abort_handler = nsp_eh_abort,*/ |
97 | /* .eh_device_reset_handler = nsp_eh_device_reset,*/ | ||
98 | .eh_bus_reset_handler = nsp_eh_bus_reset, | 96 | .eh_bus_reset_handler = nsp_eh_bus_reset, |
99 | .eh_host_reset_handler = nsp_eh_host_reset, | 97 | .eh_host_reset_handler = nsp_eh_host_reset, |
100 | .can_queue = 1, | 98 | .can_queue = 1, |
@@ -1536,11 +1534,6 @@ nsp_proc_info( | |||
1536 | /* error handler */ | 1534 | /* error handler */ |
1537 | /*---------------------------------------------------------------*/ | 1535 | /*---------------------------------------------------------------*/ |
1538 | 1536 | ||
1539 | /*static int nsp_eh_strategy(struct Scsi_Host *Shost) | ||
1540 | { | ||
1541 | return FAILED; | ||
1542 | }*/ | ||
1543 | |||
1544 | /* | 1537 | /* |
1545 | static int nsp_eh_abort(Scsi_Cmnd *SCpnt) | 1538 | static int nsp_eh_abort(Scsi_Cmnd *SCpnt) |
1546 | { | 1539 | { |
@@ -1549,14 +1542,6 @@ static int nsp_eh_abort(Scsi_Cmnd *SCpnt) | |||
1549 | return nsp_eh_bus_reset(SCpnt); | 1542 | return nsp_eh_bus_reset(SCpnt); |
1550 | }*/ | 1543 | }*/ |
1551 | 1544 | ||
1552 | /* | ||
1553 | static int nsp_eh_device_reset(Scsi_Cmnd *SCpnt) | ||
1554 | { | ||
1555 | nsp_dbg(NSP_DEBUG_BUSRESET, "%s: SCpnt=0x%p", SCpnt); | ||
1556 | |||
1557 | return FAILED; | ||
1558 | }*/ | ||
1559 | |||
1560 | static int nsp_bus_reset(nsp_hw_data *data) | 1545 | static int nsp_bus_reset(nsp_hw_data *data) |
1561 | { | 1546 | { |
1562 | unsigned int base = data->BaseAddress; | 1547 | unsigned int base = data->BaseAddress; |
diff --git a/drivers/scsi/pcmcia/qlogic_stub.c b/drivers/scsi/pcmcia/qlogic_stub.c index 4766bcd63692..a0175f5d11cd 100644 --- a/drivers/scsi/pcmcia/qlogic_stub.c +++ b/drivers/scsi/pcmcia/qlogic_stub.c | |||
@@ -81,8 +81,6 @@ static Scsi_Host_Template qlogicfas_driver_template = { | |||
81 | .queuecommand = qlogicfas408_queuecommand, | 81 | .queuecommand = qlogicfas408_queuecommand, |
82 | .eh_abort_handler = qlogicfas408_abort, | 82 | .eh_abort_handler = qlogicfas408_abort, |
83 | .eh_bus_reset_handler = qlogicfas408_bus_reset, | 83 | .eh_bus_reset_handler = qlogicfas408_bus_reset, |
84 | .eh_device_reset_handler= qlogicfas408_device_reset, | ||
85 | .eh_host_reset_handler = qlogicfas408_host_reset, | ||
86 | .bios_param = qlogicfas408_biosparam, | 84 | .bios_param = qlogicfas408_biosparam, |
87 | .can_queue = 1, | 85 | .can_queue = 1, |
88 | .this_id = -1, | 86 | .this_id = -1, |