diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-09-23 21:16:20 -0400 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2013-10-14 09:26:04 -0400 |
commit | 08b7e10716a518af01b07915dbb1938868bbf878 (patch) | |
tree | 685371b0b13af3f05bae2df0efdab1133152f5b4 /drivers/scsi/mvumi.c | |
parent | 6d3be300c658ce3f1777a6b1279414c62bc7d817 (diff) |
SCSI: remove unnecessary pci_set_drvdata()
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: James Bottomley <JBottomley@parallels.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/scsi/mvumi.c')
-rw-r--r-- | drivers/scsi/mvumi.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index c3601b57a80c..edbee8dc62c9 100644 --- a/drivers/scsi/mvumi.c +++ b/drivers/scsi/mvumi.c | |||
@@ -2583,7 +2583,6 @@ static int mvumi_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) | |||
2583 | return 0; | 2583 | return 0; |
2584 | 2584 | ||
2585 | fail_io_attach: | 2585 | fail_io_attach: |
2586 | pci_set_drvdata(pdev, NULL); | ||
2587 | mhba->instancet->disable_intr(mhba); | 2586 | mhba->instancet->disable_intr(mhba); |
2588 | free_irq(mhba->pdev->irq, mhba); | 2587 | free_irq(mhba->pdev->irq, mhba); |
2589 | fail_init_irq: | 2588 | fail_init_irq: |
@@ -2618,7 +2617,6 @@ static void mvumi_detach_one(struct pci_dev *pdev) | |||
2618 | free_irq(mhba->pdev->irq, mhba); | 2617 | free_irq(mhba->pdev->irq, mhba); |
2619 | mvumi_release_fw(mhba); | 2618 | mvumi_release_fw(mhba); |
2620 | scsi_host_put(host); | 2619 | scsi_host_put(host); |
2621 | pci_set_drvdata(pdev, NULL); | ||
2622 | pci_disable_device(pdev); | 2620 | pci_disable_device(pdev); |
2623 | dev_dbg(&pdev->dev, "driver is removed!\n"); | 2621 | dev_dbg(&pdev->dev, "driver is removed!\n"); |
2624 | } | 2622 | } |