diff options
author | James Bottomley <James.Bottomley@suse.de> | 2010-07-27 16:51:13 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-07-28 10:07:49 -0400 |
commit | df64d3caab8db6ae17dacd229a03d7689a10c432 (patch) | |
tree | 247fe4f9f39b22186e42e7f4687dd62c2690e47b /drivers/scsi/mvsas | |
parent | 653c42d552d0fd0b05485442aed45dd2d62269c0 (diff) |
[SCSI] Unify SAM_ and SAM_STAT_ macros
We have two separate definitions for identical constants with nearly the
same name. One comes from the generic headers in scsi.h; the other is
an enum in libsas.h ... it's causing confusion about which one is
correct (fortunately they both are).
Fix this by eliminating the libsas.h duplicate
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/mvsas')
-rw-r--r-- | drivers/scsi/mvsas/mv_sas.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c index cab924239862..adedaa916ecb 100644 --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/scsi/mvsas/mv_sas.c | |||
@@ -1483,7 +1483,7 @@ static int mvs_exec_internal_tmf_task(struct domain_device *dev, | |||
1483 | } | 1483 | } |
1484 | 1484 | ||
1485 | if (task->task_status.resp == SAS_TASK_COMPLETE && | 1485 | if (task->task_status.resp == SAS_TASK_COMPLETE && |
1486 | task->task_status.stat == SAM_GOOD) { | 1486 | task->task_status.stat == SAM_STAT_GOOD) { |
1487 | res = TMF_RESP_FUNC_COMPLETE; | 1487 | res = TMF_RESP_FUNC_COMPLETE; |
1488 | break; | 1488 | break; |
1489 | } | 1489 | } |
@@ -1758,7 +1758,7 @@ static int mvs_sata_done(struct mvs_info *mvi, struct sas_task *task, | |||
1758 | struct mvs_device *mvi_dev = task->dev->lldd_dev; | 1758 | struct mvs_device *mvi_dev = task->dev->lldd_dev; |
1759 | struct task_status_struct *tstat = &task->task_status; | 1759 | struct task_status_struct *tstat = &task->task_status; |
1760 | struct ata_task_resp *resp = (struct ata_task_resp *)tstat->buf; | 1760 | struct ata_task_resp *resp = (struct ata_task_resp *)tstat->buf; |
1761 | int stat = SAM_GOOD; | 1761 | int stat = SAM_STAT_GOOD; |
1762 | 1762 | ||
1763 | 1763 | ||
1764 | resp->frame_len = sizeof(struct dev_to_host_fis); | 1764 | resp->frame_len = sizeof(struct dev_to_host_fis); |
@@ -1790,13 +1790,13 @@ static int mvs_slot_err(struct mvs_info *mvi, struct sas_task *task, | |||
1790 | 1790 | ||
1791 | MVS_CHIP_DISP->command_active(mvi, slot_idx); | 1791 | MVS_CHIP_DISP->command_active(mvi, slot_idx); |
1792 | 1792 | ||
1793 | stat = SAM_CHECK_COND; | 1793 | stat = SAM_STAT_CHECK_CONDITION; |
1794 | switch (task->task_proto) { | 1794 | switch (task->task_proto) { |
1795 | case SAS_PROTOCOL_SSP: | 1795 | case SAS_PROTOCOL_SSP: |
1796 | stat = SAS_ABORTED_TASK; | 1796 | stat = SAS_ABORTED_TASK; |
1797 | break; | 1797 | break; |
1798 | case SAS_PROTOCOL_SMP: | 1798 | case SAS_PROTOCOL_SMP: |
1799 | stat = SAM_CHECK_COND; | 1799 | stat = SAM_STAT_CHECK_CONDITION; |
1800 | break; | 1800 | break; |
1801 | 1801 | ||
1802 | case SAS_PROTOCOL_SATA: | 1802 | case SAS_PROTOCOL_SATA: |
@@ -1881,7 +1881,7 @@ int mvs_slot_complete(struct mvs_info *mvi, u32 rx_desc, u32 flags) | |||
1881 | case SAS_PROTOCOL_SSP: | 1881 | case SAS_PROTOCOL_SSP: |
1882 | /* hw says status == 0, datapres == 0 */ | 1882 | /* hw says status == 0, datapres == 0 */ |
1883 | if (rx_desc & RXQ_GOOD) { | 1883 | if (rx_desc & RXQ_GOOD) { |
1884 | tstat->stat = SAM_GOOD; | 1884 | tstat->stat = SAM_STAT_GOOD; |
1885 | tstat->resp = SAS_TASK_COMPLETE; | 1885 | tstat->resp = SAS_TASK_COMPLETE; |
1886 | } | 1886 | } |
1887 | /* response frame present */ | 1887 | /* response frame present */ |
@@ -1890,12 +1890,12 @@ int mvs_slot_complete(struct mvs_info *mvi, u32 rx_desc, u32 flags) | |||
1890 | sizeof(struct mvs_err_info); | 1890 | sizeof(struct mvs_err_info); |
1891 | sas_ssp_task_response(mvi->dev, task, iu); | 1891 | sas_ssp_task_response(mvi->dev, task, iu); |
1892 | } else | 1892 | } else |
1893 | tstat->stat = SAM_CHECK_COND; | 1893 | tstat->stat = SAM_STAT_CHECK_CONDITION; |
1894 | break; | 1894 | break; |
1895 | 1895 | ||
1896 | case SAS_PROTOCOL_SMP: { | 1896 | case SAS_PROTOCOL_SMP: { |
1897 | struct scatterlist *sg_resp = &task->smp_task.smp_resp; | 1897 | struct scatterlist *sg_resp = &task->smp_task.smp_resp; |
1898 | tstat->stat = SAM_GOOD; | 1898 | tstat->stat = SAM_STAT_GOOD; |
1899 | to = kmap_atomic(sg_page(sg_resp), KM_IRQ0); | 1899 | to = kmap_atomic(sg_page(sg_resp), KM_IRQ0); |
1900 | memcpy(to + sg_resp->offset, | 1900 | memcpy(to + sg_resp->offset, |
1901 | slot->response + sizeof(struct mvs_err_info), | 1901 | slot->response + sizeof(struct mvs_err_info), |
@@ -1912,7 +1912,7 @@ int mvs_slot_complete(struct mvs_info *mvi, u32 rx_desc, u32 flags) | |||
1912 | } | 1912 | } |
1913 | 1913 | ||
1914 | default: | 1914 | default: |
1915 | tstat->stat = SAM_CHECK_COND; | 1915 | tstat->stat = SAM_STAT_CHECK_CONDITION; |
1916 | break; | 1916 | break; |
1917 | } | 1917 | } |
1918 | if (!slot->port->port_attached) { | 1918 | if (!slot->port->port_attached) { |