[SCSI] mpt2sas: Fix security scan issues reported by source code analysis tool

Modified the source code as per the findings reported by the source
code analysis tool. Source code for the following functionalities
has been touched. None of the driver functionalities has changed.

- SMP Passthrough IOCTL
- Debug messages for MPT Replies (i.e. bit 9 of Logging Level)
- Task Management using sysfs
- Device removal, i.e. when a target device (including any PD within a volume)
  is removed, and Volume Deletion.
- Trace Buffer

Signed-off-by: Nagalakshmi Nandigama <nagalakshmi.nandigama@lsi.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

1 files changed, 13 insertions, 6 deletions

diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 30d540a05ad8..f162db3a0c05 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -699,6 +699,11 @@ _base_display_reply_info(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 msix_index,
         u16 ioc_status;
 
         mpi_reply = mpt2sas_base_get_reply_virt_addr(ioc, reply);
+        if (unlikely(!mpi_reply)) {
+                printk(MPT2SAS_ERR_FMT "mpi_reply not valid at %s:%d/%s()!\n",
+                        ioc->name, __FILE__, __LINE__, __func__);
+                return;
+        }
         ioc_status = le16_to_cpu(mpi_reply->IOCStatus);
 #ifdef CONFIG_SCSI_MPT2SAS_LOGGING
         if ((ioc_status & MPI2_IOCSTATUS_MASK) &&
@@ -930,16 +935,18 @@ _base_interrupt(int irq, void *bus_id)
                 else if (request_desript_type ==
                     MPI2_RPY_DESCRIPT_FLAGS_TARGETASSIST_SUCCESS)
                         goto next;
-                if (smid)
+                if (smid) {
                         cb_idx = _base_get_cb_idx(ioc, smid);
-                if (smid && cb_idx != 0xFF) {
-                        rc = mpt_callbacks[cb_idx](ioc, smid, msix_index,
-                            reply);
+                if ((likely(cb_idx < MPT_MAX_CALLBACKS))
+                            && (likely(mpt_callbacks[cb_idx] != NULL))) {
+                                rc = mpt_callbacks[cb_idx](ioc, smid,
+                                    msix_index, reply);
                         if (reply)
-                                _base_display_reply_info(ioc, smid, msix_index,
-                                    reply);
+                                _base_display_reply_info(ioc, smid,
+                                    msix_index, reply);
                         if (rc)
                                 mpt2sas_base_free_smid(ioc, smid);
+                        }
                 }
                 if (!smid)
                         _base_async_event(ioc, msix_index, reply);