[SCSI] lpfc 8.2.8 : Miscellaneous Bug Fixes

Miscellaneous Fixes:
- Fix the wrong variable name used for checking node active usage status
- Fix numerous duplicate log message numbers
- Fix change KERN_WARNING messages to KERN_INFO.
- Stop sending erroneous LOGO to fabric after vport is already terminated
- Fix HBQ allocates that were kalloc'ing w/ GFP_KERNEL while holding a lock.
- Fix gcc 4.3.2 compiler warnings and a sparse warning
- Fix bugs in handling unsolicited ct event queue
- Reorder some of the initial link up checks, to remove odd VPI states.
- Correct poor VPI handling
- Add debug messages
- Expand Update_CFG mailbox definition
- Fix handling of VPD data offsets
- Reorder loopback flags
- convert to use offsetof()

Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

1 files changed, 11 insertions, 3 deletions

diff --git a/drivers/scsi/lpfc/lpfc_vport.c b/drivers/scsi/lpfc/lpfc_vport.c
index ad0f65313878..2578d5fd9537 100644
--- a/drivers/scsi/lpfc/lpfc_vport.c
+++ b/drivers/scsi/lpfc/lpfc_vport.c
@@ -577,8 +577,12 @@ lpfc_vport_delete(struct fc_vport *fc_vport)
          * initiated after we've disposed of all other resources associated
          * with the port.
          */
-        if (!scsi_host_get(shost) || !scsi_host_get(shost))
+        if (!scsi_host_get(shost))
                 return VPORT_INVAL;
+        if (!scsi_host_get(shost)) {
+                scsi_host_put(shost);
+                return VPORT_INVAL;
+        }
         spin_lock_irq(&phba->hbalock);
         vport->load_flag |= FC_UNLOADING;
         spin_unlock_irq(&phba->hbalock);
@@ -668,6 +672,8 @@ lpfc_vport_delete(struct fc_vport *fc_vport)
                 }
                 vport->unreg_vpi_cmpl = VPORT_INVAL;
                 timeout = msecs_to_jiffies(phba->fc_ratov * 2000);
+                if (ndlp->nlp_state == NLP_STE_UNUSED_NODE)
+                        goto skip_logo;
                 if (!lpfc_issue_els_npiv_logo(vport, ndlp))
                         while (vport->unreg_vpi_cmpl == VPORT_INVAL && timeout)
                                 timeout = schedule_timeout(timeout);
@@ -689,8 +695,10 @@ skip_logo:
                  * Completion of unreg_vpi (lpfc_mbx_cmpl_unreg_vpi)
                  * does the scsi_host_put() to release the vport.
                  */
-                lpfc_mbx_unreg_vpi(vport);
-        }
+                if (lpfc_mbx_unreg_vpi(vport))
+                        scsi_host_put(shost);
+        } else
+                scsi_host_put(shost);
 
         lpfc_free_vpi(phba, vport->vpi);
         vport->work_port_events = 0;