[SCSI] lpfc 8.2.8 : Miscellaneous Bug Fixes

Miscellaneous Fixes:
- Fix the wrong variable name used for checking node active usage status
- Fix numerous duplicate log message numbers
- Fix change KERN_WARNING messages to KERN_INFO.
- Stop sending erroneous LOGO to fabric after vport is already terminated
- Fix HBQ allocates that were kalloc'ing w/ GFP_KERNEL while holding a lock.
- Fix gcc 4.3.2 compiler warnings and a sparse warning
- Fix bugs in handling unsolicited ct event queue
- Reorder some of the initial link up checks, to remove odd VPI states.
- Correct poor VPI handling
- Add debug messages
- Expand Update_CFG mailbox definition
- Fix handling of VPD data offsets
- Reorder loopback flags
- convert to use offsetof()

Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

1 files changed, 7 insertions, 8 deletions

diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 0f387862cf77..71cfee884b8a 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -134,25 +134,24 @@ lpfc_ct_unsol_event(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
                 }
                 list_del(&head);
         } else {
-                struct lpfc_iocbq  *next;
-
-                list_for_each_entry_safe(iocbq, next, &piocbq->list, list) {
+                INIT_LIST_HEAD(&head);
+                list_add_tail(&head, &piocbq->list);
+                list_for_each_entry(iocbq, &head, list) {
                         icmd = &iocbq->iocb;
                         if (icmd->ulpBdeCount == 0)
-                                lpfc_ct_unsol_buffer(phba, piocbq, NULL, 0);
+                                lpfc_ct_unsol_buffer(phba, iocbq, NULL, 0);
                         for (i = 0; i < icmd->ulpBdeCount; i++) {
                                 paddr = getPaddr(icmd->un.cont64[i].addrHigh,
                                                  icmd->un.cont64[i].addrLow);
                                 mp = lpfc_sli_ringpostbuf_get(phba, pring,
                                                               paddr);
                                 size = icmd->un.cont64[i].tus.f.bdeSize;
-                                lpfc_ct_unsol_buffer(phba, piocbq, mp, size);
+                                lpfc_ct_unsol_buffer(phba, iocbq, mp, size);
                                 lpfc_in_buf_free(phba, mp);
                         }
-                        list_del(&iocbq->list);
-                        lpfc_sli_release_iocbq(phba, iocbq);
                         lpfc_post_buffer(phba, pring, i);
                 }
+                list_del(&head);
         }
 }
 
@@ -861,7 +860,7 @@ lpfc_cmpl_ct(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
 
                 retry++;
                 lpfc_printf_vlog(vport, KERN_INFO, LOG_DISCOVERY,
-                                 "0216 Retrying NS cmd %x\n", cmdcode);
+                                 "0250 Retrying NS cmd %x\n", cmdcode);
                 rc = lpfc_ns_cmd(vport, cmdcode, retry, 0);
                 if (rc == 0)
                         goto out;