[SCSI] lpfc: Fix for "command completion for iotax x?? not found"

From: James Smart <James.Smart@emulex.com>

There were scenarios where the error handlers could reuse an iotag
value of an active io.  Remove all possibility of this by
pre-assigning iotag resources to command resources.

Signed-off-by: James Smart <James.Smart@emulex.com>

Rejections fixed up and
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

1 files changed, 4 insertions, 5 deletions

diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 1280f0e54636..40c34a30a94a 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -235,7 +235,6 @@ lpfc_gen_req(struct lpfc_hba *phba, struct lpfc_dmabuf *bmp,
 
         if (geniocb == NULL)
                 return 1;
-        memset(geniocb, 0, sizeof (struct lpfc_iocbq));
 
         icmd = &geniocb->iocb;
         icmd->un.genreq64.bdl.ulpIoTag32 = 0;
@@ -279,7 +278,7 @@ lpfc_gen_req(struct lpfc_hba *phba, struct lpfc_dmabuf *bmp,
         geniocb->drvrTimeout = icmd->ulpTimeout + LPFC_DRVR_TIMEOUT;
         spin_lock_irq(phba->host->host_lock);
         if (lpfc_sli_issue_iocb(phba, pring, geniocb, 0) == IOCB_ERROR) {
-                list_add_tail(&geniocb->list, lpfc_iocb_list);
+                lpfc_sli_release_iocbq(phba, geniocb);
                 spin_unlock_irq(phba->host->host_lock);
                 return 1;
         }
@@ -487,7 +486,7 @@ out:
         kfree(inp);
         kfree(bmp);
         spin_lock_irq(phba->host->host_lock);
-        list_add_tail(&cmdiocb->list, &phba->lpfc_iocb_list);
+        lpfc_sli_release_iocbq(phba, cmdiocb);
         spin_unlock_irq(phba->host->host_lock);
         return;
 }
@@ -526,7 +525,7 @@ lpfc_cmpl_ct_cmd_rft_id(struct lpfc_hba * phba, struct lpfc_iocbq * cmdiocb,
         kfree(inp);
         kfree(bmp);
         spin_lock_irq(phba->host->host_lock);
-        list_add_tail(&cmdiocb->list, &phba->lpfc_iocb_list);
+        lpfc_sli_release_iocbq(phba, cmdiocb);
         spin_unlock_irq(phba->host->host_lock);
         return;
 }
@@ -735,7 +734,7 @@ lpfc_cmpl_ct_cmd_fdmi(struct lpfc_hba * phba,
         kfree(inp);
         kfree(bmp);
         spin_lock_irq(phba->host->host_lock);
-        list_add_tail(&cmdiocb->list, &phba->lpfc_iocb_list);
+        lpfc_sli_release_iocbq(phba, cmdiocb);
         spin_unlock_irq(phba->host->host_lock);
         return;
 }