[SCSI] lpfc 8.3.18: Fix critical errors

Fix critical errors

- Update send_scsi_event to validate pnode pointer active before copying
  the wwpn information.
- Add a message, mailbox_idle, and unlock before failing SECURITY_MGMT
  or AUTH_PORT mailbox commands
- Prevent spin_lock_irqsave from being called twice in a row.

Signed-off-by: Alex Iannicelli <alex.iannicelli@emulex.com>
Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

1 files changed, 6 insertions, 1 deletions

diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index f681eea57730..c1cbec01345d 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -3789,8 +3789,13 @@ sysfs_mbox_read(struct file *filp, struct kobject *kobj,
                         break;
                 case MBX_SECURITY_MGMT:
                 case MBX_AUTH_PORT:
-                        if (phba->pci_dev_grp == LPFC_PCI_DEV_OC)
+                        if (phba->pci_dev_grp == LPFC_PCI_DEV_OC) {
+                                printk(KERN_WARNING "mbox_read:Command 0x%x "
+                                       "is not permitted\n", pmb->mbxCommand);
+                                sysfs_mbox_idle(phba);
+                                spin_unlock_irq(&phba->hbalock);
                                 return -EPERM;
+                        }
                         break;
                 case MBX_READ_SPARM64:
                 case MBX_READ_LA: